[jira] [Commented] (HELIX-537) org.apache.helix.task.TaskStateModel should have a shutdown method.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HELIX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14206903#comment-14206903 ] 

ASF GitHub Bot commented on HELIX-537:
--------------------------------------

GitHub user atcurtis opened a pull request:

    https://github.com/apache/helix/pull/8

    [HELIX-537] Shutdown executors

    https://issues.apache.org/jira/browse/HELIX-537


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/atcurtis/helix HELIX-537

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/8.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #8
    
----
commit d6fbcf17e01439a290a0cc273933660274841663
Author: Antony T Curtis <ac...@linkedin.com>
Date:   2014-11-11T19:17:43Z

    [HELIX-537] Shutdown executors

----


> org.apache.helix.task.TaskStateModel should have a shutdown method.
> -------------------------------------------------------------------
>
>                 Key: HELIX-537
>                 URL: https://issues.apache.org/jira/browse/HELIX-537
>             Project: Apache Helix
>          Issue Type: Bug
>          Components: helix-core
>    Affects Versions: 0.6.3
>            Reporter: Antony T Curtis
>            Priority: Blocker
>
> There should be a shutdown method to terminate the Timer and Executor which the org.apache.helix.task.TaskStateModel class creates.
> ie.
> {noformat}
> public boolean shutdown(long timeout, TimeUnit unit)
>   throws InterruptedException
> {
>   reset();
>   _taskExecutor.shutdown();
>   _timer.cancel();
>   return _taskExecutor.awaitTermination(timeout, unit);
> }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)