You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hubgeter (via GitHub)" <gi...@apache.org> on 2026/01/17 02:53:51 UTC
[PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
hubgeter opened a new pull request, #59984:
URL: https://github.com/apache/doris/pull/59984
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3768557623
# FE Regression Coverage Report
Increment line coverage ` 93.40% (99/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3772737803
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3771837417
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/20c7e03b9d38156a4023b0e63788a8a9ba218bb1_20c7e03b9d38156a4023b0e63788a8a9ba218bb1_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/20c7e03b9d38156a4023b0e63788a8a9ba218bb1_20c7e03b9d38156a4023b0e63788a8a9ba218bb1_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.73% (31793/49114) |
| Region Coverage | 65.42% (15833/24201) |
| Branch Coverage | 55.98% (8412/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4017533808
# FE UT Coverage Report
Increment line coverage ` 70.75% (75/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4030551179
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/72d63164804b44f0c2989ec206c6e20dc386ffe8_72d63164804b44f0c2989ec206c6e20dc386ffe8_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/72d63164804b44f0c2989ec206c6e20dc386ffe8_72d63164804b44f0c2989ec206c6e20dc386ffe8_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.45% (1798/2263) |
| Line Coverage | 64.68% (32262/49881) |
| Region Coverage | 65.65% (16157/24611) |
| Branch Coverage | 56.02% (8605/15360) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4035984692
# FE UT Coverage Report
Increment line coverage ` 70.75% (75/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_73f720ac919fc9b5631dfe4335c31b2c13e7e90f/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_73f720ac919fc9b5631dfe4335c31b2c13e7e90f/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4030649818
<details>
<summary>TPC-H: <b>Total hot run time: 27752 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 72d63164804b44f0c2989ec206c6e20dc386ffe8, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17449 4424 4281 4281
q2 q3 10480 801 515 515
q4 4672 359 249 249
q5 7555 1202 1038 1038
q6 178 177 145 145
q7 799 826 658 658
q8 9314 1458 1326 1326
q9 4691 4778 4752 4752
q10 6312 1897 1647 1647
q11 457 264 232 232
q12 702 590 470 470
q13 18044 2932 2185 2185
q14 234 232 216 216
q15 931 797 822 797
q16 752 718 675 675
q17 720 862 402 402
q18 5896 5425 5317 5317
q19 1515 997 603 603
q20 515 498 384 384
q21 4460 1906 1600 1600
q22 394 313 260 260
Total cold run time: 96070 ms
Total hot run time: 27752 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4760 4600 4561 4561
q2 q3 3930 4331 3853 3853
q4 876 1172 815 815
q5 4051 4381 4328 4328
q6 178 179 140 140
q7 1762 1628 1519 1519
q8 2457 2695 2584 2584
q9 7515 7481 7397 7397
q10 3727 3941 3565 3565
q11 512 435 415 415
q12 480 617 439 439
q13 2819 3347 2303 2303
q14 278 291 290 290
q15 829 794 784 784
q16 883 766 721 721
q17 1139 1413 1363 1363
q18 7303 6799 6854 6799
q19 872 871 854 854
q20 2066 2180 2047 2047
q21 4023 3440 3346 3346
q22 492 434 375 375
Total cold run time: 50952 ms
Total hot run time: 48498 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3991594484
# BE UT Coverage Report
Increment line coverage `11.13% (67/602)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.57% (19636/37351) |
| Line Coverage | 36.15% (183268/506898) |
| Region Coverage | 32.46% (142238/438140) |
| Branch Coverage | 33.40% (61671/184623) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4017388238
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4036501908
# BE Regression && UT Coverage Report
Increment line coverage `71.14% (429/603)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_73f720ac919fc9b5631dfe4335c31b2c13e7e90f_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_73f720ac919fc9b5631dfe4335c31b2c13e7e90f_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.19% (26791/36605) |
| Line Coverage | 56.47% (285348/505337) |
| Region Coverage | 53.78% (238012/442598) |
| Branch Coverage | 55.49% (102784/185233) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3765072565
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3774116327
# BE Regression && UT Coverage Report
Increment line coverage `71.59% (431/602)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_71fff849d4c70963d0a9cedb12b837ef19f49516_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_71fff849d4c70963d0a9cedb12b837ef19f49516_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.13% (26057/35629) |
| Line Coverage | 56.11% (277193/494024) |
| Region Coverage | 53.76% (230447/428664) |
| Branch Coverage | 55.48% (99418/179199) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3768027220
<details>
<summary>TPC-H: <b>Total hot run time: 32029 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ac0efd13d860451af1fb3ab08b8bdbc89c2eba42, data reload: false
------ Round 1 ----------------------------------
q1 17651 4217 4082 4082
q2 2031 353 245 245
q3 10082 1271 713 713
q4 10224 858 306 306
q5 7548 2120 1843 1843
q6 192 172 140 140
q7 926 782 649 649
q8 9274 1474 1163 1163
q9 4902 4634 4549 4549
q10 6781 1834 1406 1406
q11 533 303 284 284
q12 697 731 606 606
q13 17794 3845 3056 3056
q14 294 290 274 274
q15 580 522 513 513
q16 696 682 628 628
q17 661 844 476 476
q18 7187 6608 6850 6608
q19 1352 1049 673 673
q20 402 375 257 257
q21 3353 2677 2539 2539
q22 1150 1086 1019 1019
Total cold run time: 104310 ms
Total hot run time: 32029 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4317 4274 4232 4232
q2 326 385 340 340
q3 2308 2862 2403 2403
q4 1498 1955 1545 1545
q5 4421 4321 4453 4321
q6 225 204 160 160
q7 2039 1839 1844 1839
q8 2597 2409 2316 2316
q9 7121 7331 7167 7167
q10 2444 2739 2326 2326
q11 539 461 420 420
q12 686 717 568 568
q13 3295 3812 3092 3092
q14 276 277 266 266
q15 544 493 486 486
q16 623 657 618 618
q17 1099 1237 1293 1237
q18 7282 7155 7343 7155
q19 840 796 807 796
q20 1869 1944 1805 1805
q21 4503 4255 4062 4062
q22 1057 1028 983 983
Total cold run time: 49909 ms
Total hot run time: 48137 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3898139898
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/815d165f2d72ca3f76895e85341115b4aaf10370_815d165f2d72ca3f76895e85341115b4aaf10370_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/815d165f2d72ca3f76895e85341115b4aaf10370_815d165f2d72ca3f76895e85341115b4aaf10370_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.33% (1796/2264) |
| Line Coverage | 64.80% (31995/49372) |
| Region Coverage | 65.51% (15971/24378) |
| Branch Coverage | 56.00% (8492/15164) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3771952367
<details>
<summary>TPC-H: <b>Total hot run time: 31462 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 20c7e03b9d38156a4023b0e63788a8a9ba218bb1, data reload: false
------ Round 1 ----------------------------------
q1 17263 4249 4065 4065
q2 2046 350 250 250
q3 10010 1280 725 725
q4 10204 854 300 300
q5 7539 2088 1849 1849
q6 200 175 139 139
q7 907 781 651 651
q8 9265 1374 1114 1114
q9 4875 4549 4561 4549
q10 6740 1810 1419 1419
q11 537 312 289 289
q12 688 748 612 612
q13 17773 3899 3063 3063
q14 288 299 272 272
q15 595 524 509 509
q16 717 686 665 665
q17 667 771 504 504
q18 6564 6390 6368 6368
q19 1129 981 629 629
q20 403 360 254 254
q21 3006 2473 2283 2283
q22 1028 1008 953 953
Total cold run time: 102444 ms
Total hot run time: 31462 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4171 4088 4033 4033
q2 332 378 325 325
q3 2093 2615 2221 2221
q4 1333 1713 1401 1401
q5 4074 4006 3948 3948
q6 216 170 128 128
q7 1898 1790 1706 1706
q8 2786 2461 2388 2388
q9 7334 7322 7205 7205
q10 2512 2758 2340 2340
q11 572 480 453 453
q12 771 808 635 635
q13 3637 4202 3568 3568
q14 290 298 293 293
q15 559 519 514 514
q16 678 697 665 665
q17 1195 1441 1447 1441
q18 8146 8035 7885 7885
q19 877 847 896 847
q20 2023 2053 1891 1891
q21 4755 4227 4047 4047
q22 1069 1006 1040 1006
Total cold run time: 51321 ms
Total hot run time: 48940 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3771197926
<details>
<summary>ClickBench: <b>Total hot run time: 27.83 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5c7bfd69abc6283248d1db91e6520d17ba11f51f, data reload: false
query1 0.05 0.05 0.04
query2 0.13 0.06 0.06
query3 0.33 0.09 0.08
query4 1.60 0.10 0.11
query5 0.27 0.25 0.26
query6 1.15 0.64 0.65
query7 0.03 0.02 0.03
query8 0.08 0.06 0.07
query9 0.58 0.49 0.49
query10 0.55 0.54 0.55
query11 0.27 0.13 0.13
query12 0.26 0.15 0.14
query13 0.62 0.63 0.60
query14 0.97 0.96 0.98
query15 0.90 0.82 0.83
query16 0.39 0.39 0.39
query17 1.05 1.02 1.04
query18 0.24 0.22 0.22
query19 1.91 1.81 1.82
query20 0.02 0.02 0.02
query21 15.42 0.30 0.24
query22 4.93 0.10 0.10
query23 15.39 0.40 0.23
query24 2.36 0.51 0.31
query25 0.10 0.10 0.10
query26 0.18 0.18 0.16
query27 0.10 0.09 0.09
query28 3.68 1.13 0.96
query29 12.52 3.98 3.24
query30 0.35 0.13 0.11
query31 2.79 0.68 0.44
query32 3.24 0.63 0.50
query33 3.02 3.05 3.07
query34 16.04 5.10 4.47
query35 4.51 4.49 4.43
query36 0.61 0.51 0.50
query37 0.24 0.09 0.09
query38 0.20 0.06 0.05
query39 0.08 0.05 0.05
query40 0.21 0.18 0.16
query41 0.14 0.06 0.06
query42 0.08 0.05 0.05
query43 0.07 0.05 0.06
Total cold run time: 97.66 s
Total hot run time: 27.83 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3771719985
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3770902084
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4021971958
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/6960a01f85d1459d53a9dc11ea9f6202f5f81064_6960a01f85d1459d53a9dc11ea9f6202f5f81064_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/6960a01f85d1459d53a9dc11ea9f6202f5f81064_6960a01f85d1459d53a9dc11ea9f6202f5f81064_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.35% (1798/2266) |
| Line Coverage | 64.58% (32232/49910) |
| Region Coverage | 65.49% (16145/24653) |
| Branch Coverage | 55.98% (8599/15360) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4035999371
# BE UT Coverage Report
Increment line coverage `11.11% (67/603)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/73f720ac919fc9b5631dfe4335c31b2c13e7e90f_73f720ac919fc9b5631dfe4335c31b2c13e7e90f/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/73f720ac919fc9b5631dfe4335c31b2c13e7e90f_73f720ac919fc9b5631dfe4335c31b2c13e7e90f/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.56% (19650/37383) |
| Line Coverage | 36.14% (183168/506876) |
| Region Coverage | 32.28% (141536/438450) |
| Branch Coverage | 33.43% (61739/184657) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3991000866
<details>
<summary>TPC-DS: <b>Total hot run time: 184140 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d5b0951cd1524edab2e1e42b97836f2b9c5d39bd, data reload: false
query5 4343 638 506 506
query6 335 216 193 193
query7 4217 479 270 270
query8 350 249 238 238
query9 8749 2797 2801 2797
query10 543 394 327 327
query11 16859 17314 17178 17178
query12 191 132 131 131
query13 1318 493 362 362
query14 6774 3336 3089 3089
query14_1 2924 2925 2964 2925
query15 212 209 188 188
query16 1022 519 453 453
query17 1228 737 616 616
query18 2973 478 363 363
query19 209 203 178 178
query20 130 123 124 123
query21 218 135 113 113
query22 4715 4900 4748 4748
query23 17296 16821 16638 16638
query23_1 16727 16685 16674 16674
query24 7212 1608 1250 1250
query24_1 1223 1222 1227 1222
query25 580 458 399 399
query26 1246 257 152 152
query27 2798 468 283 283
query28 4491 1893 1908 1893
query29 807 555 460 460
query30 314 245 209 209
query31 871 730 654 654
query32 82 76 71 71
query33 528 342 284 284
query34 917 894 567 567
query35 630 679 614 614
query36 1130 1193 949 949
query37 136 92 80 80
query38 2918 2925 2893 2893
query39 872 896 870 870
query39_1 833 835 831 831
query40 228 158 138 138
query41 62 60 58 58
query42 107 104 107 104
query43 398 377 344 344
query44
query45 197 198 183 183
query46 887 994 603 603
query47 2158 2162 2121 2121
query48 311 312 229 229
query49 626 465 375 375
query50 683 284 233 233
query51 4104 4159 4108 4108
query52 115 110 98 98
query53 292 341 295 295
query54 301 281 263 263
query55 90 85 83 83
query56 333 327 328 327
query57 1406 1365 1304 1304
query58 295 282 277 277
query59 2633 2763 2674 2674
query60 343 348 341 341
query61 147 147 145 145
query62 607 591 527 527
query63 318 283 279 279
query64 4993 1282 1095 1095
query65
query66 1468 477 387 387
query67 16320 16384 16291 16291
query68
query69 407 320 300 300
query70 1047 994 954 954
query71 349 315 305 305
query72 2910 2774 2402 2402
query73 533 540 321 321
query74 9966 9933 9750 9750
query75 2820 2775 2475 2475
query76 2301 1036 686 686
query77 362 390 304 304
query78 11334 11446 10692 10692
query79 1183 795 601 601
query80 1352 638 527 527
query81 566 292 247 247
query82 1006 144 115 115
query83 371 259 237 237
query84 249 123 98 98
query85 1021 482 427 427
query86 430 331 298 298
query87 3135 3097 3053 3053
query88 3540 2718 2686 2686
query89 431 371 336 336
query90 1891 170 174 170
query91 172 154 134 134
query92 82 73 76 73
query93 964 875 524 524
query94 643 307 309 307
query95 586 338 323 323
query96 654 508 227 227
query97 2472 2498 2464 2464
query98 234 237 216 216
query99 993 995 916 916
Total cold run time: 253536 ms
Total hot run time: 184140 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3772876724
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/71fff849d4c70963d0a9cedb12b837ef19f49516_71fff849d4c70963d0a9cedb12b837ef19f49516_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/71fff849d4c70963d0a9cedb12b837ef19f49516_71fff849d4c70963d0a9cedb12b837ef19f49516_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.78% (31818/49114) |
| Region Coverage | 65.52% (15856/24201) |
| Branch Coverage | 56.07% (8426/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3773869752
# BE UT Coverage Report
Increment line coverage `11.13% (67/602)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/71fff849d4c70963d0a9cedb12b837ef19f49516_71fff849d4c70963d0a9cedb12b837ef19f49516/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/71fff849d4c70963d0a9cedb12b837ef19f49516_71fff849d4c70963d0a9cedb12b837ef19f49516/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.43% (19058/36350) |
| Line Coverage | 35.69% (176536/494582) |
| Region Coverage | 32.23% (136707/424161) |
| Branch Coverage | 33.14% (59128/178438) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3771035477
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_5c7bfd69abc6283248d1db91e6520d17ba11f51f/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_5c7bfd69abc6283248d1db91e6520d17ba11f51f/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3773350548
<details>
<summary>TPC-DS: <b>Total hot run time: 174098 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 71fff849d4c70963d0a9cedb12b837ef19f49516, data reload: false
query5 4381 608 489 489
query6 320 215 200 200
query7 4201 452 253 253
query8 335 245 220 220
query9 8709 2931 2876 2876
query10 498 383 328 328
query11 15238 15184 14868 14868
query12 166 115 117 115
query13 1253 485 396 396
query14 5954 3017 2763 2763
query14_1 2697 2638 2640 2638
query15 210 190 170 170
query16 989 504 478 478
query17 1088 667 555 555
query18 2443 430 330 330
query19 226 216 193 193
query20 119 115 112 112
query21 218 136 115 115
query22 3888 4212 4107 4107
query23 16029 15649 15198 15198
query23_1 15452 15428 15531 15428
query24 7076 1535 1161 1161
query24_1 1170 1161 1159 1159
query25 504 432 380 380
query26 1255 264 146 146
query27 2769 446 270 270
query28 4570 2186 2170 2170
query29 728 509 403 403
query30 313 237 201 201
query31 794 611 536 536
query32 82 75 69 69
query33 506 345 298 298
query34 899 856 534 534
query35 718 810 664 664
query36 858 940 830 830
query37 127 91 82 82
query38 2730 2738 2658 2658
query39 764 756 724 724
query39_1 695 738 712 712
query40 216 136 116 116
query41 66 60 60 60
query42 103 101 105 101
query43 447 476 417 417
query44 1328 749 742 742
query45 185 189 174 174
query46 831 925 561 561
query47 1372 1414 1373 1373
query48 319 326 239 239
query49 596 441 339 339
query50 619 263 208 208
query51 3796 3822 3855 3822
query52 107 107 98 98
query53 294 315 265 265
query54 291 259 253 253
query55 80 81 75 75
query56 299 314 303 303
query57 1011 1033 937 937
query58 267 264 257 257
query59 2061 2070 2081 2070
query60 324 330 312 312
query61 149 150 147 147
query62 391 363 317 317
query63 293 271 265 265
query64 4876 1248 954 954
query65 3831 3759 3765 3759
query66 1468 429 302 302
query67 15577 15478 15408 15408
query68 2368 1101 749 749
query69 434 349 324 324
query70 1005 982 876 876
query71 334 315 302 302
query72 5448 3339 3375 3339
query73 598 735 317 317
query74 8783 8767 8625 8625
query75 2740 2789 2464 2464
query76 2271 1059 648 648
query77 353 374 312 312
query78 9829 10014 9225 9225
query79 1139 929 581 581
query80 1344 576 484 484
query81 551 258 226 226
query82 998 149 111 111
query83 361 258 252 252
query84 255 113 94 94
query85 1037 500 416 416
query86 423 326 283 283
query87 2813 2887 2738 2738
query88 3514 2586 2566 2566
query89 389 354 312 312
query90 1934 177 174 174
query91 171 158 129 129
query92 76 74 71 71
query93 1142 948 545 545
query94 642 315 295 295
query95 592 388 322 322
query96 659 518 231 231
query97 2337 2374 2332 2332
query98 218 204 202 202
query99 622 585 523 523
Total cold run time: 247001 ms
Total hot run time: 174098 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3896462043
<details>
<summary>TPC-H: <b>Total hot run time: 29365 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit abc1a71a8e92f0722c9f5566d24a651a5f57b8f9, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17604 4489 4304 4304
q2 q3 10720 769 524 524
q4 4730 369 252 252
q5 8089 1211 1041 1041
q6 241 175 145 145
q7 830 869 671 671
q8 10796 1494 1370 1370
q9 6638 4800 4777 4777
q10 6865 1878 1643 1643
q11 476 261 242 242
q12 761 561 468 468
q13 17821 4238 3433 3433
q14 236 239 217 217
q15 968 803 805 803
q16 741 716 686 686
q17 772 898 441 441
q18 6556 5353 5233 5233
q19 1181 979 959 959
q20 605 566 432 432
q21 4543 1950 1460 1460
q22 356 298 264 264
Total cold run time: 101529 ms
Total hot run time: 29365 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4688 4513 4564 4513
q2 q3 1792 2218 1764 1764
q4 901 1199 776 776
q5 4140 4436 4354 4354
q6 178 173 139 139
q7 1775 1663 1523 1523
q8 2572 2695 2638 2638
q9 7553 7402 7433 7402
q10 2756 2862 2595 2595
q11 503 429 506 429
q12 503 583 451 451
q13 4026 4482 3634 3634
q14 276 283 278 278
q15 844 853 825 825
q16 722 781 705 705
q17 1200 1512 1302 1302
q18 7100 6834 6649 6649
q19 894 882 917 882
q20 2165 2211 2023 2023
q21 4178 3552 3322 3322
q22 491 467 409 409
Total cold run time: 49257 ms
Total hot run time: 46613 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3776184761
<details>
<summary>TPC-DS: <b>Total hot run time: 173991 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 774c62d2828db275c3e383b7be1611bfa1ab3ec1, data reload: false
query5 4440 614 464 464
query6 332 228 206 206
query7 4219 455 252 252
query8 346 261 234 234
query9 8683 2912 2923 2912
query10 526 370 335 335
query11 15261 15216 14987 14987
query12 173 115 113 113
query13 1246 475 395 395
query14 6190 2988 2801 2801
query14_1 2665 2639 2650 2639
query15 213 193 180 180
query16 963 486 459 459
query17 1097 655 558 558
query18 2432 438 331 331
query19 227 223 191 191
query20 122 118 118 118
query21 228 138 120 120
query22 3914 4270 4096 4096
query23 15989 15661 15403 15403
query23_1 15485 15442 15378 15378
query24 7098 1553 1196 1196
query24_1 1174 1188 1175 1175
query25 549 460 368 368
query26 1243 272 152 152
query27 2764 441 272 272
query28 4613 2208 2179 2179
query29 740 495 405 405
query30 306 242 205 205
query31 777 627 561 561
query32 81 76 70 70
query33 524 342 301 301
query34 907 876 541 541
query35 722 742 671 671
query36 891 918 825 825
query37 128 94 85 85
query38 2647 2755 2639 2639
query39 769 760 724 724
query39_1 717 711 703 703
query40 215 132 119 119
query41 68 62 62 62
query42 104 101 101 101
query43 460 436 391 391
query44 1328 749 742 742
query45 190 187 172 172
query46 834 953 585 585
query47 1425 1488 1355 1355
query48 310 314 250 250
query49 605 417 334 334
query50 619 281 201 201
query51 3747 3778 3818 3778
query52 104 106 94 94
query53 290 320 269 269
query54 284 263 252 252
query55 83 80 77 77
query56 303 300 289 289
query57 1045 1022 887 887
query58 263 249 254 249
query59 2081 2170 2092 2092
query60 330 333 309 309
query61 145 148 145 145
query62 397 354 308 308
query63 293 263 265 263
query64 4839 1265 970 970
query65 3790 3751 3745 3745
query66 1455 400 322 322
query67 15490 15559 15399 15399
query68 2413 1087 755 755
query69 455 351 322 322
query70 1023 960 829 829
query71 318 315 283 283
query72 5252 3230 3472 3230
query73 599 717 313 313
query74 8760 8738 8645 8645
query75 2754 2829 2493 2493
query76 2266 1069 670 670
query77 372 388 316 316
query78 9800 9731 9154 9154
query79 1067 892 584 584
query80 1350 576 474 474
query81 545 263 240 240
query82 996 141 109 109
query83 358 256 234 234
query84 249 118 97 97
query85 894 482 411 411
query86 406 303 282 282
query87 2859 2815 2794 2794
query88 3490 2601 2566 2566
query89 383 358 315 315
query90 1959 165 163 163
query91 167 154 129 129
query92 82 68 70 68
query93 1033 920 537 537
query94 645 308 292 292
query95 593 396 328 328
query96 652 492 230 230
query97 2334 2393 2324 2324
query98 219 201 199 199
query99 613 561 510 510
Total cold run time: 246181 ms
Total hot run time: 173991 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3764199130
<details>
<summary>TPC-DS: <b>Total hot run time: 173933 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 10863fa72fbef54a86c98b31a1ef360c86245121, data reload: false
query5 4426 618 489 489
query6 345 232 213 213
query7 4223 476 265 265
query8 344 249 237 237
query9 8746 2911 2895 2895
query10 523 369 344 344
query11 15279 15120 15078 15078
query12 170 118 122 118
query13 1261 471 378 378
query14 6357 3073 2828 2828
query14_1 2680 2672 2638 2638
query15 199 192 172 172
query16 983 499 462 462
query17 1119 656 557 557
query18 2525 442 341 341
query19 221 248 187 187
query20 118 112 110 110
query21 219 133 113 113
query22 3933 4132 3968 3968
query23 16018 15837 15263 15263
query23_1 15424 15420 15437 15420
query24 7104 1535 1187 1187
query24_1 1183 1159 1157 1157
query25 512 417 378 378
query26 1245 270 150 150
query27 2765 450 275 275
query28 4527 2176 2146 2146
query29 766 511 410 410
query30 297 244 205 205
query31 797 636 541 541
query32 84 69 76 69
query33 516 340 308 308
query34 898 883 525 525
query35 702 739 667 667
query36 902 913 840 840
query37 131 94 81 81
query38 2780 2760 2682 2682
query39 762 742 737 737
query39_1 706 705 706 705
query40 215 133 124 124
query41 63 62 63 62
query42 102 103 99 99
query43 443 462 413 413
query44 1326 742 745 742
query45 184 189 175 175
query46 846 948 573 573
query47 1416 1437 1399 1399
query48 312 323 235 235
query49 605 444 333 333
query50 611 274 200 200
query51 3831 3757 3780 3757
query52 101 106 94 94
query53 291 336 273 273
query54 280 260 270 260
query55 80 80 76 76
query56 296 302 301 301
query57 983 1022 926 926
query58 260 254 257 254
query59 2020 2173 2132 2132
query60 321 319 307 307
query61 167 141 144 141
query62 383 350 294 294
query63 308 261 263 261
query64 4955 1248 937 937
query65 3718 3746 3728 3728
query66 1426 432 324 324
query67 15538 15575 15533 15533
query68 2417 1100 775 775
query69 444 350 323 323
query70 993 941 867 867
query71 328 309 294 294
query72 5207 3189 3177 3177
query73 600 727 306 306
query74 8873 8659 8581 8581
query75 2725 2799 2458 2458
query76 2265 1058 708 708
query77 351 382 306 306
query78 9617 9734 9145 9145
query79 1064 893 566 566
query80 781 580 490 490
query81 483 261 228 228
query82 1268 149 111 111
query83 359 250 245 245
query84 248 119 90 90
query85 860 473 435 435
query86 386 300 286 286
query87 2904 2865 2790 2790
query88 3470 2577 2557 2557
query89 378 364 323 323
query90 1833 175 156 156
query91 166 159 141 141
query92 76 74 70 70
query93 954 906 536 536
query94 472 341 276 276
query95 578 348 309 309
query96 652 507 227 227
query97 2360 2383 2292 2292
query98 211 210 201 201
query99 602 581 504 504
Total cold run time: 245819 ms
Total hot run time: 173933 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3764202990
<details>
<summary>ClickBench: <b>Total hot run time: 27.86 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 10863fa72fbef54a86c98b31a1ef360c86245121, data reload: false
query1 0.05 0.05 0.05
query2 0.13 0.07 0.07
query3 0.32 0.08 0.08
query4 1.60 0.09 0.10
query5 0.27 0.24 0.25
query6 1.14 0.66 0.67
query7 0.04 0.03 0.02
query8 0.07 0.06 0.06
query9 0.58 0.53 0.51
query10 0.55 0.55 0.55
query11 0.26 0.12 0.13
query12 0.26 0.15 0.14
query13 0.63 0.62 0.61
query14 0.99 0.99 0.97
query15 0.89 0.83 0.82
query16 0.39 0.38 0.40
query17 1.03 1.06 1.05
query18 0.24 0.22 0.22
query19 1.98 1.87 1.89
query20 0.02 0.01 0.02
query21 15.40 0.29 0.24
query22 4.99 0.09 0.10
query23 15.41 0.40 0.22
query24 2.54 0.53 0.32
query25 0.11 0.09 0.09
query26 0.18 0.17 0.17
query27 0.09 0.10 0.09
query28 3.62 1.14 0.97
query29 12.53 4.05 3.22
query30 0.32 0.13 0.10
query31 2.89 0.67 0.44
query32 3.23 0.61 0.51
query33 2.99 3.13 3.02
query34 16.11 5.11 4.45
query35 4.47 4.46 4.42
query36 0.62 0.49 0.49
query37 0.24 0.08 0.09
query38 0.20 0.05 0.05
query39 0.07 0.05 0.04
query40 0.19 0.18 0.17
query41 0.14 0.06 0.06
query42 0.08 0.05 0.05
query43 0.06 0.05 0.05
Total cold run time: 97.92 s
Total hot run time: 27.86 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3767950097
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_ac0efd13d860451af1fb3ab08b8bdbc89c2eba42/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_ac0efd13d860451af1fb3ab08b8bdbc89c2eba42/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3769029685
<details>
<summary>TPC-DS: <b>Total hot run time: 174008 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2909b7d7d28d5f89f72d5d903be845edf30aae95, data reload: false
query5 4376 627 482 482
query6 319 236 231 231
query7 4254 462 264 264
query8 340 256 261 256
query9 8717 2908 2867 2867
query10 528 406 342 342
query11 15213 15270 14932 14932
query12 175 117 115 115
query13 1261 485 388 388
query14 6043 3007 2790 2790
query14_1 2698 2710 2664 2664
query15 197 194 170 170
query16 976 485 464 464
query17 1096 660 562 562
query18 2472 436 336 336
query19 222 219 193 193
query20 124 119 115 115
query21 217 138 114 114
query22 3794 3913 3941 3913
query23 15937 15604 15233 15233
query23_1 15441 15510 15507 15507
query24 7171 1522 1203 1203
query24_1 1153 1156 1147 1147
query25 538 451 400 400
query26 1239 263 154 154
query27 2765 444 291 291
query28 4571 2206 2195 2195
query29 774 531 435 435
query30 311 241 207 207
query31 795 633 562 562
query32 88 77 80 77
query33 532 356 321 321
query34 912 868 520 520
query35 731 773 678 678
query36 888 890 845 845
query37 137 103 86 86
query38 2718 2669 2637 2637
query39 765 760 728 728
query39_1 728 717 707 707
query40 224 138 122 122
query41 74 69 67 67
query42 108 105 105 105
query43 472 440 416 416
query44 1322 750 757 750
query45 188 190 178 178
query46 888 941 587 587
query47 1439 1493 1353 1353
query48 318 313 243 243
query49 603 425 342 342
query50 611 257 201 201
query51 3764 3753 3732 3732
query52 101 103 93 93
query53 279 320 277 277
query54 292 265 261 261
query55 84 80 75 75
query56 305 296 308 296
query57 1054 992 922 922
query58 271 250 275 250
query59 2162 2167 1962 1962
query60 357 317 318 317
query61 153 153 150 150
query62 395 353 307 307
query63 295 267 264 264
query64 4940 1282 967 967
query65 3818 3748 3756 3748
query66 1442 407 301 301
query67 15627 15575 15471 15471
query68 2734 1096 766 766
query69 468 349 371 349
query70 1021 963 957 957
query71 327 301 280 280
query72 5404 3206 3253 3206
query73 608 720 312 312
query74 8700 8690 8570 8570
query75 2741 2797 2476 2476
query76 2372 1074 666 666
query77 367 375 342 342
query78 9706 9901 9099 9099
query79 1198 898 576 576
query80 1295 568 484 484
query81 552 263 231 231
query82 995 143 113 113
query83 334 258 238 238
query84 248 109 98 98
query85 895 489 421 421
query86 402 285 323 285
query87 2850 2867 2784 2784
query88 3486 2588 2532 2532
query89 391 333 330 330
query90 1932 169 168 168
query91 169 155 127 127
query92 76 77 69 69
query93 1059 936 538 538
query94 629 331 317 317
query95 581 333 400 333
query96 654 497 231 231
query97 2351 2355 2287 2287
query98 203 203 198 198
query99 622 581 507 507
Total cold run time: 247041 ms
Total hot run time: 174008 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4035894914
<details>
<summary>TPC-DS: <b>Total hot run time: 153398 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 73f720ac919fc9b5631dfe4335c31b2c13e7e90f, data reload: false
query5 4317 629 512 512
query6 314 226 214 214
query7 4216 469 260 260
query8 321 245 247 245
query9 8694 2742 2716 2716
query10 482 373 365 365
query11 7418 5932 5547 5547
query12 183 125 128 125
query13 1271 439 359 359
query14 5656 3825 3577 3577
query14_1 2837 2812 2814 2812
query15 209 193 179 179
query16 988 498 463 463
query17 1110 711 623 623
query18 2445 454 355 355
query19 213 208 185 185
query20 135 130 135 130
query21 226 144 125 125
query22 4775 4946 4722 4722
query23 16592 16102 15825 15825
query23_1 15779 16059 15968 15968
query24 7269 1659 1265 1265
query24_1 1292 1383 1281 1281
query25 560 501 431 431
query26 1284 268 154 154
query27 2820 476 286 286
query28 4450 1852 1849 1849
query29 823 571 467 467
query30 316 242 210 210
query31 1386 1271 1217 1217
query32 81 72 73 72
query33 505 327 291 291
query34 948 908 564 564
query35 640 671 643 643
query36 1082 1127 1009 1009
query37 130 95 85 85
query38 2947 2994 2892 2892
query39 983 875 847 847
query39_1 808 841 824 824
query40 227 151 137 137
query41 62 59 58 58
query42 297 295 301 295
query43 239 255 218 218
query44
query45 199 189 181 181
query46 883 981 606 606
query47 2125 2137 2056 2056
query48 317 319 227 227
query49 632 463 376 376
query50 684 280 210 210
query51 4133 4112 4141 4112
query52 288 294 274 274
query53 292 340 280 280
query54 298 271 295 271
query55 94 83 88 83
query56 320 312 296 296
query57 1371 1342 1281 1281
query58 330 275 267 267
query59 1375 1432 1309 1309
query60 349 327 321 321
query61 148 141 142 141
query62 614 585 541 541
query63 310 274 273 273
query64 4939 1278 986 986
query65
query66 1444 466 357 357
query67 16330 16558 16335 16335
query68
query69 390 305 284 284
query70 1011 932 968 932
query71 347 312 291 291
query72 2813 2656 2624 2624
query73 528 567 315 315
query74 10065 9979 9723 9723
query75 2855 2773 2441 2441
query76 2152 1040 670 670
query77 368 391 312 312
query78 11102 11391 10677 10677
query79 1179 812 604 604
query80 1371 645 524 524
query81 571 287 252 252
query82 964 152 113 113
query83 331 265 246 246
query84 248 132 99 99
query85 898 487 444 444
query86 434 302 277 277
query87 3189 3155 3092 3092
query88 3516 2629 2642 2629
query89 423 362 344 344
query90 2047 178 171 171
query91 168 166 134 134
query92 84 75 67 67
query93 1003 825 497 497
query94 655 313 283 283
query95 580 334 380 334
query96 641 519 225 225
query97 2492 2485 2436 2436
query98 228 219 219 219
query99 1008 985 913 913
Total cold run time: 232974 ms
Total hot run time: 153398 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3765105680
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5160ec02c32713ab2ccf221630a14a5dff0ff463_5160ec02c32713ab2ccf221630a14a5dff0ff463_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5160ec02c32713ab2ccf221630a14a5dff0ff463_5160ec02c32713ab2ccf221630a14a5dff0ff463_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.73% (31791/49114) |
| Region Coverage | 65.42% (15832/24201) |
| Branch Coverage | 55.98% (8413/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3764181714
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/84)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_10863fa72fbef54a86c98b31a1ef360c86245121/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_10863fa72fbef54a86c98b31a1ef360c86245121/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3775870966
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3768094502
<details>
<summary>ClickBench: <b>Total hot run time: 27.65 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ac0efd13d860451af1fb3ab08b8bdbc89c2eba42, data reload: false
query1 0.05 0.05 0.04
query2 0.13 0.06 0.07
query3 0.31 0.07 0.07
query4 1.60 0.10 0.10
query5 0.27 0.24 0.25
query6 1.14 0.64 0.64
query7 0.03 0.03 0.03
query8 0.06 0.05 0.05
query9 0.57 0.50 0.49
query10 0.55 0.55 0.56
query11 0.25 0.13 0.14
query12 0.26 0.14 0.14
query13 0.63 0.61 0.60
query14 0.99 0.98 0.98
query15 0.90 0.80 0.81
query16 0.39 0.38 0.38
query17 1.03 1.07 1.06
query18 0.25 0.22 0.22
query19 1.92 1.87 1.78
query20 0.02 0.02 0.01
query21 15.40 0.28 0.25
query22 4.97 0.10 0.10
query23 15.40 0.40 0.22
query24 2.44 0.48 0.31
query25 0.10 0.09 0.10
query26 0.18 0.17 0.16
query27 0.10 0.08 0.09
query28 3.55 1.13 0.97
query29 12.50 4.03 3.24
query30 0.35 0.13 0.11
query31 2.82 0.65 0.43
query32 3.24 0.61 0.50
query33 2.95 3.05 3.04
query34 16.51 5.07 4.41
query35 4.47 4.37 4.44
query36 0.62 0.50 0.48
query37 0.24 0.09 0.09
query38 0.20 0.06 0.06
query39 0.07 0.05 0.06
query40 0.20 0.19 0.15
query41 0.13 0.06 0.07
query42 0.08 0.05 0.05
query43 0.06 0.06 0.06
Total cold run time: 97.93 s
Total hot run time: 27.65 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3899042254
# BE UT Coverage Report
Increment line coverage `11.13% (67/602)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/815d165f2d72ca3f76895e85341115b4aaf10370_815d165f2d72ca3f76895e85341115b4aaf10370/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/815d165f2d72ca3f76895e85341115b4aaf10370_815d165f2d72ca3f76895e85341115b4aaf10370/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.70% (19522/37047) |
| Line Coverage | 36.21% (181997/502587) |
| Region Coverage | 32.55% (141108/433512) |
| Branch Coverage | 33.59% (61189/182144) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3896848241
# BE UT Coverage Report
Increment line coverage `11.13% (67/602)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/abc1a71a8e92f0722c9f5566d24a651a5f57b8f9_abc1a71a8e92f0722c9f5566d24a651a5f57b8f9/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/abc1a71a8e92f0722c9f5566d24a651a5f57b8f9_abc1a71a8e92f0722c9f5566d24a651a5f57b8f9/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.71% (19502/36997) |
| Line Coverage | 36.22% (181732/501805) |
| Region Coverage | 32.58% (141084/433050) |
| Branch Coverage | 33.59% (61090/181873) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4017388322
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4022453978
<details>
<summary>TPC-DS: <b>Total hot run time: 153639 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6960a01f85d1459d53a9dc11ea9f6202f5f81064, data reload: false
query5 4324 654 527 527
query6 322 225 208 208
query7 4223 481 262 262
query8 383 269 234 234
query9 8751 2790 2756 2756
query10 483 413 355 355
query11 7375 5883 5643 5643
query12 180 126 129 126
query13 1269 471 356 356
query14 5760 3854 3613 3613
query14_1 2884 2837 2835 2835
query15 200 194 179 179
query16 1017 478 471 471
query17 1113 729 621 621
query18 2448 463 347 347
query19 219 216 187 187
query20 133 132 130 130
query21 234 143 123 123
query22 4877 5117 4775 4775
query23 16741 16205 15748 15748
query23_1 16033 15729 15812 15729
query24 7779 1749 1272 1272
query24_1 1244 1231 1267 1231
query25 571 509 479 479
query26 1233 261 145 145
query27 2798 470 282 282
query28 4527 1884 1857 1857
query29 865 586 471 471
query30 312 251 214 214
query31 1352 1295 1254 1254
query32 82 71 74 71
query33 516 322 286 286
query34 953 925 557 557
query35 640 696 598 598
query36 1110 1149 978 978
query37 128 97 82 82
query38 2993 2925 2863 2863
query39 894 915 841 841
query39_1 842 826 818 818
query40 231 153 141 141
query41 63 61 58 58
query42 309 300 303 300
query43 248 248 219 219
query44
query45 196 230 192 192
query46 895 1007 628 628
query47 2136 2112 2067 2067
query48 315 314 232 232
query49 629 449 389 389
query50 696 272 207 207
query51 4257 4103 4050 4050
query52 290 295 291 291
query53 297 344 293 293
query54 301 275 268 268
query55 87 91 90 90
query56 323 321 316 316
query57 1362 1341 1318 1318
query58 297 286 303 286
query59 1316 1466 1374 1374
query60 335 355 326 326
query61 148 148 149 148
query62 617 594 542 542
query63 315 285 277 277
query64 5111 1281 995 995
query65
query66 1473 461 352 352
query67 16717 16528 16363 16363
query68
query69 397 320 293 293
query70 958 953 968 953
query71 357 313 301 301
query72 2803 2682 2485 2485
query73 538 547 319 319
query74 10003 10016 9858 9858
query75 2908 2779 2445 2445
query76 2269 1025 692 692
query77 364 372 333 333
query78 11254 11406 10698 10698
query79 1152 816 597 597
query80 1332 624 540 540
query81 554 282 248 248
query82 1280 152 117 117
query83 368 284 267 267
query84 248 119 101 101
query85 931 485 441 441
query86 434 298 309 298
query87 3177 3098 2981 2981
query88 3555 2681 2665 2665
query89 429 376 345 345
query90 1951 180 177 177
query91 170 160 140 140
query92 77 75 69 69
query93 908 826 503 503
query94 643 328 287 287
query95 591 336 393 336
query96 641 526 230 230
query97 2487 2529 2420 2420
query98 228 216 220 216
query99 1006 963 910 910
Total cold run time: 235907 ms
Total hot run time: 153639 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4036403175
<details>
<summary>TPC-H: <b>Total hot run time: 27694 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 73f720ac919fc9b5631dfe4335c31b2c13e7e90f, data reload: false
------ Round 1 ----------------------------------
============================================
q1 16775 4438 4289 4289
q2 q3 10304 754 514 514
q4 4653 350 251 251
q5 7640 1191 1044 1044
q6 173 184 147 147
q7 788 830 658 658
q8 9416 1466 1300 1300
q9 4774 4760 4705 4705
q10 6240 1878 1634 1634
q11 450 257 246 246
q12 712 584 471 471
q13 18033 2947 2221 2221
q14 227 232 216 216
q15 901 794 797 794
q16 729 729 674 674
q17 698 845 418 418
q18 5866 5291 5292 5291
q19 1111 999 644 644
q20 502 514 387 387
q21 4373 1822 1481 1481
q22 453 314 309 309
Total cold run time: 94818 ms
Total hot run time: 27694 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4789 4538 4567 4538
q2 q3 3897 4308 3830 3830
q4 914 1187 756 756
q5 4044 4359 4316 4316
q6 178 177 144 144
q7 1730 1627 1543 1543
q8 2488 2732 2617 2617
q9 7542 7351 7360 7351
q10 3773 4000 3612 3612
q11 515 496 427 427
q12 501 590 439 439
q13 2648 3078 2408 2408
q14 299 307 280 280
q15 821 797 798 797
q16 709 767 760 760
q17 1234 1548 1369 1369
q18 7247 6752 6679 6679
q19 884 844 881 844
q20 2068 2119 2134 2119
q21 3875 3499 3388 3388
q22 467 420 396 396
Total cold run time: 50623 ms
Total hot run time: 48613 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4035711367
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3990893123
<details>
<summary>TPC-H: <b>Total hot run time: 29253 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d5b0951cd1524edab2e1e42b97836f2b9c5d39bd, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17621 4520 4340 4340
q2 q3 10718 814 528 528
q4 4740 358 256 256
q5 8040 1238 1008 1008
q6 225 172 144 144
q7 819 873 657 657
q8 10800 1488 1324 1324
q9 6683 4759 4787 4759
q10 6901 1880 1650 1650
q11 479 283 266 266
q12 750 572 462 462
q13 17765 4242 3407 3407
q14 239 229 216 216
q15 953 809 788 788
q16 752 730 672 672
q17 716 925 397 397
q18 6192 5504 5276 5276
q19 1143 1012 875 875
q20 576 574 474 474
q21 4500 1914 1484 1484
q22 350 294 270 270
Total cold run time: 100962 ms
Total hot run time: 29253 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4712 4573 4632 4573
q2 q3 1815 2200 1760 1760
q4 858 1213 782 782
q5 4082 4354 4591 4354
q6 188 184 143 143
q7 1744 1644 1615 1615
q8 2489 2769 2593 2593
q9 7453 7439 7504 7439
q10 2677 2856 2424 2424
q11 516 455 429 429
q12 513 612 444 444
q13 3933 4383 3632 3632
q14 293 305 270 270
q15 829 799 795 795
q16 733 739 709 709
q17 1175 1532 1311 1311
q18 7114 6710 6725 6710
q19 897 864 873 864
q20 2050 2166 2009 2009
q21 4036 3554 3374 3374
q22 497 460 397 397
Total cold run time: 48604 ms
Total hot run time: 46627 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3990347452
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.34% (1797/2265) |
| Line Coverage | 64.73% (32171/49698) |
| Region Coverage | 65.61% (16107/24550) |
| Branch Coverage | 56.09% (8578/15294) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4035864398
<details>
<summary>TPC-H: <b>Total hot run time: 27897 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 73f720ac919fc9b5631dfe4335c31b2c13e7e90f, data reload: false
------ Round 1 ----------------------------------
============================================
q1 16978 4468 4269 4269
q2 q3 10317 783 506 506
q4 4710 359 258 258
q5 7605 1203 1044 1044
q6 176 172 146 146
q7 782 824 670 670
q8 9386 1433 1345 1345
q9 4854 4725 4712 4712
q10 6247 1902 1673 1673
q11 480 278 234 234
q12 752 570 468 468
q13 18050 2919 2170 2170
q14 237 222 224 222
q15 931 801 817 801
q16 750 737 676 676
q17 711 847 422 422
q18 6050 5343 5261 5261
q19 1286 975 604 604
q20 495 507 425 425
q21 4431 1818 1702 1702
q22 359 349 289 289
Total cold run time: 95587 ms
Total hot run time: 27897 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4711 4703 4594 4594
q2 q3 3890 4378 3848 3848
q4 856 1191 761 761
q5 4032 4403 4332 4332
q6 171 189 139 139
q7 1751 1684 1528 1528
q8 2454 2716 2572 2572
q9 7597 7272 7401 7272
q10 3830 3936 3593 3593
q11 540 464 425 425
q12 506 600 488 488
q13 2787 3125 2476 2476
q14 308 300 273 273
q15 882 826 805 805
q16 697 748 712 712
q17 1173 1450 1415 1415
q18 7380 6819 6772 6772
q19 893 880 895 880
q20 2104 2208 2030 2030
q21 3942 3451 3345 3345
q22 459 427 384 384
Total cold run time: 50963 ms
Total hot run time: 48644 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #59984:
URL: https://github.com/apache/doris/pull/59984#discussion_r2753293521
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -807,6 +870,7 @@ private List<IcebergDeleteFileFilter> getDeleteFileFilters(FileScanTask spitTask
if (delete.content() == FileContent.POSITION_DELETES) {
filters.add(IcebergDeleteFileFilter.createPositionDelete(delete));
} else if (delete.content() == FileContent.EQUALITY_DELETES) {
+ // spitTask.schema().findField()
Review Comment:
Remove this commented-out code. It appears to be a leftover from debugging or development and should be cleaned up before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3898628822
<details>
<summary>TPC-H: <b>Total hot run time: 29313 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 815d165f2d72ca3f76895e85341115b4aaf10370, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17678 4525 4329 4329
q2 q3 10720 781 522 522
q4 4720 382 255 255
q5 8145 1227 1021 1021
q6 237 173 146 146
q7 813 856 668 668
q8 10832 1523 1355 1355
q9 6806 4764 4763 4763
q10 6864 1877 1640 1640
q11 477 275 231 231
q12 768 564 469 469
q13 17814 4237 3441 3441
q14 238 234 224 224
q15 954 800 789 789
q16 757 715 680 680
q17 705 869 420 420
q18 6514 5311 5353 5311
q19 1159 1036 859 859
q20 608 558 423 423
q21 4597 2054 1486 1486
q22 352 307 281 281
Total cold run time: 101758 ms
Total hot run time: 29313 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4695 4560 4740 4560
q2 q3 1850 2238 1728 1728
q4 875 1221 757 757
q5 4149 4518 4363 4363
q6 184 184 144 144
q7 1774 1623 1521 1521
q8 2513 2729 2574 2574
q9 7490 7418 7349 7349
q10 2681 2952 2656 2656
q11 553 440 423 423
q12 544 609 440 440
q13 3952 4377 3564 3564
q14 285 305 270 270
q15 853 785 793 785
q16 703 790 749 749
q17 1258 1809 1319 1319
q18 7215 6906 6679 6679
q19 868 853 880 853
q20 2093 2166 2059 2059
q21 4021 3561 3427 3427
q22 474 476 416 416
Total cold run time: 49030 ms
Total hot run time: 46636 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3898312406
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_815d165f2d72ca3f76895e85341115b4aaf10370/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_815d165f2d72ca3f76895e85341115b4aaf10370/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3769106533
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2909b7d7d28d5f89f72d5d903be845edf30aae95_2909b7d7d28d5f89f72d5d903be845edf30aae95_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2909b7d7d28d5f89f72d5d903be845edf30aae95_2909b7d7d28d5f89f72d5d903be845edf30aae95_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.77% (31809/49114) |
| Region Coverage | 65.49% (15849/24201) |
| Branch Coverage | 56.06% (8425/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3980358713
## Improvement Suggestions
### High Priority
1. **Raw pointer safety for `_equality_delete_blocks`**
[EqualityDeleteBase](cci:1://file:///Users/morningman/workspace/git/doris/be/src/vec/exec/format/table/equality_delete.h:44:4-45:77) holds a raw `Block*` pointer with an implicit constraint that the `_equality_delete_blocks` vector must not be modified (and thus reallocated) after the [EqualityDeleteBase](cci:1://file:///Users/morningman/workspace/git/doris/be/src/vec/exec/format/table/equality_delete.h:44:4-45:77) instances are created. While the current code is safe, this implicit dependency is fragile for future maintainers.
**Suggestion**: Add a comment documenting this constraint, or consider using `std::unique_ptr<Block>` with reference passing to make lifetime management explicit.
2. **Code duplication between Parquet and ORC paths**
`IcebergParquetReader::_process_equality_delete()` and `IcebergOrcReader::_process_equality_delete()` share approximately 70% similar logic, including:
- Building `data_file_id_to_field` mappings
- Iterating over delete files, validating field IDs, constructing `eq_file_node`
- Merging blocks and creating `equality_delete_impl`
**Suggestion**: Extract common logic into the base class [IcebergTableReader](cci:1://file:///Users/morningman/workspace/git/doris/be/src/vec/exec/format/table/iceberg_reader.h:72:4-75:50), keeping only format-specific differences in the subclasses.
3. **Similar duplication in `init_reader()` methods**
Both `IcebergParquetReader::init_reader()` and `IcebergOrcReader::init_reader()` contain highly duplicated branching logic for `exist_field_id` / `!exist_field_id`. Consider applying the Template Method pattern to reduce redundancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #59984:
URL: https://github.com/apache/doris/pull/59984#discussion_r2869293860
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalUtil.java:
##########
@@ -80,4 +90,124 @@ public static void initSchemaInfo(TFileScanRangeParams params, Long schemaId, Li
tSchema.setRootField(getExternalSchema(columns));
params.addToHistorySchemaInfo(tSchema);
}
+
+
+ /**
+ * Initialize schema info based on SlotDescriptors, only including columns that are actually needed.
+ * For nested columns, only include sub-columns that are accessed according to pruned type.
+ *
+ * @param params TFileScanRangeParams to fill
+ * @param schemaId Schema ID
+ * @param slots List of SlotDescriptors that are actually needed
+ * @param nameMapping NameMapping from Iceberg table properties (can be null and empty.)
+ */
+ public static void initSchemaInfoForPrunedColumn(TFileScanRangeParams params, Long schemaId,
Review Comment:
Add Unit test for `initSchemaInfoForPrunedColumn` and `getExternalSchemaForPrunedColumn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3771186188
<details>
<summary>TPC-DS: <b>Total hot run time: 173994 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5c7bfd69abc6283248d1db91e6520d17ba11f51f, data reload: false
query5 4412 623 509 509
query6 325 222 202 202
query7 4221 451 259 259
query8 333 254 239 239
query9 8673 2862 2857 2857
query10 517 372 348 348
query11 15242 15110 14986 14986
query12 167 112 109 109
query13 1236 468 410 410
query14 6121 3068 2756 2756
query14_1 2660 2631 2700 2631
query15 204 198 174 174
query16 975 481 472 472
query17 1091 665 551 551
query18 2488 448 331 331
query19 224 221 190 190
query20 125 120 114 114
query21 224 137 118 118
query22 4103 4082 4059 4059
query23 16071 15613 15458 15458
query23_1 15601 15543 15626 15543
query24 7153 1540 1176 1176
query24_1 1149 1186 1145 1145
query25 536 465 416 416
query26 1248 270 156 156
query27 2758 445 279 279
query28 4576 2181 2167 2167
query29 769 525 425 425
query30 319 245 208 208
query31 810 631 567 567
query32 83 73 75 73
query33 524 358 308 308
query34 917 868 537 537
query35 741 753 674 674
query36 888 907 766 766
query37 144 103 91 91
query38 2737 2739 2657 2657
query39 784 760 755 755
query39_1 729 706 696 696
query40 220 136 122 122
query41 93 68 69 68
query42 108 106 104 104
query43 476 444 411 411
query44 1333 765 746 746
query45 190 190 176 176
query46 841 936 579 579
query47 1465 1487 1349 1349
query48 325 337 242 242
query49 628 411 342 342
query50 610 264 202 202
query51 3900 3730 3697 3697
query52 105 106 104 104
query53 293 330 283 283
query54 291 273 268 268
query55 82 77 83 77
query56 304 301 298 298
query57 1040 992 935 935
query58 273 257 258 257
query59 2045 2151 1978 1978
query60 335 336 309 309
query61 154 141 143 141
query62 385 363 305 305
query63 295 269 257 257
query64 4846 1245 938 938
query65 3758 3825 3761 3761
query66 1440 426 318 318
query67 15671 15519 15394 15394
query68 2454 1101 784 784
query69 439 356 314 314
query70 992 987 894 894
query71 328 314 282 282
query72 5227 3151 3235 3151
query73 608 722 311 311
query74 8768 8819 8530 8530
query75 2720 2793 2438 2438
query76 2281 1055 650 650
query77 339 395 299 299
query78 9791 9983 9245 9245
query79 1064 885 576 576
query80 1292 550 464 464
query81 529 264 231 231
query82 1327 147 111 111
query83 359 251 238 238
query84 252 106 95 95
query85 932 475 409 409
query86 382 305 293 293
query87 2833 2949 2762 2762
query88 3498 2585 2549 2549
query89 382 345 344 344
query90 1915 173 155 155
query91 168 154 130 130
query92 75 79 69 69
query93 924 909 545 545
query94 623 318 298 298
query95 585 331 315 315
query96 674 497 234 234
query97 2353 2366 2328 2328
query98 216 202 197 197
query99 597 575 510 510
Total cold run time: 247294 ms
Total hot run time: 173994 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3772019094
<details>
<summary>ClickBench: <b>Total hot run time: 27.64 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 20c7e03b9d38156a4023b0e63788a8a9ba218bb1, data reload: false
query1 0.05 0.05 0.04
query2 0.14 0.07 0.07
query3 0.33 0.08 0.08
query4 1.60 0.10 0.10
query5 0.26 0.25 0.25
query6 1.14 0.64 0.65
query7 0.04 0.02 0.03
query8 0.06 0.05 0.06
query9 0.59 0.51 0.48
query10 0.56 0.55 0.56
query11 0.26 0.13 0.12
query12 0.26 0.14 0.14
query13 0.62 0.62 0.61
query14 0.98 0.97 0.98
query15 0.90 0.82 0.82
query16 0.40 0.39 0.45
query17 1.06 1.05 1.03
query18 0.24 0.21 0.22
query19 1.82 1.87 1.81
query20 0.03 0.01 0.02
query21 15.39 0.28 0.23
query22 4.96 0.09 0.10
query23 15.40 0.39 0.23
query24 2.40 0.52 0.34
query25 0.10 0.09 0.10
query26 0.19 0.17 0.17
query27 0.10 0.10 0.09
query28 3.75 1.12 0.96
query29 12.53 3.94 3.25
query30 0.32 0.12 0.10
query31 2.80 0.69 0.44
query32 3.24 0.61 0.50
query33 3.03 2.96 3.05
query34 15.81 5.12 4.39
query35 4.50 4.41 4.56
query36 0.62 0.50 0.49
query37 0.26 0.10 0.09
query38 0.20 0.05 0.06
query39 0.07 0.06 0.05
query40 0.21 0.18 0.16
query41 0.13 0.07 0.06
query42 0.08 0.06 0.05
query43 0.06 0.05 0.05
Total cold run time: 97.49 s
Total hot run time: 27.64 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3770967376
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/5c7bfd69abc6283248d1db91e6520d17ba11f51f_5c7bfd69abc6283248d1db91e6520d17ba11f51f_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/5c7bfd69abc6283248d1db91e6520d17ba11f51f_5c7bfd69abc6283248d1db91e6520d17ba11f51f_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.76% (31807/49114) |
| Region Coverage | 65.48% (15847/24201) |
| Branch Coverage | 56.02% (8419/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3771160523
<details>
<summary>TPC-H: <b>Total hot run time: 31778 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5c7bfd69abc6283248d1db91e6520d17ba11f51f, data reload: false
------ Round 1 ----------------------------------
q1 17615 4260 4032 4032
q2 1984 344 261 261
q3 10174 1292 722 722
q4 10256 811 305 305
q5 8540 2099 1836 1836
q6 228 167 134 134
q7 908 799 663 663
q8 9271 1431 1068 1068
q9 5108 4580 4681 4580
q10 6828 1823 1415 1415
q11 522 296 293 293
q12 740 746 583 583
q13 17800 3823 3085 3085
q14 300 294 291 291
q15 577 511 514 511
q16 673 678 628 628
q17 681 814 510 510
q18 6905 6515 6958 6515
q19 1248 1109 670 670
q20 444 387 260 260
q21 3332 2683 2349 2349
q22 1152 1107 1067 1067
Total cold run time: 105286 ms
Total hot run time: 31778 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4373 4277 4242 4242
q2 348 422 346 346
q3 2401 2769 2472 2472
q4 1458 1918 1571 1571
q5 4459 4243 4336 4243
q6 213 167 124 124
q7 1972 1923 1774 1774
q8 2623 2367 2367 2367
q9 7089 7085 7141 7085
q10 2736 2696 2309 2309
q11 553 454 440 440
q12 656 701 567 567
q13 3353 3813 3093 3093
q14 278 292 264 264
q15 526 494 482 482
q16 625 653 619 619
q17 1117 1289 1297 1289
q18 7417 7219 7208 7208
q19 832 819 825 819
q20 1913 1972 1784 1784
q21 4502 4273 4057 4057
q22 1042 1010 998 998
Total cold run time: 50486 ms
Total hot run time: 48153 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3774159979
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_71fff849d4c70963d0a9cedb12b837ef19f49516_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_71fff849d4c70963d0a9cedb12b837ef19f49516_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3776556304
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_774c62d2828db275c3e383b7be1611bfa1ab3ec1_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_774c62d2828db275c3e383b7be1611bfa1ab3ec1_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3771997352
<details>
<summary>TPC-DS: <b>Total hot run time: 173107 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 20c7e03b9d38156a4023b0e63788a8a9ba218bb1, data reload: false
query5 4468 639 514 514
query6 343 232 207 207
query7 4219 469 252 252
query8 343 253 243 243
query9 8678 2903 2924 2903
query10 547 409 314 314
query11 15281 15207 14921 14921
query12 167 111 111 111
query13 1245 483 357 357
query14 6410 3049 2779 2779
query14_1 2663 2638 2646 2638
query15 208 190 169 169
query16 973 484 461 461
query17 1064 645 546 546
query18 2529 420 323 323
query19 215 216 188 188
query20 121 115 113 113
query21 218 143 114 114
query22 3950 4068 3816 3816
query23 16144 15522 15354 15354
query23_1 15389 15404 15403 15403
query24 6984 1519 1147 1147
query24_1 1151 1158 1185 1158
query25 511 431 376 376
query26 1241 261 149 149
query27 2777 438 275 275
query28 4490 2183 2167 2167
query29 740 518 412 412
query30 306 244 203 203
query31 815 624 571 571
query32 80 80 74 74
query33 531 346 305 305
query34 905 878 524 524
query35 757 778 707 707
query36 864 902 841 841
query37 141 100 86 86
query38 2719 2664 2624 2624
query39 785 761 722 722
query39_1 709 741 683 683
query40 211 131 115 115
query41 63 59 63 59
query42 103 108 102 102
query43 436 477 412 412
query44 1341 746 745 745
query45 182 189 170 170
query46 837 945 584 584
query47 1433 1357 1381 1357
query48 310 327 239 239
query49 601 418 345 345
query50 640 277 197 197
query51 3852 3804 3869 3804
query52 112 106 95 95
query53 292 322 279 279
query54 290 273 260 260
query55 82 81 79 79
query56 304 312 309 309
query57 984 1010 932 932
query58 276 251 258 251
query59 2005 2117 2156 2117
query60 322 337 309 309
query61 150 145 145 145
query62 395 351 320 320
query63 299 266 267 266
query64 4883 1321 1091 1091
query65 3839 3691 3729 3691
query66 1428 430 327 327
query67 15462 15545 15439 15439
query68 2477 1115 769 769
query69 447 371 330 330
query70 965 970 940 940
query71 328 316 292 292
query72 5390 2480 3280 2480
query73 608 739 307 307
query74 8676 8742 8471 8471
query75 2748 2780 2434 2434
query76 2190 1052 676 676
query77 370 386 307 307
query78 9602 9818 9143 9143
query79 1055 902 592 592
query80 1274 574 482 482
query81 529 260 234 234
query82 898 144 108 108
query83 317 255 242 242
query84 248 116 96 96
query85 923 487 417 417
query86 412 298 291 291
query87 2864 2848 2762 2762
query88 3539 2584 2567 2567
query89 394 326 336 326
query90 1965 179 171 171
query91 169 157 129 129
query92 78 70 71 70
query93 1055 894 540 540
query94 625 324 287 287
query95 592 351 320 320
query96 650 509 236 236
query97 2319 2460 2334 2334
query98 221 204 197 197
query99 581 564 514 514
Total cold run time: 246286 ms
Total hot run time: 173107 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3765361025
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3765390177
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.75% (31802/49114) |
| Region Coverage | 65.45% (15839/24201) |
| Branch Coverage | 56.01% (8417/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3764447152
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/84)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_10863fa72fbef54a86c98b31a1ef360c86245121_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_10863fa72fbef54a86c98b31a1ef360c86245121_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3768839021
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3768954384
<details>
<summary>TPC-H: <b>Total hot run time: 31437 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2909b7d7d28d5f89f72d5d903be845edf30aae95, data reload: false
------ Round 1 ----------------------------------
q1 17673 4237 4079 4079
q2 2047 365 247 247
q3 10149 1254 684 684
q4 10201 793 297 297
q5 7539 2040 1855 1855
q6 189 172 138 138
q7 929 760 658 658
q8 9260 1367 1155 1155
q9 4962 4648 4604 4604
q10 6735 1797 1388 1388
q11 503 310 287 287
q12 697 729 603 603
q13 17769 3804 3049 3049
q14 311 285 278 278
q15 579 497 503 497
q16 692 697 634 634
q17 676 760 534 534
q18 6701 6564 6430 6430
q19 1242 981 632 632
q20 384 361 250 250
q21 2965 2485 2157 2157
q22 1022 1017 981 981
Total cold run time: 103225 ms
Total hot run time: 31437 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4086 4053 4047 4047
q2 321 399 330 330
q3 2101 2603 2201 2201
q4 1315 1774 1352 1352
q5 4072 4004 4029 4004
q6 206 169 128 128
q7 1842 1826 1646 1646
q8 2860 2470 2400 2400
q9 7309 7254 7210 7210
q10 2833 2677 2360 2360
q11 571 465 449 449
q12 722 727 634 634
q13 3665 4060 3304 3304
q14 304 329 292 292
q15 548 496 509 496
q16 633 668 627 627
q17 1139 1370 1436 1370
q18 7617 7928 7646 7646
q19 886 889 908 889
q20 1998 2037 1902 1902
q21 4827 4536 4216 4216
q22 1189 1145 1087 1087
Total cold run time: 51044 ms
Total hot run time: 48590 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3769065286
<details>
<summary>ClickBench: <b>Total hot run time: 28.23 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2909b7d7d28d5f89f72d5d903be845edf30aae95, data reload: false
query1 0.06 0.05 0.04
query2 0.14 0.06 0.06
query3 0.33 0.08 0.07
query4 1.61 0.10 0.10
query5 0.26 0.25 0.25
query6 1.14 0.66 0.65
query7 0.03 0.02 0.03
query8 0.07 0.06 0.06
query9 0.59 0.49 0.50
query10 0.55 0.56 0.56
query11 0.26 0.13 0.14
query12 0.25 0.13 0.15
query13 0.62 0.60 0.59
query14 0.97 0.97 0.98
query15 0.90 0.83 0.82
query16 0.40 0.39 0.39
query17 1.05 1.06 1.06
query18 0.24 0.22 0.23
query19 1.94 1.87 1.81
query20 0.03 0.01 0.02
query21 15.41 0.29 0.25
query22 4.94 0.10 0.09
query23 15.38 0.38 0.22
query24 2.35 0.50 0.32
query25 0.10 0.10 0.10
query26 0.18 0.17 0.18
query27 0.10 0.09 0.10
query28 3.55 1.14 0.97
query29 12.53 4.03 3.21
query30 0.33 0.13 0.11
query31 2.80 0.67 0.44
query32 3.25 0.61 0.50
query33 3.00 3.00 3.04
query34 16.55 5.07 4.44
query35 4.47 4.78 5.04
query36 0.66 0.56 0.56
query37 0.28 0.10 0.10
query38 0.22 0.06 0.06
query39 0.07 0.05 0.06
query40 0.20 0.18 0.17
query41 0.12 0.06 0.06
query42 0.09 0.05 0.05
query43 0.07 0.06 0.06
Total cold run time: 98.09 s
Total hot run time: 28.23 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on code in PR #59984:
URL: https://github.com/apache/doris/pull/59984#discussion_r2903735887
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/ExternalUtil.java:
##########
@@ -80,4 +90,124 @@ public static void initSchemaInfo(TFileScanRangeParams params, Long schemaId, Li
tSchema.setRootField(getExternalSchema(columns));
params.addToHistorySchemaInfo(tSchema);
}
+
+
+ /**
+ * Initialize schema info based on SlotDescriptors, only including columns that are actually needed.
+ * For nested columns, only include sub-columns that are accessed according to pruned type.
+ *
+ * @param params TFileScanRangeParams to fill
+ * @param schemaId Schema ID
+ * @param slots List of SlotDescriptors that are actually needed
+ * @param nameMapping NameMapping from Iceberg table properties (can be null and empty.)
+ */
+ public static void initSchemaInfoForPrunedColumn(TFileScanRangeParams params, Long schemaId,
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4021808647
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4028628712
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4037478166
# BE Regression && UT Coverage Report
Increment line coverage `71.14% (429/603)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_73f720ac919fc9b5631dfe4335c31b2c13e7e90f_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_73f720ac919fc9b5631dfe4335c31b2c13e7e90f_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.18% (26788/36605) |
| Line Coverage | 56.46% (285313/505337) |
| Region Coverage | 53.76% (237939/442598) |
| Branch Coverage | 55.48% (102769/185233) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4029132007
<details>
<summary>TPC-DS: <b>Total hot run time: 154281 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1a5798bd3baef10194f4ff9dad07c09a54e1e98c, data reload: false
query5 4322 649 544 544
query6 329 220 200 200
query7 4208 459 268 268
query8 343 255 237 237
query9 8754 2776 2783 2776
query10 515 393 360 360
query11 7265 5804 5670 5670
query12 182 133 127 127
query13 1266 456 349 349
query14 5715 3907 3615 3615
query14_1 2880 2842 2851 2842
query15 212 203 180 180
query16 980 482 474 474
query17 879 750 630 630
query18 2450 456 357 357
query19 220 217 195 195
query20 134 141 132 132
query21 228 149 125 125
query22 5034 4995 4869 4869
query23 16047 15619 15396 15396
query23_1 15459 16223 16150 16150
query24 7998 1724 1300 1300
query24_1 1269 1299 1338 1299
query25 588 504 474 474
query26 1428 276 161 161
query27 2947 520 307 307
query28 5040 1987 1993 1987
query29 878 649 527 527
query30 323 262 220 220
query31 1449 1343 1349 1343
query32 80 83 80 80
query33 523 360 295 295
query34 977 967 612 612
query35 684 707 608 608
query36 1120 1085 964 964
query37 138 101 89 89
query38 2969 2943 2853 2853
query39 996 856 851 851
query39_1 821 848 818 818
query40 230 155 139 139
query41 63 62 59 59
query42 310 304 295 295
query43 263 280 231 231
query44
query45 204 199 191 191
query46 885 986 606 606
query47 2118 2178 2041 2041
query48 315 324 227 227
query49 622 485 401 401
query50 686 283 218 218
query51 4247 4089 4082 4082
query52 294 295 282 282
query53 295 335 295 295
query54 305 273 281 273
query55 92 89 83 83
query56 315 333 311 311
query57 1354 1320 1266 1266
query58 295 289 280 280
query59 1363 1450 1255 1255
query60 351 342 326 326
query61 152 146 169 146
query62 642 590 544 544
query63 321 276 279 276
query64 5105 1303 1009 1009
query65
query66 1464 471 359 359
query67 16363 16529 16112 16112
query68
query69 388 315 310 310
query70 930 932 961 932
query71 361 317 310 310
query72 2888 2721 2569 2569
query73 548 556 349 349
query74 10040 9930 9831 9831
query75 2889 2799 2486 2486
query76 2284 1032 706 706
query77 360 386 321 321
query78 11168 11381 10635 10635
query79 1168 827 606 606
query80 1333 671 596 596
query81 555 284 256 256
query82 1003 150 121 121
query83 344 285 261 261
query84 300 129 108 108
query85 965 566 522 522
query86 439 321 273 273
query87 3202 3148 3033 3033
query88 3595 2671 2648 2648
query89 433 385 347 347
query90 2040 183 189 183
query91 171 157 139 139
query92 77 79 69 69
query93 951 843 501 501
query94 642 326 290 290
query95 578 345 382 345
query96 632 529 224 224
query97 2499 2494 2443 2443
query98 235 217 227 217
query99 996 978 906 906
Total cold run time: 235188 ms
Total hot run time: 154281 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3895522310
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3896514772
<details>
<summary>TPC-DS: <b>Total hot run time: 184548 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit abc1a71a8e92f0722c9f5566d24a651a5f57b8f9, data reload: false
query5 4355 622 503 503
query6 331 207 215 207
query7 4202 465 274 274
query8 357 244 240 240
query9 8736 2761 2742 2742
query10 509 393 342 342
query11 17281 17634 17349 17349
query12 201 130 125 125
query13 1281 500 358 358
query14 6520 3475 3068 3068
query14_1 3016 2912 2873 2873
query15 210 214 211 211
query16 1092 507 485 485
query17 2770 737 631 631
query18 2722 472 378 378
query19 227 223 190 190
query20 144 148 132 132
query21 228 163 133 133
query22 5474 4784 4936 4784
query23 17352 16864 16648 16648
query23_1 16757 16786 16828 16786
query24 7099 1635 1238 1238
query24_1 1247 1258 1215 1215
query25 576 473 423 423
query26 1256 259 161 161
query27 2760 474 286 286
query28 4448 1912 1869 1869
query29 784 564 466 466
query30 309 248 209 209
query31 873 757 641 641
query32 80 73 67 67
query33 519 327 276 276
query34 917 911 574 574
query35 623 661 579 579
query36 1089 1153 991 991
query37 135 95 83 83
query38 2940 2919 2846 2846
query39 856 971 848 848
query39_1 787 805 798 798
query40 227 149 135 135
query41 62 58 59 58
query42 102 102 103 102
query43 367 374 360 360
query44
query45 196 189 180 180
query46 883 1008 608 608
query47 2117 2126 2084 2084
query48 308 312 237 237
query49 624 465 385 385
query50 686 272 211 211
query51 4164 4106 4126 4106
query52 106 107 96 96
query53 292 330 277 277
query54 284 269 263 263
query55 89 89 83 83
query56 319 302 293 293
query57 1376 1368 1266 1266
query58 288 277 267 267
query59 2611 2735 2570 2570
query60 331 337 319 319
query61 149 144 146 144
query62 631 588 552 552
query63 313 282 270 270
query64 4905 1257 996 996
query65
query66 1422 461 342 342
query67 16407 16377 16403 16377
query68
query69 397 295 286 286
query70 998 1002 947 947
query71 330 301 292 292
query72 2804 2694 2423 2423
query73 537 541 313 313
query74 9634 9540 9419 9419
query75 2864 2748 2446 2446
query76 2278 1012 686 686
query77 349 362 306 306
query78 11702 11840 11074 11074
query79 1352 772 608 608
query80 1335 626 536 536
query81 562 289 250 250
query82 999 145 115 115
query83 334 258 246 246
query84 253 118 94 94
query85 876 468 429 429
query86 412 316 294 294
query87 3132 3091 2962 2962
query88 3567 2672 2676 2672
query89 432 371 337 337
query90 2000 178 175 175
query91 163 155 130 130
query92 76 81 72 72
query93 1019 854 510 510
query94 627 356 279 279
query95 577 330 382 330
query96 641 515 226 226
query97 2472 2494 2417 2417
query98 224 217 220 217
query99 1014 963 939 939
Total cold run time: 256638 ms
Total hot run time: 184548 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3897957076
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3773376842
<details>
<summary>ClickBench: <b>Total hot run time: 26.85 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 71fff849d4c70963d0a9cedb12b837ef19f49516, data reload: false
query1 0.05 0.04 0.04
query2 0.10 0.05 0.04
query3 0.27 0.09 0.08
query4 1.61 0.11 0.11
query5 0.26 0.25 0.27
query6 1.14 0.68 0.65
query7 0.03 0.03 0.03
query8 0.05 0.04 0.04
query9 0.57 0.50 0.51
query10 0.54 0.53 0.54
query11 0.14 0.09 0.10
query12 0.14 0.11 0.10
query13 0.61 0.58 0.58
query14 0.94 0.95 0.92
query15 0.80 0.77 0.76
query16 0.40 0.40 0.39
query17 0.99 1.05 1.03
query18 0.22 0.21 0.22
query19 1.86 1.82 1.80
query20 0.02 0.01 0.01
query21 15.44 0.29 0.14
query22 5.25 0.05 0.05
query23 15.75 0.28 0.10
query24 0.97 0.52 0.39
query25 0.07 0.07 0.10
query26 0.14 0.14 0.13
query27 0.07 0.05 0.06
query28 3.82 1.08 0.89
query29 12.53 3.91 3.14
query30 0.28 0.14 0.13
query31 2.83 0.64 0.39
query32 3.24 0.56 0.46
query33 3.07 3.05 3.07
query34 16.10 5.11 4.44
query35 4.44 4.43 4.43
query36 0.64 0.50 0.49
query37 0.11 0.07 0.06
query38 0.08 0.04 0.04
query39 0.05 0.03 0.03
query40 0.16 0.14 0.13
query41 0.09 0.03 0.03
query42 0.04 0.03 0.02
query43 0.06 0.03 0.03
Total cold run time: 95.97 s
Total hot run time: 26.85 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3776160374
<details>
<summary>TPC-H: <b>Total hot run time: 31893 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 774c62d2828db275c3e383b7be1611bfa1ab3ec1, data reload: false
------ Round 1 ----------------------------------
q1 17612 4299 4070 4070
q2 2032 358 237 237
q3 10181 1259 720 720
q4 10238 875 312 312
q5 8087 2124 1865 1865
q6 201 169 137 137
q7 954 783 646 646
q8 9275 1437 1169 1169
q9 5068 4581 4588 4581
q10 6817 1820 1363 1363
q11 519 307 274 274
q12 724 747 576 576
q13 17792 3835 3098 3098
q14 302 296 278 278
q15 581 526 515 515
q16 710 683 638 638
q17 675 837 513 513
q18 6613 6387 6906 6387
q19 1324 1059 655 655
q20 420 395 276 276
q21 3268 2573 2586 2573
q22 1149 1071 1010 1010
Total cold run time: 104542 ms
Total hot run time: 31893 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4373 4359 4444 4359
q2 321 419 326 326
q3 2282 2741 2417 2417
q4 1504 1886 1582 1582
q5 4536 4415 4323 4323
q6 210 168 133 133
q7 1967 1922 1784 1784
q8 2543 2423 2393 2393
q9 7561 7167 7383 7167
q10 2539 2683 2266 2266
q11 582 482 448 448
q12 652 721 589 589
q13 3336 3821 3127 3127
q14 258 297 256 256
q15 519 498 486 486
q16 609 668 612 612
q17 1138 1292 1296 1292
q18 7309 7284 7222 7222
q19 845 815 814 814
q20 1873 1928 1804 1804
q21 4446 4255 4014 4014
q22 1114 1045 978 978
Total cold run time: 50517 ms
Total hot run time: 48392 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3765310863
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_5160ec02c32713ab2ccf221630a14a5dff0ff463_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_5160ec02c32713ab2ccf221630a14a5dff0ff463_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3898684799
<details>
<summary>TPC-DS: <b>Total hot run time: 184196 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 815d165f2d72ca3f76895e85341115b4aaf10370, data reload: false
query5 4340 659 531 531
query6 325 215 206 206
query7 4212 486 286 286
query8 364 250 243 243
query9 8699 2749 2756 2749
query10 536 409 336 336
query11 17040 17603 17107 17107
query12 183 147 139 139
query13 1423 516 353 353
query14 7566 3484 3208 3208
query14_1 3078 2979 3001 2979
query15 221 197 184 184
query16 1054 508 564 508
query17 2053 756 631 631
query18 2608 495 361 361
query19 239 234 198 198
query20 147 136 147 136
query21 219 148 133 133
query22 5678 4909 4692 4692
query23 17258 16783 16678 16678
query23_1 16613 16595 16667 16595
query24 7231 1631 1242 1242
query24_1 1266 1263 1256 1256
query25 574 492 428 428
query26 1230 271 160 160
query27 2743 492 293 293
query28 4430 1882 1886 1882
query29 844 563 477 477
query30 312 251 211 211
query31 864 727 652 652
query32 82 72 74 72
query33 523 356 288 288
query34 940 913 566 566
query35 656 682 597 597
query36 1088 1113 1029 1029
query37 132 95 84 84
query38 2939 2939 2931 2931
query39 904 877 851 851
query39_1 845 814 839 814
query40 229 153 137 137
query41 64 62 59 59
query42 110 105 105 105
query43 376 390 358 358
query44
query45 198 189 184 184
query46 920 990 612 612
query47 2115 2115 1987 1987
query48 321 322 230 230
query49 630 471 380 380
query50 715 287 225 225
query51 4096 4078 3995 3995
query52 109 111 98 98
query53 299 357 289 289
query54 299 272 292 272
query55 89 87 85 85
query56 311 324 306 306
query57 1378 1330 1270 1270
query58 286 278 276 276
query59 2604 2710 2542 2542
query60 342 346 325 325
query61 157 146 145 145
query62 614 600 515 515
query63 323 278 282 278
query64 4901 1280 978 978
query65
query66 1467 462 367 367
query67 16368 16526 16311 16311
query68
query69 400 335 289 289
query70 998 989 965 965
query71 352 316 309 309
query72 2814 2684 2415 2415
query73 546 569 323 323
query74 9984 9873 9780 9780
query75 2875 2749 2447 2447
query76 2283 1050 734 734
query77 364 395 316 316
query78 11248 11388 10722 10722
query79 2601 815 610 610
query80 1745 629 553 553
query81 571 281 249 249
query82 979 155 115 115
query83 340 267 255 255
query84 248 123 99 99
query85 898 486 460 460
query86 414 313 294 294
query87 3148 3104 2986 2986
query88 3669 2736 2726 2726
query89 431 372 353 353
query90 1982 179 180 179
query91 165 164 135 135
query92 79 77 70 70
query93 1184 861 503 503
query94 641 341 286 286
query95 605 336 394 336
query96 646 546 233 233
query97 2476 2498 2436 2436
query98 245 216 216 216
query99 981 925 853 853
Total cold run time: 258304 ms
Total hot run time: 184196 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3762550167
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3768070447
<details>
<summary>TPC-DS: <b>Total hot run time: 173146 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ac0efd13d860451af1fb3ab08b8bdbc89c2eba42, data reload: false
query5 4304 599 478 478
query6 330 215 218 215
query7 4229 459 265 265
query8 360 250 234 234
query9 8729 2851 2897 2851
query10 514 406 342 342
query11 15170 15050 14807 14807
query12 177 111 114 111
query13 1262 489 383 383
query14 6259 3055 3016 3016
query14_1 2614 2601 2597 2597
query15 199 186 169 169
query16 978 494 447 447
query17 1082 638 523 523
query18 2454 414 309 309
query19 210 212 180 180
query20 118 111 107 107
query21 212 143 112 112
query22 4026 4075 3953 3953
query23 15923 15718 15248 15248
query23_1 15453 15443 15474 15443
query24 7138 1530 1165 1165
query24_1 1139 1187 1171 1171
query25 538 453 407 407
query26 1256 265 153 153
query27 2766 437 278 278
query28 4555 2167 2153 2153
query29 769 533 437 437
query30 310 235 208 208
query31 792 629 577 577
query32 80 75 76 75
query33 535 366 315 315
query34 892 858 527 527
query35 722 758 682 682
query36 866 883 788 788
query37 137 100 88 88
query38 2700 2713 2608 2608
query39 794 756 734 734
query39_1 705 697 715 697
query40 224 137 121 121
query41 71 67 68 67
query42 104 97 101 97
query43 444 438 397 397
query44 1335 763 756 756
query45 186 184 174 174
query46 837 943 574 574
query47 1437 1506 1412 1412
query48 319 341 242 242
query49 634 456 347 347
query50 652 269 205 205
query51 3739 3789 3681 3681
query52 104 108 95 95
query53 289 321 271 271
query54 295 274 266 266
query55 80 82 79 79
query56 308 307 303 303
query57 1049 1031 1000 1000
query58 287 265 259 259
query59 2105 2107 2007 2007
query60 341 340 322 322
query61 176 167 164 164
query62 392 374 309 309
query63 301 265 267 265
query64 4972 1231 925 925
query65 3812 3726 3731 3726
query66 1436 430 303 303
query67 15369 15517 15255 15255
query68 2420 1098 760 760
query69 459 352 319 319
query70 1017 948 827 827
query71 327 305 283 283
query72 5213 3113 3008 3008
query73 608 716 313 313
query74 8751 8775 8511 8511
query75 2764 2804 2446 2446
query76 2275 1063 648 648
query77 359 366 304 304
query78 9846 9925 9164 9164
query79 1093 901 579 579
query80 1278 557 472 472
query81 543 260 237 237
query82 969 143 114 114
query83 324 246 236 236
query84 252 111 89 89
query85 885 478 417 417
query86 406 287 283 283
query87 2836 2822 2765 2765
query88 3483 2580 2572 2572
query89 380 349 325 325
query90 2004 168 154 154
query91 168 156 128 128
query92 80 73 70 70
query93 983 924 542 542
query94 638 315 293 293
query95 571 387 310 310
query96 647 501 239 239
query97 2315 2374 2326 2326
query98 227 198 200 198
query99 598 590 587 587
Total cold run time: 246516 ms
Total hot run time: 173146 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3765185254
<details>
<summary>TPC-DS: <b>Total hot run time: 174572 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5160ec02c32713ab2ccf221630a14a5dff0ff463, data reload: false
query5 4395 626 477 477
query6 364 218 202 202
query7 4213 465 264 264
query8 333 249 238 238
query9 8715 2916 2909 2909
query10 489 380 311 311
query11 15278 15203 15080 15080
query12 184 118 116 116
query13 1240 485 375 375
query14 6215 3107 2871 2871
query14_1 2717 2746 2734 2734
query15 205 199 174 174
query16 1019 500 469 469
query17 1090 671 560 560
query18 2471 449 344 344
query19 236 227 195 195
query20 124 118 118 118
query21 215 140 122 122
query22 3961 4118 4076 4076
query23 16258 15557 15377 15377
query23_1 15438 15540 15427 15427
query24 7267 1563 1181 1181
query24_1 1167 1203 1172 1172
query25 559 429 383 383
query26 1240 272 151 151
query27 2765 442 278 278
query28 4548 2166 2166 2166
query29 756 520 407 407
query30 308 240 205 205
query31 817 619 581 581
query32 88 77 74 74
query33 539 353 298 298
query34 917 907 540 540
query35 693 763 670 670
query36 843 913 838 838
query37 137 98 81 81
query38 2760 2714 2672 2672
query39 780 760 760 760
query39_1 715 721 703 703
query40 223 136 116 116
query41 72 63 64 63
query42 107 102 102 102
query43 477 446 430 430
query44 1362 757 753 753
query45 187 186 178 178
query46 867 941 578 578
query47 1361 1414 1377 1377
query48 320 330 255 255
query49 608 437 344 344
query50 625 271 207 207
query51 3826 3870 3852 3852
query52 107 109 96 96
query53 295 331 274 274
query54 299 284 260 260
query55 88 83 90 83
query56 327 307 316 307
query57 1006 991 949 949
query58 274 258 257 257
query59 2010 2164 2149 2149
query60 349 322 311 311
query61 147 150 147 147
query62 396 354 327 327
query63 302 271 267 267
query64 4919 1237 941 941
query65 3819 3699 3721 3699
query66 1444 416 311 311
query67 15455 15628 15592 15592
query68 2405 1106 771 771
query69 447 368 323 323
query70 1044 957 944 944
query71 329 313 291 291
query72 5315 2465 3280 2465
query73 601 748 339 339
query74 8768 8695 8540 8540
query75 2728 2804 2488 2488
query76 2258 1084 694 694
query77 366 380 316 316
query78 9742 9796 9122 9122
query79 1063 916 607 607
query80 1290 602 514 514
query81 513 274 239 239
query82 1330 152 113 113
query83 363 265 253 253
query84 257 122 93 93
query85 994 546 499 499
query86 398 326 305 305
query87 2859 2958 2762 2762
query88 3544 2630 2620 2620
query89 389 350 332 332
query90 1933 174 164 164
query91 166 160 137 137
query92 78 72 71 71
query93 963 904 556 556
query94 599 329 300 300
query95 595 334 316 316
query96 642 518 249 249
query97 2367 2400 2322 2322
query98 219 203 200 200
query99 579 567 498 498
Total cold run time: 247294 ms
Total hot run time: 174572 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4030299782
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4029088506
<details>
<summary>TPC-H: <b>Total hot run time: 28006 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1a5798bd3baef10194f4ff9dad07c09a54e1e98c, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17635 4513 4326 4326
q2 q3 10732 800 520 520
q4 4723 385 263 263
q5 8190 1202 1002 1002
q6 223 174 146 146
q7 839 860 702 702
q8 10856 1517 1388 1388
q9 6811 4978 4773 4773
q10 6620 1951 1655 1655
q11 507 261 240 240
q12 771 566 467 467
q13 18059 2940 2208 2208
q14 237 231 215 215
q15 942 806 789 789
q16 759 719 674 674
q17 724 872 446 446
q18 6391 5386 5308 5308
q19 1180 1005 611 611
q20 515 505 611 505
q21 4584 1920 1517 1517
q22 378 318 251 251
Total cold run time: 101676 ms
Total hot run time: 28006 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4842 4629 4526 4526
q2 q3 3884 4381 3828 3828
q4 891 1224 800 800
q5 4147 4535 4359 4359
q6 189 184 144 144
q7 1776 1648 1541 1541
q8 2518 2712 2580 2580
q9 7493 7272 7380 7272
q10 3872 4054 3649 3649
q11 510 436 416 416
q12 494 615 463 463
q13 2880 3235 2323 2323
q14 300 313 283 283
q15 841 842 802 802
q16 721 759 732 732
q17 1184 1452 1360 1360
q18 7080 7033 6782 6782
q19 969 942 1036 942
q20 2088 2237 2007 2007
q21 4166 3546 3386 3386
q22 484 429 394 394
Total cold run time: 51329 ms
Total hot run time: 48589 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4036457474
<details>
<summary>TPC-DS: <b>Total hot run time: 153255 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 73f720ac919fc9b5631dfe4335c31b2c13e7e90f, data reload: false
query5 4330 637 529 529
query6 316 224 212 212
query7 4218 475 262 262
query8 326 243 232 232
query9 8701 2743 2724 2724
query10 521 374 366 366
query11 7273 5870 5559 5559
query12 182 126 124 124
query13 1268 442 356 356
query14 5654 3840 3575 3575
query14_1 2810 2837 2822 2822
query15 212 196 173 173
query16 1000 496 455 455
query17 1113 737 638 638
query18 2441 445 353 353
query19 209 206 186 186
query20 135 131 133 131
query21 232 146 130 130
query22 5183 4971 4849 4849
query23 16524 15905 15949 15905
query23_1 15924 15734 15923 15734
query24 7064 1792 1279 1279
query24_1 1293 1314 1302 1302
query25 636 619 418 418
query26 1612 271 156 156
query27 2880 499 314 314
query28 4743 1858 1866 1858
query29 831 562 474 474
query30 313 245 214 214
query31 1381 1284 1211 1211
query32 81 85 76 76
query33 512 325 284 284
query34 926 932 551 551
query35 646 671 578 578
query36 1100 1147 1033 1033
query37 135 89 86 86
query38 2983 2868 2873 2868
query39 895 911 844 844
query39_1 822 818 854 818
query40 231 149 140 140
query41 64 61 57 57
query42 296 299 300 299
query43 234 242 234 234
query44
query45 198 187 183 183
query46 881 983 603 603
query47 2093 2122 2020 2020
query48 314 310 235 235
query49 634 460 385 385
query50 673 280 204 204
query51 4068 4015 4039 4015
query52 284 291 279 279
query53 291 337 284 284
query54 298 269 268 268
query55 95 87 87 87
query56 329 322 312 312
query57 1389 1346 1300 1300
query58 287 285 273 273
query59 1322 1411 1302 1302
query60 335 336 321 321
query61 153 145 142 142
query62 639 586 543 543
query63 308 275 273 273
query64 4896 1280 986 986
query65
query66 1432 466 366 366
query67 16485 16589 16371 16371
query68
query69 398 328 298 298
query70 961 975 986 975
query71 345 315 300 300
query72 2939 2887 2531 2531
query73 527 537 330 330
query74 10011 9929 9764 9764
query75 2827 2746 2453 2453
query76 2114 1027 662 662
query77 361 396 300 300
query78 11194 11368 10643 10643
query79 1891 809 595 595
query80 1445 603 551 551
query81 567 281 246 246
query82 960 152 119 119
query83 325 272 249 249
query84 252 122 98 98
query85 903 476 425 425
query86 418 307 295 295
query87 3157 3100 3020 3020
query88 3589 2673 2644 2644
query89 427 372 340 340
query90 2032 176 178 176
query91 167 158 133 133
query92 84 74 71 71
query93 1141 809 496 496
query94 635 324 297 297
query95 588 343 325 325
query96 643 515 232 232
query97 2520 2517 2387 2387
query98 234 226 218 218
query99 987 938 833 833
Total cold run time: 235116 ms
Total hot run time: 153255 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3992087126
# FE Regression Coverage Report
Increment line coverage ` 93.40% (99/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4040827486
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #59984:
URL: https://github.com/apache/doris/pull/59984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3895982687
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_abc1a71a8e92f0722c9f5566d24a651a5f57b8f9/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_abc1a71a8e92f0722c9f5566d24a651a5f57b8f9/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3776516610
# BE Regression && UT Coverage Report
Increment line coverage `3.65% (22/602)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_774c62d2828db275c3e383b7be1611bfa1ab3ec1_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_774c62d2828db275c3e383b7be1611bfa1ab3ec1_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.44% (25455/35629) |
| Line Coverage | 53.92% (266370/494035) |
| Region Coverage | 51.41% (220382/428677) |
| Branch Coverage | 52.87% (94757/179211) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3776452369
# BE UT Coverage Report
Increment line coverage `11.13% (67/602)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/774c62d2828db275c3e383b7be1611bfa1ab3ec1_774c62d2828db275c3e383b7be1611bfa1ab3ec1/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/774c62d2828db275c3e383b7be1611bfa1ab3ec1_774c62d2828db275c3e383b7be1611bfa1ab3ec1/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.39% (19045/36350) |
| Line Coverage | 35.67% (176412/494589) |
| Region Coverage | 32.20% (136567/424171) |
| Branch Coverage | 33.10% (59070/178448) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3773296186
<details>
<summary>TPC-H: <b>Total hot run time: 31440 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 71fff849d4c70963d0a9cedb12b837ef19f49516, data reload: false
------ Round 1 ----------------------------------
q1 17612 4189 4045 4045
q2 2011 340 251 251
q3 10175 1300 727 727
q4 10202 838 327 327
q5 7523 2164 1851 1851
q6 239 175 140 140
q7 948 791 673 673
q8 9302 1411 1207 1207
q9 5237 4602 4499 4499
q10 6815 1817 1373 1373
q11 532 303 289 289
q12 731 744 605 605
q13 17784 3856 3058 3058
q14 293 299 300 299
q15 610 510 508 508
q16 690 685 633 633
q17 1029 798 495 495
q18 7005 6574 6343 6343
q19 1459 979 639 639
q20 397 361 246 246
q21 3062 2477 2275 2275
q22 1057 1008 957 957
Total cold run time: 104713 ms
Total hot run time: 31440 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4225 4040 4101 4040
q2 413 392 316 316
q3 2096 2626 2234 2234
q4 1392 1768 1279 1279
q5 4124 4008 4077 4008
q6 214 164 129 129
q7 1856 1806 2068 1806
q8 2664 2455 2413 2413
q9 7214 7317 7268 7268
q10 2599 2913 2263 2263
q11 525 473 461 461
q12 702 776 681 681
q13 3662 3993 3339 3339
q14 313 319 310 310
q15 567 496 505 496
q16 660 705 679 679
q17 1194 1402 1378 1378
q18 7896 7969 7840 7840
q19 916 953 909 909
q20 2068 2021 2039 2021
q21 4816 4448 4380 4380
q22 1147 1118 1056 1056
Total cold run time: 51263 ms
Total hot run time: 49306 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3762593483
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/54149f60fa5a0f6fd096217cecce66ca8e02d10c_54149f60fa5a0f6fd096217cecce66ca8e02d10c_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/54149f60fa5a0f6fd096217cecce66ca8e02d10c_54149f60fa5a0f6fd096217cecce66ca8e02d10c_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.77% (31810/49114) |
| Region Coverage | 65.51% (15854/24201) |
| Branch Coverage | 56.02% (8419/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3764190629
<details>
<summary>TPC-H: <b>Total hot run time: 31578 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 10863fa72fbef54a86c98b31a1ef360c86245121, data reload: false
------ Round 1 ----------------------------------
q1 17590 4214 4047 4047
q2 2027 363 232 232
q3 10121 1260 704 704
q4 10192 789 300 300
q5 7515 2026 1940 1940
q6 195 174 138 138
q7 922 776 668 668
q8 9271 1405 1201 1201
q9 5084 4707 4514 4514
q10 6784 1791 1371 1371
q11 512 309 271 271
q12 703 746 613 613
q13 17774 3834 3048 3048
q14 280 290 265 265
q15 598 514 501 501
q16 697 668 655 655
q17 666 831 468 468
q18 6834 6543 6499 6499
q19 1222 983 642 642
q20 406 361 250 250
q21 2990 2519 2289 2289
q22 1030 1020 962 962
Total cold run time: 103413 ms
Total hot run time: 31578 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4148 4069 4062 4062
q2 308 394 332 332
q3 2087 2611 2180 2180
q4 1334 1756 1332 1332
q5 4177 3988 4079 3988
q6 212 171 131 131
q7 1899 1841 1704 1704
q8 2875 2505 2537 2505
q9 7345 7343 7237 7237
q10 2508 2716 2242 2242
q11 564 481 465 465
q12 753 737 622 622
q13 3654 4124 3526 3526
q14 307 313 285 285
q15 540 510 512 510
q16 657 687 672 672
q17 1223 1483 1379 1379
q18 8225 7981 7749 7749
q19 897 829 891 829
q20 2013 2225 1850 1850
q21 4742 4686 4108 4108
q22 1125 1032 957 957
Total cold run time: 51593 ms
Total hot run time: 48665 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3765189017
<details>
<summary>ClickBench: <b>Total hot run time: 27.85 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5160ec02c32713ab2ccf221630a14a5dff0ff463, data reload: false
query1 0.05 0.04 0.04
query2 0.14 0.07 0.07
query3 0.32 0.08 0.08
query4 1.61 0.10 0.10
query5 0.26 0.25 0.25
query6 1.14 0.64 0.65
query7 0.02 0.02 0.02
query8 0.07 0.06 0.05
query9 0.59 0.51 0.49
query10 0.56 0.57 0.54
query11 0.26 0.14 0.13
query12 0.26 0.15 0.14
query13 0.61 0.62 0.61
query14 0.99 0.98 0.97
query15 0.90 0.83 0.82
query16 0.39 0.38 0.41
query17 1.00 1.00 1.03
query18 0.24 0.23 0.22
query19 1.99 1.82 1.86
query20 0.02 0.01 0.01
query21 15.41 0.28 0.25
query22 4.99 0.10 0.10
query23 15.40 0.40 0.22
query24 2.35 0.51 0.31
query25 0.10 0.09 0.10
query26 0.18 0.17 0.18
query27 0.09 0.10 0.10
query28 3.56 1.13 0.98
query29 12.52 3.99 3.22
query30 0.34 0.13 0.13
query31 2.82 0.66 0.44
query32 3.24 0.62 0.50
query33 2.99 3.01 3.10
query34 16.24 5.03 4.50
query35 4.50 4.45 4.44
query36 0.62 0.51 0.48
query37 0.25 0.09 0.09
query38 0.21 0.06 0.06
query39 0.08 0.05 0.05
query40 0.20 0.19 0.17
query41 0.13 0.06 0.07
query42 0.07 0.05 0.06
query43 0.06 0.06 0.05
Total cold run time: 97.77 s
Total hot run time: 27.85 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3762550113
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3762623860
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/84)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_54149f60fa5a0f6fd096217cecce66ca8e02d10c/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_54149f60fa5a0f6fd096217cecce66ca8e02d10c/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3765176616
<details>
<summary>TPC-H: <b>Total hot run time: 31924 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5160ec02c32713ab2ccf221630a14a5dff0ff463, data reload: false
------ Round 1 ----------------------------------
q1 17640 4226 4063 4063
q2 2024 361 250 250
q3 10163 1285 750 750
q4 10281 871 314 314
q5 8492 2176 1822 1822
q6 218 167 136 136
q7 930 784 664 664
q8 9274 1365 1080 1080
q9 5230 4652 4640 4640
q10 6813 1809 1383 1383
q11 534 301 284 284
q12 728 749 580 580
q13 17792 3821 3085 3085
q14 291 315 279 279
q15 582 512 514 512
q16 744 672 628 628
q17 729 839 477 477
q18 6901 6512 6954 6512
q19 1491 1070 655 655
q20 411 396 256 256
q21 3230 2643 2499 2499
q22 1131 1112 1055 1055
Total cold run time: 105629 ms
Total hot run time: 31924 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4496 4322 4368 4322
q2 330 386 316 316
q3 2264 2811 2482 2482
q4 1519 1869 1651 1651
q5 4583 4417 4266 4266
q6 213 173 125 125
q7 1950 1947 1699 1699
q8 2581 2504 2398 2398
q9 7385 7222 7063 7063
q10 2575 2758 2111 2111
q11 510 452 432 432
q12 653 700 560 560
q13 3317 3766 3105 3105
q14 283 281 256 256
q15 525 492 484 484
q16 615 654 624 624
q17 1111 1319 1314 1314
q18 7202 7319 7275 7275
q19 849 833 818 818
q20 1894 1967 1847 1847
q21 4475 4288 4019 4019
q22 1043 1016 966 966
Total cold run time: 50373 ms
Total hot run time: 48133 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3764143217
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/10863fa72fbef54a86c98b31a1ef360c86245121_10863fa72fbef54a86c98b31a1ef360c86245121_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/10863fa72fbef54a86c98b31a1ef360c86245121_10863fa72fbef54a86c98b31a1ef360c86245121_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.76% (31807/49114) |
| Region Coverage | 65.48% (15847/24201) |
| Branch Coverage | 56.04% (8422/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3764106392
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3765136940
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_5160ec02c32713ab2ccf221630a14a5dff0ff463/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_5160ec02c32713ab2ccf221630a14a5dff0ff463/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3767471690
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3767787746
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_ac0efd13d860451af1fb3ab08b8bdbc89c2eba42_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.75% (31800/49114) |
| Region Coverage | 65.48% (15847/24201) |
| Branch Coverage | 56.01% (8417/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3775954441
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/774c62d2828db275c3e383b7be1611bfa1ab3ec1_774c62d2828db275c3e383b7be1611bfa1ab3ec1_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/774c62d2828db275c3e383b7be1611bfa1ab3ec1_774c62d2828db275c3e383b7be1611bfa1ab3ec1_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.52% (1786/2246) |
| Line Coverage | 64.77% (31810/49114) |
| Region Coverage | 65.49% (15850/24201) |
| Branch Coverage | 56.03% (8420/15028) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3773027777
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/106)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_71fff849d4c70963d0a9cedb12b837ef19f49516/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_71fff849d4c70963d0a9cedb12b837ef19f49516/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3776198167
<details>
<summary>ClickBench: <b>Total hot run time: 27.78 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 774c62d2828db275c3e383b7be1611bfa1ab3ec1, data reload: false
query1 0.05 0.04 0.04
query2 0.14 0.07 0.07
query3 0.31 0.07 0.07
query4 1.60 0.10 0.09
query5 0.26 0.25 0.25
query6 1.15 0.66 0.65
query7 0.03 0.02 0.03
query8 0.07 0.05 0.06
query9 0.57 0.51 0.51
query10 0.55 0.56 0.56
query11 0.26 0.14 0.13
query12 0.26 0.14 0.13
query13 0.61 0.61 0.59
query14 0.99 0.98 0.98
query15 0.89 0.82 0.82
query16 0.41 0.38 0.43
query17 0.96 1.06 1.05
query18 0.25 0.22 0.22
query19 1.92 1.86 1.81
query20 0.02 0.01 0.01
query21 15.39 0.28 0.24
query22 4.92 0.11 0.11
query23 15.37 0.39 0.23
query24 2.30 0.50 0.31
query25 0.10 0.10 0.10
query26 0.18 0.17 0.16
query27 0.10 0.10 0.09
query28 3.37 1.13 0.96
query29 12.53 4.05 3.23
query30 0.31 0.13 0.11
query31 2.80 0.66 0.44
query32 3.23 0.63 0.50
query33 2.97 3.02 3.03
query34 16.03 5.08 4.41
query35 4.45 4.60 4.44
query36 0.61 0.50 0.49
query37 0.27 0.08 0.09
query38 0.20 0.06 0.05
query39 0.07 0.06 0.05
query40 0.20 0.18 0.17
query41 0.13 0.06 0.06
query42 0.07 0.06 0.05
query43 0.07 0.05 0.05
Total cold run time: 96.97 s
Total hot run time: 27.78 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4022383051
<details>
<summary>TPC-H: <b>Total hot run time: 27895 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6960a01f85d1459d53a9dc11ea9f6202f5f81064, data reload: false
------ Round 1 ----------------------------------
============================================
q1 17669 4584 4331 4331
q2 q3 10651 825 521 521
q4 4679 374 262 262
q5 7554 1209 1040 1040
q6 176 173 146 146
q7 796 862 690 690
q8 9292 1514 1310 1310
q9 4877 4963 4839 4839
q10 6253 1934 1663 1663
q11 460 257 250 250
q12 712 582 470 470
q13 18052 2966 2188 2188
q14 242 228 213 213
q15 917 811 816 811
q16 740 729 708 708
q17 742 900 409 409
q18 6000 5398 5225 5225
q19 1116 1007 618 618
q20 497 513 400 400
q21 4508 2231 1526 1526
q22 439 325 275 275
Total cold run time: 96372 ms
Total hot run time: 27895 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1 4789 4568 4568 4568
q2 q3 3908 4332 3870 3870
q4 872 1228 793 793
q5 4143 4425 4364 4364
q6 185 175 139 139
q7 1803 1617 1528 1528
q8 2573 2755 2671 2671
q9 7777 7453 7391 7391
q10 3739 4032 3605 3605
q11 521 459 413 413
q12 485 599 436 436
q13 2724 3173 2311 2311
q14 278 295 277 277
q15 879 802 804 802
q16 738 765 798 765
q17 1250 1483 1370 1370
q18 7301 6936 6674 6674
q19 944 848 899 848
q20 2110 2212 2070 2070
q21 3931 3464 3398 3398
q22 457 445 477 445
Total cold run time: 51407 ms
Total hot run time: 48738 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hubgeter (via GitHub)" <gi...@apache.org>.
hubgeter commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3990173363
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-3992026035
# BE Regression && UT Coverage Report
Increment line coverage `3.65% (22/602)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/59984_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/59984_d5b0951cd1524edab2e1e42b97836f2b9c5d39bd_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.47% (26140/36573) |
| Line Coverage | 54.19% (273848/505345) |
| Region Coverage | 51.45% (227566/442277) |
| Branch Coverage | 52.80% (97780/185187) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4035861023
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/73f720ac919fc9b5631dfe4335c31b2c13e7e90f_73f720ac919fc9b5631dfe4335c31b2c13e7e90f_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/73f720ac919fc9b5631dfe4335c31b2c13e7e90f_73f720ac919fc9b5631dfe4335c31b2c13e7e90f_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 79.45% (1798/2263) |
| Line Coverage | 64.68% (32265/49881) |
| Region Coverage | 65.61% (16148/24611) |
| Branch Coverage | 56.00% (8602/15360) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](iceberg)fix core when read a iceberg table that have schema change and equality delete. [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #59984:
URL: https://github.com/apache/doris/pull/59984#issuecomment-4030700163
<details>
<summary>TPC-DS: <b>Total hot run time: 152131 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 72d63164804b44f0c2989ec206c6e20dc386ffe8, data reload: false
query5 4336 636 525 525
query6 338 238 217 217
query7 4200 455 265 265
query8 353 230 232 230
query9 8700 2693 2707 2693
query10 543 392 363 363
query11 7337 5870 5546 5546
query12 188 129 124 124
query13 1262 453 352 352
query14 5566 3807 3601 3601
query14_1 2825 2803 2847 2803
query15 202 195 169 169
query16 964 460 440 440
query17 869 674 599 599
query18 2419 436 332 332
query19 210 202 175 175
query20 134 125 127 125
query21 221 135 123 123
query22 5077 4834 4834 4834
query23 16681 16062 15807 15807
query23_1 15881 15616 15888 15616
query24 7363 1683 1267 1267
query24_1 1280 1265 1269 1265
query25 582 530 445 445
query26 1364 304 171 171
query27 3373 503 313 313
query28 4506 1891 1867 1867
query29 871 582 502 502
query30 305 250 214 214
query31 1342 1282 1219 1219
query32 88 72 78 72
query33 519 360 297 297
query34 925 926 562 562
query35 652 692 598 598
query36 1105 1103 944 944
query37 132 95 82 82
query38 2924 2914 2929 2914
query39 890 857 885 857
query39_1 835 874 822 822
query40 250 155 146 146
query41 68 65 62 62
query42 311 313 299 299
query43 254 258 223 223
query44
query45 203 192 185 185
query46 900 975 614 614
query47 2130 2134 2025 2025
query48 317 328 234 234
query49 650 473 390 390
query50 672 279 213 213
query51 4112 4062 3994 3994
query52 291 294 289 289
query53 298 340 286 286
query54 313 279 277 277
query55 95 84 86 84
query56 327 341 339 339
query57 1361 1342 1290 1290
query58 296 285 313 285
query59 1350 1448 1264 1264
query60 336 330 302 302
query61 145 142 144 142
query62 621 602 548 548
query63 306 278 276 276
query64 5083 1249 980 980
query65
query66 1449 444 354 354
query67 16579 16356 16216 16216
query68
query69 384 298 280 280
query70 931 982 959 959
query71 359 314 293 293
query72 2786 2690 2005 2005
query73 533 537 317 317
query74 9994 9880 9739 9739
query75 2849 2750 2449 2449
query76 2243 1030 676 676
query77 375 382 293 293
query78 11156 11279 10612 10612
query79 2990 797 601 601
query80 1741 615 558 558
query81 590 276 244 244
query82 966 154 119 119
query83 342 265 244 244
query84 306 116 91 91
query85 902 486 427 427
query86 415 310 304 304
query87 3159 3100 2983 2983
query88 3509 2671 2643 2643
query89 428 370 344 344
query90 2032 182 175 175
query91 168 160 136 136
query92 74 75 70 70
query93 1332 832 511 511
query94 643 335 282 282
query95 586 330 369 330
query96 642 515 225 225
query97 2438 2471 2406 2406
query98 239 225 217 217
query99 1001 993 895 895
Total cold run time: 236829 ms
Total hot run time: 152131 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org