You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/10/30 23:09:48 UTC

Review Request 15106: MacAddress fix for windows ipconfig

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15106/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

- fixed support for windows ipconfig output
- tests added against the following examples:
  - windows 8.1 ipconfig /all
  - linux ifconfig
  - freebsd ifconfig


Diffs
-----

  utils/src/com/cloud/utils/net/MacAddress.java 15350c8 
  utils/test/com/cloud/utils/net/MacAddressTest.java PRE-CREATION 
  utils/test/resources/com/cloud/utils/net/ifconfig_fedora19.txt PRE-CREATION 
  utils/test/resources/com/cloud/utils/net/ifconfig_freebsd.txt PRE-CREATION 
  utils/test/resources/com/cloud/utils/net/ipconfig_windows8_1.txt PRE-CREATION 

Diff: https://reviews.apache.org/r/15106/diff/


Testing
-------

tests included


Thanks,

Laszlo Hornyak