[GitHub] [iceberg] dhruv-pratap commented on pull request #4811: Python: Replace tox by pre-commit

[GitBox <gi...@apache.org>]

dhruv-pratap commented on PR #4811:
URL: https://github.com/apache/iceberg/pull/4811#issuecomment-1135018865

   I tried to test out the instructions in contribution.md. `make test` works fine, but `make lint` is skipping everything. I have feeling it might be something to do with the working directory settings that are environment specific.
   ```logs
   (venv) ➜  python git:(fd-move-to-pre-commit) make lint
   pre-commit run 
   trim trailing whitespace.............................(no files to check)Skipped
   fix end of files.....................................(no files to check)Skipped
   check docstring is first.............................(no files to check)Skipped
   debug statements (python)............................(no files to check)Skipped
   check yaml...........................................(no files to check)Skipped
   check python ast.....................................(no files to check)Skipped
   black................................................(no files to check)Skipped
   isort................................................(no files to check)Skipped
   mypy.................................................(no files to check)Skipped
   pycln................................................(no files to check)Skipped
   
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org