You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by jl...@apache.org on 2022/11/07 06:30:05 UTC
[pinot] branch test-pagination updated (6473c38e1d -> a6570003e4)
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch test-pagination
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 6473c38e1d Add sample code to show how pagination protocol works in broker code
new a6570003e4 Add sample code to show how pagination protocol works in broker code
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (6473c38e1d)
\
N -- N -- N refs/heads/test-pagination (a6570003e4)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../requesthandler/BaseBrokerRequestHandler.java | 18 ++++++++----------
1 file changed, 8 insertions(+), 10 deletions(-)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[pinot] 01/01: Add sample code to show how pagination protocol works in broker code
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch test-pagination
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit a6570003e49caa19207e57d4bd1647424a0c758e
Author: Jack Li(Analytics Engineering) <jl...@jlli-mn1.linkedin.biz>
AuthorDate: Fri Nov 4 16:39:28 2022 -0700
Add sample code to show how pagination protocol works in broker code
---
.../requesthandler/BaseBrokerRequestHandler.java | 58 +++++++++++++++++++---
1 file changed, 50 insertions(+), 8 deletions(-)
diff --git a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
index 224f46c440..c9a6a949d5 100644
--- a/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
+++ b/pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
@@ -30,6 +30,8 @@ import java.util.HashSet;
import java.util.List;
import java.util.Map;
import java.util.Set;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionException;
import java.util.concurrent.CompletionService;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.Executor;
@@ -284,6 +286,48 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
return new BrokerResponseNative(QueryException.getException(QueryException.SQL_PARSING_ERROR, e));
}
+ if (Boolean.parseBoolean(pinotQuery.getQueryOptions().get("pagination"))) {
+ String tableName = TableNameBuilder.extractRawTableName(pinotQuery.getDataSource().getTableName());
+ // Step 1: Generate a pointer.
+ // TODO: a. add a method to generate a ID
+ // b. replace the dummyInstanceId with a real one.
+ int hash = ("dummyInstanceId" + requestId + System.currentTimeMillis()).hashCode();
+ String pointer = tableName + "_" + hash;
+
+ // Step 2: TODO invoke pagination query initialization API.
+
+ // Step 3: Submit to query executor.
+ final SqlNodeAndOptions finalSqlNodeAndOptions = sqlNodeAndOptions;
+ // TODO: use an pool based executor as the 2nd parameter below.
+ CompletableFuture.supplyAsync(() -> {
+ try {
+ return handleRequest(requestId, query, pinotQuery, compilationStartTimeNs, finalSqlNodeAndOptions, request,
+ requesterIdentity, requestContext);
+ } catch (Exception e) {
+ throw new CompletionException(e);
+ }
+ }).thenApply(brokerResponseNative -> {
+ // Step 5: TODO invoke upload result API.
+
+ return null;
+ }).exceptionally(exception -> {
+ // Step 6: TODO Handle exception.
+ System.out.println();
+ return null;
+ });
+
+ // Step 4: TODO Put pointer only to the response and return.
+ return new BrokerResponseNative();
+ }
+
+ return handleRequest(requestId, query, pinotQuery, compilationStartTimeNs, sqlNodeAndOptions, request,
+ requesterIdentity, requestContext);
+ }
+
+ private BrokerResponseNative handleRequest(long requestId, String query, PinotQuery pinotQuery,
+ long compilationStartTimeNs, @Nullable SqlNodeAndOptions sqlNodeAndOptions, JsonNode request,
+ @Nullable RequesterIdentity requesterIdentity, RequestContext requestContext)
+ throws Exception {
if (isLiteralOnlyQuery(pinotQuery)) {
LOGGER.debug("Request {} contains only Literal, skipping server query: {}", requestId, query);
try {
@@ -528,8 +572,7 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
// Send empty response since we don't need to evaluate either offline or realtime request.
BrokerResponseNative brokerResponse = BrokerResponseNative.empty();
// Extract source info from incoming request
- _queryLogger.log(new QueryLogger.QueryLogParams(
- requestId, query, requestContext, tableName, 0, new ServerStats(),
+ _queryLogger.log(new QueryLogger.QueryLogParams(requestId, query, requestContext, tableName, 0, new ServerStats(),
brokerResponse, System.nanoTime(), requesterIdentity));
return brokerResponse;
}
@@ -670,9 +713,9 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
LOGGER.debug("Remove track of running query: {}", requestId);
}
} else {
- brokerResponse = processBrokerRequest(requestId, brokerRequest, serverBrokerRequest, offlineBrokerRequest,
- offlineRoutingTable, realtimeBrokerRequest, realtimeRoutingTable, remainingTimeMs, serverStats,
- requestContext);
+ brokerResponse =
+ processBrokerRequest(requestId, brokerRequest, serverBrokerRequest, offlineBrokerRequest, offlineRoutingTable,
+ realtimeBrokerRequest, realtimeRoutingTable, remainingTimeMs, serverStats, requestContext);
}
brokerResponse.setExceptions(exceptions);
@@ -696,9 +739,8 @@ public abstract class BaseBrokerRequestHandler implements BrokerRequestHandler {
// Extract source info from incoming request
_queryLogger.log(
- new QueryLogger.QueryLogParams(
- requestId, query, requestContext, tableName, numUnavailableSegments, serverStats, brokerResponse,
- totalTimeMs, requesterIdentity));
+ new QueryLogger.QueryLogParams(requestId, query, requestContext, tableName, numUnavailableSegments, serverStats,
+ brokerResponse, totalTimeMs, requesterIdentity));
return brokerResponse;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org