[GitHub] [hive] aturoczy commented on a diff in pull request #4316: HIVE-27337: Trim the starting and trailing white spaces in HMS for cr…

["aturoczy (via GitHub)" <gi...@apache.org>]

aturoczy commented on code in PR #4316:
URL: https://github.com/apache/hive/pull/4316#discussion_r1192160534


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java:
##########
@@ -2276,6 +2276,9 @@ private void create_table_core(final RawStore ms, final CreateTableRequest req)
           + " already exists");
     }
 
+    tbl.setDbName(tbl.getDbName().trim());

Review Comment:
   won't it be much more better if the getDbName and the getTableName getter do the trim?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org