You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <ro...@mesosphe.re> on 2013/10/15 03:51:47 UTC
Review Request 14644: Merged completed frameworks with duplicate IDs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14644/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Merged completed frameworks with duplicate IDs.
It is possible for frameworks to register with duplicate IDs, in which
case using an ID in a URL is no longer specific enough to choose a
single framework.
If there are completed frameworks with duplicate IDs, or if there is an
active framework with the same ID as completed ones, merge the relevant
values of the frameworks to create a single, uber framework.
In the case of a completed framework duplicating an active framework,
delete the completed one so the uber version appears only as active.
Fixes MESOS-417
Diffs
-----
src/webui/master/static/framework.html 6e5cd9f9e48597c7894d6381377c8a291014e8f3
src/webui/master/static/js/controllers.js 305aeaa195183c188e8ed949ccd67b49cbd757a0
Diff: https://reviews.apache.org/r/14644/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 14644: Merged completed frameworks with duplicate IDs.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 15, 2013, 2:22 a.m., Ben Mahler wrote:
> > I somehow missed Brenden's fix for this in the Master (here: https://reviews.apache.org/r/13599). We should probably just push that through reviews rather than complicating the webui any further, does that sound good?
(It's not a fix in the Master yet, but his change could be applied to the Master in a similar way that he applied it to the Slave.)
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14644/#review27000
-----------------------------------------------------------
On Oct. 15, 2013, 1:52 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14644/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 1:52 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-417
> https://issues.apache.org/jira/browse/MESOS-417
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged completed frameworks with duplicate IDs.
>
> It is possible for frameworks to register with duplicate IDs, in which
> case using an ID in a URL is no longer specific enough to choose a
> single framework.
>
> If there are completed frameworks with duplicate IDs, or if there is an
> active framework with the same ID as completed ones, merge the relevant
> values of the frameworks to create a single, uber framework.
>
> In the case of a completed framework duplicating an active framework,
> delete the completed one so the uber version appears only as active.
>
> Fixes MESOS-417
>
>
> Diffs
> -----
>
> src/webui/master/static/framework.html 6e5cd9f9e48597c7894d6381377c8a291014e8f3
> src/webui/master/static/js/controllers.js 305aeaa195183c188e8ed949ccd67b49cbd757a0
>
> Diff: https://reviews.apache.org/r/14644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 14644: Merged completed frameworks with duplicate IDs.
Posted by Ross Allen <ro...@mesosphe.re>.
> On Oct. 15, 2013, 2:22 a.m., Ben Mahler wrote:
> > I somehow missed Brenden's fix for this in the Master (here: https://reviews.apache.org/r/13599). We should probably just push that through reviews rather than complicating the webui any further, does that sound good?
>
> Ben Mahler wrote:
> (It's not a fix in the Master yet, but his change could be applied to the Master in a similar way that he applied it to the Slave.)
>
> Ross Allen wrote:
> It doesn't look like Brenden's change affects the data returned? The same check still happens in slave.cpp to see if a completed framework with the given ID already exists, but it doesn't change merging frameworks with duplicate IDs.
>
> This also doesn't appear to address a new framework with the same ID as a completed framework. The change in this request merges completed frameworks with duplicate IDs together and completed frameworks into the active ones with the same ID.
>
> Ben Mahler wrote:
> The backends (master / slave) should not return a framework with the same ID within both active and completed, you're correct that Brenden's change is not all the way there in terms of fixing this :)
>
> I think the fix should be done in the Master / Slave rather than compensating for the bug by adding complexity to the webui. If this were fixed in the Master/Slave would that be sufficient?
If Master/Slave ensured framework ID uniqueness, that would solve the problem this request fixes and make https://issues.apache.org/jira/browse/MESOS-417 no longer an issue. MESOS-417 happens because the framework appears both in the active frameworks list and in the completed frameworks list.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14644/#review27000
-----------------------------------------------------------
On Oct. 15, 2013, 1:52 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14644/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 1:52 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-417
> https://issues.apache.org/jira/browse/MESOS-417
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged completed frameworks with duplicate IDs.
>
> It is possible for frameworks to register with duplicate IDs, in which
> case using an ID in a URL is no longer specific enough to choose a
> single framework.
>
> If there are completed frameworks with duplicate IDs, or if there is an
> active framework with the same ID as completed ones, merge the relevant
> values of the frameworks to create a single, uber framework.
>
> In the case of a completed framework duplicating an active framework,
> delete the completed one so the uber version appears only as active.
>
> Fixes MESOS-417
>
>
> Diffs
> -----
>
> src/webui/master/static/framework.html 6e5cd9f9e48597c7894d6381377c8a291014e8f3
> src/webui/master/static/js/controllers.js 305aeaa195183c188e8ed949ccd67b49cbd757a0
>
> Diff: https://reviews.apache.org/r/14644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 14644: Merged completed frameworks with duplicate IDs.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 15, 2013, 2:22 a.m., Ben Mahler wrote:
> > I somehow missed Brenden's fix for this in the Master (here: https://reviews.apache.org/r/13599). We should probably just push that through reviews rather than complicating the webui any further, does that sound good?
>
> Ben Mahler wrote:
> (It's not a fix in the Master yet, but his change could be applied to the Master in a similar way that he applied it to the Slave.)
>
> Ross Allen wrote:
> It doesn't look like Brenden's change affects the data returned? The same check still happens in slave.cpp to see if a completed framework with the given ID already exists, but it doesn't change merging frameworks with duplicate IDs.
>
> This also doesn't appear to address a new framework with the same ID as a completed framework. The change in this request merges completed frameworks with duplicate IDs together and completed frameworks into the active ones with the same ID.
The backends (master / slave) should not return a framework with the same ID within both active and completed, you're correct that Brenden's change is not all the way there in terms of fixing this :)
I think the fix should be done in the Master / Slave rather than compensating for the bug by adding complexity to the webui. If this were fixed in the Master/Slave would that be sufficient?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14644/#review27000
-----------------------------------------------------------
On Oct. 15, 2013, 1:52 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14644/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 1:52 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-417
> https://issues.apache.org/jira/browse/MESOS-417
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged completed frameworks with duplicate IDs.
>
> It is possible for frameworks to register with duplicate IDs, in which
> case using an ID in a URL is no longer specific enough to choose a
> single framework.
>
> If there are completed frameworks with duplicate IDs, or if there is an
> active framework with the same ID as completed ones, merge the relevant
> values of the frameworks to create a single, uber framework.
>
> In the case of a completed framework duplicating an active framework,
> delete the completed one so the uber version appears only as active.
>
> Fixes MESOS-417
>
>
> Diffs
> -----
>
> src/webui/master/static/framework.html 6e5cd9f9e48597c7894d6381377c8a291014e8f3
> src/webui/master/static/js/controllers.js 305aeaa195183c188e8ed949ccd67b49cbd757a0
>
> Diff: https://reviews.apache.org/r/14644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 14644: Merged completed frameworks with duplicate IDs.
Posted by Ross Allen <ro...@mesosphe.re>.
> On Oct. 15, 2013, 2:22 a.m., Ben Mahler wrote:
> > I somehow missed Brenden's fix for this in the Master (here: https://reviews.apache.org/r/13599). We should probably just push that through reviews rather than complicating the webui any further, does that sound good?
>
> Ben Mahler wrote:
> (It's not a fix in the Master yet, but his change could be applied to the Master in a similar way that he applied it to the Slave.)
It doesn't look like Brenden's change affects the data returned? The same check still happens in slave.cpp to see if a completed framework with the given ID already exists, but it doesn't change merging frameworks with duplicate IDs.
This also doesn't appear to address a new framework with the same ID as a completed framework. The change in this request merges completed frameworks with duplicate IDs together and completed frameworks into the active ones with the same ID.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14644/#review27000
-----------------------------------------------------------
On Oct. 15, 2013, 1:52 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14644/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 1:52 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-417
> https://issues.apache.org/jira/browse/MESOS-417
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged completed frameworks with duplicate IDs.
>
> It is possible for frameworks to register with duplicate IDs, in which
> case using an ID in a URL is no longer specific enough to choose a
> single framework.
>
> If there are completed frameworks with duplicate IDs, or if there is an
> active framework with the same ID as completed ones, merge the relevant
> values of the frameworks to create a single, uber framework.
>
> In the case of a completed framework duplicating an active framework,
> delete the completed one so the uber version appears only as active.
>
> Fixes MESOS-417
>
>
> Diffs
> -----
>
> src/webui/master/static/framework.html 6e5cd9f9e48597c7894d6381377c8a291014e8f3
> src/webui/master/static/js/controllers.js 305aeaa195183c188e8ed949ccd67b49cbd757a0
>
> Diff: https://reviews.apache.org/r/14644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 14644: Merged completed frameworks with duplicate IDs.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14644/#review27000
-----------------------------------------------------------
I somehow missed Brenden's fix for this in the Master (here: https://reviews.apache.org/r/13599). We should probably just push that through reviews rather than complicating the webui any further, does that sound good?
- Ben Mahler
On Oct. 15, 2013, 1:52 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14644/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 1:52 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-417
> https://issues.apache.org/jira/browse/MESOS-417
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Merged completed frameworks with duplicate IDs.
>
> It is possible for frameworks to register with duplicate IDs, in which
> case using an ID in a URL is no longer specific enough to choose a
> single framework.
>
> If there are completed frameworks with duplicate IDs, or if there is an
> active framework with the same ID as completed ones, merge the relevant
> values of the frameworks to create a single, uber framework.
>
> In the case of a completed framework duplicating an active framework,
> delete the completed one so the uber version appears only as active.
>
> Fixes MESOS-417
>
>
> Diffs
> -----
>
> src/webui/master/static/framework.html 6e5cd9f9e48597c7894d6381377c8a291014e8f3
> src/webui/master/static/js/controllers.js 305aeaa195183c188e8ed949ccd67b49cbd757a0
>
> Diff: https://reviews.apache.org/r/14644/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 14644: Merged completed frameworks with duplicate IDs.
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14644/
-----------------------------------------------------------
(Updated Oct. 15, 2013, 1:52 a.m.)
Review request for mesos and Ben Mahler.
Bugs: MESOS-417
https://issues.apache.org/jira/browse/MESOS-417
Repository: mesos-git
Description
-------
Merged completed frameworks with duplicate IDs.
It is possible for frameworks to register with duplicate IDs, in which
case using an ID in a URL is no longer specific enough to choose a
single framework.
If there are completed frameworks with duplicate IDs, or if there is an
active framework with the same ID as completed ones, merge the relevant
values of the frameworks to create a single, uber framework.
In the case of a completed framework duplicating an active framework,
delete the completed one so the uber version appears only as active.
Fixes MESOS-417
Diffs
-----
src/webui/master/static/framework.html 6e5cd9f9e48597c7894d6381377c8a291014e8f3
src/webui/master/static/js/controllers.js 305aeaa195183c188e8ed949ccd67b49cbd757a0
Diff: https://reviews.apache.org/r/14644/diff/
Testing
-------
Thanks,
Ross Allen