You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2017/07/05 07:23:46 UTC

[GitHub] nifi issue #1976: NIFI-1613: Make use of column type correctly at ConvertJSO...

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/1976
  
    This PR contains commits from #293 which has been closed due to being inactive, but the change was reasonable. I've cherry picked commits from the PR, the 1st commit in this PR is a squashed ones those are made by @ToivoAdams . Thanks for your contribution Toivo!
    
    I also added the 2nd commit, in order to update the proposed change with the latest codebase, as well as few modification.
    
    We now have JsonTreeReader and PutDatabaseRecord those can handle type coercing better, so I think it's not necessary to handle DATE/TIME conversion at ConvertJSONToSQL. However, without this fix, it can truncate numeric values wrongly and lose part of user data, and that should be fixed at least.
    
    This PR is ready for review, thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---