[GitHub] [spark] Kimahriman commented on a diff in pull request #38880: [SPARK-38277][SS] Clear write batch after RocksDB state store's commit

[GitBox <gi...@apache.org>]

Kimahriman commented on code in PR #38880:
URL: https://github.com/apache/spark/pull/38880#discussion_r1038109358


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala:
##########
@@ -116,7 +116,9 @@ class RocksDBSuite extends SparkFunSuite {
     withDB(remoteDir, conf = conf) { db =>
       // Generate versions without cleaning up
       for (version <- 1 to 50) {
-        db.put(version.toString, version.toString)  // update "1" -> "1", "2" -> "2", ...

Review Comment:
   I also had the same realization for this test 😂 
   
   I _think_ this is due to what I learned was "trivial moves" during compaction, where if the keys don't overlap you don't need to rewrite the SST files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org