You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dpogue <gi...@git.apache.org> on 2014/10/11 07:06:17 UTC
[GitHub] cordova-android pull request: Ignore --device option in Android bu...
GitHub user dpogue opened a pull request:
https://github.com/apache/cordova-android/pull/127
Ignore --device option in Android build
iOS uses the `--device` flag to indicate that it should build for the device rather than the simulator. Until recently, Android simply ignored this option. Now it throws an error.
This causes problems for people targeting multiple platforms with the CLI tools, because a command like `cordova build --release --device` will now fail on Android, rather than building both Android and iOS versions of the app.
**Simple test case:**
```bash
$ cordova init myapp
$ cd ./myapp
$ cordova platform add ios android
$ cordova build --release --device --verbose
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dpogue/cordova-android patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/127.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #127
----
commit 138b24b6865a37ebbc08336c23117629f961cd83
Author: Darryl Pogue <dv...@gmail.com>
Date: 2014-10-11T05:04:17Z
Ignore --device option in android build
iOS uses the `--device` flag to indicate that it should build for the
device rather than the simulator. Until recently, Android simply ignored
this option. Now it throws an error.
This causes problems for people targeting multiple platforms with the CLI
tools, because a command like `cordova build --release --device` will now
fail on Android, rather than building both Android and iOS versions of the
app.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: Ignore --device option in Android bu...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/127#issuecomment-66558271
Going to close this out but will implement both of your suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: Ignore --device option in Android bu...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-android/pull/127#issuecomment-60360056
LGTM
I would probably warn if there is some unrecognized option instead of failing. This will simplify moving forward.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: Ignore --device option in Android bu...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/127#issuecomment-66558329
Also - created a JIRA: https://issues.apache.org/jira/browse/CB-8147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: Ignore --device option in Android bu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: Ignore --device option in Android bu...
Posted by robinbonnes <gi...@git.apache.org>.
Github user robinbonnes commented on the pull request:
https://github.com/apache/cordova-android/pull/127#issuecomment-60356591
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org