You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/04/23 07:21:41 UTC

[PR] More cleanup [maven-mvnd]

cstamas opened a new pull request, #967:
URL: https://github.com/apache/maven-mvnd/pull/967

   Changes:
   * update maven-wrapper to 3.3.0
   * do not override parent versions
   * use properties where appropriate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] More cleanup [maven-mvnd]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #967:
URL: https://github.com/apache/maven-mvnd/pull/967


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] More cleanup [maven-mvnd]

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #967:
URL: https://github.com/apache/maven-mvnd/pull/967#discussion_r1575779152


##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -6,13 +6,12 @@
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
 #
-#   https://www.apache.org/licenses/LICENSE-2.0
+#   http://www.apache.org/licenses/LICENSE-2.0

Review Comment:
   yes, but this is licence, "verbatim copied":
   https://www.apache.org/licenses/LICENSE-2.0
   
   In license it does have HTTP and not HTTPS



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] More cleanup [maven-mvnd]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #967:
URL: https://github.com/apache/maven-mvnd/pull/967#discussion_r1575778108


##########
.mvn/wrapper/maven-wrapper.properties:
##########
@@ -6,13 +6,12 @@
 # "License"); you may not use this file except in compliance
 # with the License.  You may obtain a copy of the License at
 #
-#   https://www.apache.org/licenses/LICENSE-2.0
+#   http://www.apache.org/licenses/LICENSE-2.0

Review Comment:
   Fwiw, the http link redirects to https...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org