You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "jonmeredith (via GitHub)" <gi...@apache.org> on 2025/04/15 21:21:36 UTC
[PR] CASSANDRA-20561 [cassandra]
jonmeredith opened a new pull request, #4099:
URL: https://github.com/apache/cassandra/pull/4099
See [CASSANDRA-20561](https://issues.apache.org/jira/browse/CASSANDRA-20561)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20561 [cassandra]
Posted by "jonmeredith (via GitHub)" <gi...@apache.org>.
jonmeredith commented on code in PR #4099:
URL: https://github.com/apache/cassandra/pull/4099#discussion_r2054393889
##########
src/java/org/apache/cassandra/db/LivenessInfo.java:
##########
@@ -220,7 +220,11 @@ public boolean supersedes(LivenessInfo other)
if (isExpired() ^ other.isExpired())
return isExpired();
if (isExpiring() == other.isExpiring())
- return localExpirationTime() > other.localExpirationTime();
+ {
+ return localExpirationTime() > other.localExpirationTime() ||
+ (localExpirationTime() == other.localExpirationTime() && ttl() < other.ttl());
Review Comment:
Good call. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20561 [cassandra]
Posted by "krummas (via GitHub)" <gi...@apache.org>.
krummas commented on code in PR #4099:
URL: https://github.com/apache/cassandra/pull/4099#discussion_r2053906546
##########
src/java/org/apache/cassandra/db/LivenessInfo.java:
##########
@@ -220,7 +220,11 @@ public boolean supersedes(LivenessInfo other)
if (isExpired() ^ other.isExpired())
return isExpired();
if (isExpiring() == other.isExpiring())
- return localExpirationTime() > other.localExpirationTime();
+ {
+ return localExpirationTime() > other.localExpirationTime() ||
+ (localExpirationTime() == other.localExpirationTime() && ttl() < other.ttl());
Review Comment:
nit; maybe update the comment to this method about the ttls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20561 [cassandra]
Posted by "jonmeredith (via GitHub)" <gi...@apache.org>.
jonmeredith commented on PR #4099:
URL: https://github.com/apache/cassandra/pull/4099#issuecomment-2822600585
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] CASSANDRA-20561 [cassandra]
Posted by "jonmeredith (via GitHub)" <gi...@apache.org>.
jonmeredith closed pull request #4099: CASSANDRA-20561
URL: https://github.com/apache/cassandra/pull/4099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org