You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by klopfdreh <gi...@git.apache.org> on 2015/02/14 16:00:17 UTC
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
GitHub user klopfdreh opened a pull request:
https://github.com/apache/wicket/pull/90
WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/klopfdreh/wicket WICKET-5837
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit 53566ad3b189c1f018a527b7a53345f5c0b14679
Author: klopfdreh <kl...@192.168.2.110>
Date: 2015-02-14T14:57:18Z
WICKET-5837 JUnit tests may fail because of AbstractDefaultAjaxBehavior
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh closed the pull request at:
https://github.com/apache/wicket/pull/90
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/90#issuecomment-74624272
Ah ok! :-) - thanks a lot - so I'm closing this PR, now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/90#issuecomment-74541335
@bitstorm - everything ok with this PR - or should I change something?
There are two ways to proceed - one is to change all 14 unit tests and the other is to change the order of the parameters at the central place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/90#discussion_r24726639
--- Diff: wicket-core/src/test/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadFieldTest.java ---
@@ -63,13 +64,16 @@ protected void onSubmit()
for (int i = 1; i < 2; i++)
{
FileUpload fileUpload = uploads.get(i);
- assertEquals(MultiFileUploadFieldTest.class.getSimpleName()+i+".txt", fileUpload.getClientFileName());
+ assertEquals(MultiFileUploadFieldTest.class.getSimpleName() + (i - 1) + ".txt",
--- End diff --
I run the test with i-1 and it was success, but maybe the code at this place changed a bit. So if it passing revert it.
Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on a diff in the pull request:
https://github.com/apache/wicket/pull/90#discussion_r24723488
--- Diff: wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java ---
@@ -233,12 +246,6 @@ protected final CharSequence renderAjaxAttributes(final Component component,
attributesJson.put(AjaxAttributeName.MARKUP_ID.jsonName(), componentId);
}
--- End diff --
Because the Unit Tests check the Order of the Parameter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by bitstorm <gi...@git.apache.org>.
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/90#discussion_r24722572
--- Diff: wicket-core/src/main/java/org/apache/wicket/ajax/AbstractDefaultAjaxBehavior.java ---
@@ -233,12 +246,6 @@ protected final CharSequence renderAjaxAttributes(final Component component,
attributesJson.put(AjaxAttributeName.MARKUP_ID.jsonName(), componentId);
}
--- End diff --
I'm just curious...why have you moved the 5 lines below at the beginning of the method (line 223)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/90#issuecomment-74378512
Linked ticket: https://issues.apache.org/jira/browse/WICKET-5837
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by bitstorm <gi...@git.apache.org>.
Github user bitstorm commented on the pull request:
https://github.com/apache/wicket/pull/90#issuecomment-74585821
actually I have already applied your commit to 6.x (hash 1a6f1bde1a6b576f39bf6fd6d5129d577319c2a7 ). So now its ok. I forgot to notify you about it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by klopfdreh <gi...@git.apache.org>.
Github user klopfdreh commented on the pull request:
https://github.com/apache/wicket/pull/90#issuecomment-74439535
I run the test with i-1 and it was success, but maybe the code at this place changed a bit. So if it passing revert it.
Thanks a lot!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: WICKET-5837 JUnit tests may fail because of A...
Posted by bitstorm <gi...@git.apache.org>.
Github user bitstorm commented on a diff in the pull request:
https://github.com/apache/wicket/pull/90#discussion_r24726057
--- Diff: wicket-core/src/test/java/org/apache/wicket/markup/html/form/upload/MultiFileUploadFieldTest.java ---
@@ -63,13 +64,16 @@ protected void onSubmit()
for (int i = 1; i < 2; i++)
{
FileUpload fileUpload = uploads.get(i);
- assertEquals(MultiFileUploadFieldTest.class.getSimpleName()+i+".txt", fileUpload.getClientFileName());
+ assertEquals(MultiFileUploadFieldTest.class.getSimpleName() + (i - 1) + ".txt",
--- End diff --
There's a problem with '(i - 1)'. I've reverted it to simply 'i' and test passes with success. Can you confirm that this change is not necessary?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---