[GitHub] [phoenix-connectors] joshelser commented on a change in pull request #11: PHOENIX-5619 CREATE TABLE AS SELECT for Phoenix table doesn't work co…

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #11: PHOENIX-5619 CREATE TABLE AS SELECT for Phoenix table doesn't work co…
URL: https://github.com/apache/phoenix-connectors/pull/11#discussion_r366121918
 
 

 ##########
 File path: phoenix-hive/src/main/java/org/apache/phoenix/hive/PhoenixSerializer.java
 ##########
 @@ -64,12 +64,40 @@
 
     public PhoenixSerializer(Configuration config, Properties tbl) throws SerDeException {
         String mapping = tbl.getProperty(PhoenixStorageHandlerConstants.PHOENIX_COLUMN_MAPPING, null);
-        if(mapping!=null ) {
+        if(mapping != null) {
             config.set(PhoenixStorageHandlerConstants.PHOENIX_COLUMN_MAPPING, mapping);
         }
+
+        String tableName = tbl.getProperty(PhoenixStorageHandlerConstants.PHOENIX_TABLE_NAME);
+        config.set(PhoenixStorageHandlerConstants.PHOENIX_TABLE_NAME, tableName);
+
+        config.set(PhoenixStorageHandlerConstants.PHOENIX_ROWKEYS,
+          tbl.getProperty(PhoenixStorageHandlerConstants.PHOENIX_ROWKEYS));
+
+        String quorum = config.get(PhoenixStorageHandlerConstants.ZOOKEEPER_QUORUM);
+        if (quorum == null) {
 
 Review comment:
   Hehe, thanks Toshi. I wish we understood better how Hive would call this code as it would help us write some more terse code :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services