You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2025/01/03 13:54:32 UTC
[PR] Copy edits in comments, API doc, and messages [maven]
elharo opened a new pull request, #2020:
URL: https://github.com/apache/maven/pull/2020
In particular I've followed Oracle's usage of unhyphenated "class path" and "module path" when referring to the concepts instead of the CLU argument. --module-path is still used when referring to the clommand line flags.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy edits in comments, API doc, and messages [maven]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #2020:
URL: https://github.com/apache/maven/pull/2020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy edits in comments, API doc, and messages [maven]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on code in PR #2020:
URL: https://github.com/apache/maven/pull/2020#discussion_r1903198505
##########
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##########
@@ -68,9 +68,9 @@ public enum JavaPathType implements PathType {
*
* <ul>
* <li>If {@link #MODULES} path type is also set, then the dependency can be placed either on the
- * class-path or on the module-path, but only one of those. The choice is up to the plugin,
+ * class-path or on the module path, but only one of those. The choice is up to the plugin,
Review Comment:
class path ?
##########
impl/maven-impl/src/main/java/org/apache/maven/internal/impl/DefaultDependencyResolverResult.java:
##########
@@ -124,31 +124,31 @@ private void addPathElement(PathType type, Path path) {
/**
* Adds main and test output directories to the result. This method adds the main output directory
- * to the module-path if it contains a {@code module-info.class}, or to the class-path otherwise.
+ * to the module path if it contains a {@code module-info.class}, or to the class-path otherwise.
Review Comment:
class path ?
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##########
@@ -54,7 +54,7 @@ public interface Type extends ExtensibleEnum {
String BOM = "bom";
/**
- * Artifact type name for a JAR file that can be placed either on the class-path or on the module-path.
+ * Artifact type name for a JAR file that can be placed either on the class-path or on the module path.
Review Comment:
class path ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Copy edits in comments, API doc, and messages [maven]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #2020:
URL: https://github.com/apache/maven/pull/2020#discussion_r1903264126
##########
impl/maven-impl/src/main/java/org/apache/maven/internal/impl/DefaultDependencyResolverResult.java:
##########
@@ -124,31 +124,31 @@ private void addPathElement(PathType type, Path path) {
/**
* Adds main and test output directories to the result. This method adds the main output directory
- * to the module-path if it contains a {@code module-info.class}, or to the class-path otherwise.
+ * to the module path if it contains a {@code module-info.class}, or to the class-path otherwise.
Review Comment:
done
##########
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##########
@@ -54,7 +54,7 @@ public interface Type extends ExtensibleEnum {
String BOM = "bom";
/**
- * Artifact type name for a JAR file that can be placed either on the class-path or on the module-path.
+ * Artifact type name for a JAR file that can be placed either on the class-path or on the module path.
Review Comment:
done
##########
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##########
@@ -68,9 +68,9 @@ public enum JavaPathType implements PathType {
*
* <ul>
* <li>If {@link #MODULES} path type is also set, then the dependency can be placed either on the
- * class-path or on the module-path, but only one of those. The choice is up to the plugin,
+ * class-path or on the module path, but only one of those. The choice is up to the plugin,
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org