You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/12/08 14:25:53 UTC

[GitHub] [incubator-hugegraph-toolchain] imbajin commented on a diff in pull request #394: fix shell execute permission

imbajin commented on code in PR #394:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/394#discussion_r1043413461


##########
hugegraph-loader/pom.xml:
##########
@@ -650,9 +650,11 @@
                         <configuration>
                             <target>
                                 <tar destfile="${project.basedir}/${final.name}.tar.gz"

Review Comment:
   > the generate binary's dest path should not be project's target dir ? @coderzc @imbajin
   
   it should under the target, but be careful to check the relative influence like in computer's CI or some script



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org