You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2024/04/08 06:20:26 UTC
[PR] GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2 [arrow]
AlenkaF opened a new pull request, #41059:
URL: https://github.com/apache/arrow/pull/41059
### Rationale for this change
`test_make_write_options_error` has been failing on Cython 2 crossbow build because in older versions of Cython the methods were "regular" C extension method had type check automatically built in. In Cython 3 that is not the case, see https://github.com/cython/cython/issues/6127 and so the check for `ParquetFileFormat` was added in https://github.com/apache/arrow/pull/40976.
### What changes are included in this PR?
Checking the error raised for both messages, type check and the check for `ParquetFileFormat` added in https://github.com/apache/arrow/pull/40976.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2 [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #41059:
URL: https://github.com/apache/arrow/pull/41059#issuecomment-2042882045
Thanks for the fix @AlenkaF !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2 [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #41059:
URL: https://github.com/apache/arrow/pull/41059#issuecomment-2047365320
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 376a271875ca595003e56aa7bec8eee15e379055.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/23658069915) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41059:
URL: https://github.com/apache/arrow/pull/41059#issuecomment-2042017589
Revision: 3d92297c7d01abf938115941b954d640c0aa14a4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-c993a5b07c](https://github.com/ursacomputing/crossbow/branches/all?query=actions-c993a5b07c)
|Task|Status|
|----|------|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/8596001233/job/23551735890)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2 [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #41059:
URL: https://github.com/apache/arrow/pull/41059
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2 [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #41059:
URL: https://github.com/apache/arrow/pull/41059#issuecomment-2042434084
@github-actions crossbow submit test-conda-python-3.10-cython2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2 [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #41059:
URL: https://github.com/apache/arrow/pull/41059#issuecomment-2042013682
@github-actions crossbow submit test-conda-python-3.10-cython2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-41043: [CI][Python] check message in test_make_write_options_error for Cython 2 [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #41059:
URL: https://github.com/apache/arrow/pull/41059#issuecomment-2042438163
Revision: 6ca5fe33a9ddba722871925346af61eee789e5ec
Submitted crossbow builds: [ursacomputing/crossbow @ actions-f5869d858a](https://github.com/ursacomputing/crossbow/branches/all?query=actions-f5869d858a)
|Task|Status|
|----|------|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/8598794231/job/23560342652)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org