You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Ivan Wang <yi...@pivotal.io> on 2015/01/06 17:33:45 UTC

Review Request 29630: Install Wizard Step 5 should have a checkbox for 'Select All' instead of 'all/none'

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29630/
-----------------------------------------------------------

Review request for Ambari.


Bugs: AMBARI-8823
    https://issues.apache.org/jira/browse/AMBARI-8823


Repository: ambari


Description
-------

'Select All' services should have a checkbox rather than 'all/none' links / labels.


Diffs
-----

  ambari-web/app/controllers/wizard/step4_controller.js 3f45014 
  ambari-web/app/styles/application.less 12d363c 
  ambari-web/app/templates/wizard/step4.hbs 68a7e0e 
  ambari-web/test/controllers/wizard/step4_test.js 9d12275 

Diff: https://reviews.apache.org/r/29630/diff/


Testing
-------


Thanks,

Ivan Wang


Re: Review Request 29630: Install Wizard Step 5 should have a checkbox for 'Select All' instead of 'all/none'

Posted by Saman Alvi <sa...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29630/#review66849
-----------------------------------------------------------

Ship it!


Ship It!

- Saman Alvi


On Jan. 6, 2015, 4:33 p.m., Ivan Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29630/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 4:33 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-8823
>     https://issues.apache.org/jira/browse/AMBARI-8823
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 'Select All' services should have a checkbox rather than 'all/none' links / labels.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step4_controller.js 3f45014 
>   ambari-web/app/styles/application.less 12d363c 
>   ambari-web/app/templates/wizard/step4.hbs 68a7e0e 
>   ambari-web/test/controllers/wizard/step4_test.js 9d12275 
> 
> Diff: https://reviews.apache.org/r/29630/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Wang
> 
>