[GitHub] [accumulo] cshannon commented on a diff in pull request #2816: Updating RestoreZookeeper utility to extend KeywordExecutable (#2807)

[GitBox <gi...@apache.org>]

cshannon commented on code in PR #2816:
URL: https://github.com/apache/accumulo/pull/2816#discussion_r923719004


##########
core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooReaderWriter.java:
##########
@@ -40,7 +40,7 @@ public interface Mutator {
     byte[] mutate(byte[] currentValue) throws AcceptableThriftTableOperationException;
   }
 
-  public ZooReaderWriter(SiteConfiguration conf) {
+  public ZooReaderWriter(AccumuloConfiguration conf) {

Review Comment:
   I changed it because the Admin utility only had AccumuloConfiguration available to pass which is a superclass of SiteConfiguration. I wasn't sure if there was a way to get SiteConfiguration from that but since that's specifically just for shell arguments and AccumuloConfiguration is more generic it seemed like AccumuloConfiguration would be better to pass anyways to the constructor. Since it's a superclass it should be backwards compatible to any existing code passing in a SiteConfiguration object.
   
   https://github.com/apache/accumulo/blob/600ccf718ff1c08c2ec27ce00c221b8114e395d5/server/base/src/main/java/org/apache/accumulo/server/util/Admin.java#L241



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org