You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/01/18 05:43:27 UTC

[kudu-CR] [java] throw exception if applying operation on a closed session

Hello Alexey Serbin, Kudu Jenkins, Anonymous Coward (314), Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12237

to look at the new patch set (#4).

Change subject: [java] throw exception if applying operation on a closed session
......................................................................

[java] throw exception if applying operation on a closed session

Closed sessions won't flush on another close() call, so it's somewhat
dubious to apply() an operation to a closed session. This change adds a
precondition that prevents apply() from working if the session has been
closed. There's a new test, and a fix to a non-compliant existing test.

This is a breaking change for clients that relied on the old broken
behavior; they will now throw. Thus I'm not sure we actually want this.

Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
2 files changed, 24 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/12237/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)