You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/04/24 20:22:38 UTC

svn commit: r1471586 - /commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/generic/DispatchLookupCommand.java

Author: sebb
Date: Wed Apr 24 18:22:38 2013
New Revision: 1471586

URL: http://svn.apache.org/r1471586
Log:
Make unboxing explicit.

Modified:
    commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/generic/DispatchLookupCommand.java

Modified: commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/generic/DispatchLookupCommand.java
URL: http://svn.apache.org/viewvc/commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/generic/DispatchLookupCommand.java?rev=1471586&r1=1471585&r2=1471586&view=diff
==============================================================================
--- commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/generic/DispatchLookupCommand.java (original)
+++ commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/generic/DispatchLookupCommand.java Wed Apr 24 18:22:38 2013
@@ -152,7 +152,7 @@ public class DispatchLookupCommand<K, V,
                 Object obj = methodObject.invoke(command, getArguments(context));
 
                 Boolean result = (Boolean) obj;
-                return (result != null && result);
+                return (result != null && result.booleanValue()); // might cause NPE (obj could be null)
             } catch (NoSuchMethodException e) {
                 throw new DispatchException("Error extracting method from context", e, context, this);
             } catch (IllegalAccessException e) {