You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/06 07:56:30 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30276: [SPARK-33333][BUILD][2.4] Upgrade Jetty to 9.4.28.v20200408

dongjoon-hyun commented on a change in pull request #30276:
URL: https://github.com/apache/spark/pull/30276#discussion_r518577972



##########
File path: mllib-local/src/test/scala/org/apache/spark/ml/linalg/MatricesSuite.scala
##########
@@ -862,10 +862,10 @@ class MatricesSuite extends SparkMLFunSuite {
     mat.toString(0, 0)
     mat.toString(Int.MinValue, Int.MinValue)
     mat.toString(Int.MaxValue, Int.MaxValue)
-    var lines = mat.toString(6, 50).lines.toArray
+    var lines = mat.toString(6, 50).split('\n')

Review comment:
       Actually, I added these to fix build failure in the first try failed at https://github.com/apache/spark/pull/30241 . But, it seems that there was something wrong in my local environement at that time. I'll revert this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org