You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/06/15 01:25:16 UTC
[GitHub] incubator-beam pull request #467: Add peekOutputValuesInWindow to DoFnTester
GitHub user tgroh opened a pull request:
https://github.com/apache/incubator-beam/pull/467
Add peekOutputValuesInWindow to DoFnTester
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
This allows a test (especially GroupAlsoByWindowsProperties) to assert
the per-window contents of the DoFn's output.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/incubator-beam peek_windowed_values
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/467.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #467
----
commit 4da5ebfbf021051288620634ec84cafa9208265c
Author: Thomas Groh <tg...@google.com>
Date: 2016-06-14T20:39:59Z
Use TimestampedValue in DoFnTester
This removes the duplicate OutputElementWithTimestamp data structure.
commit 3ffc763a231e4b523f220aa6e05aad5c873cc4c7
Author: Thomas Groh <tg...@google.com>
Date: 2016-06-14T20:18:41Z
Add DoFnTester#peekOutputValuesInWindow
This permits DoFns that interact with windowing to test the windowed,
rather than overall output.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-beam pull request #467: [BEAM-243] Add peekOutputValuesInWindow to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-beam/pull/467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---