You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:30:26 UTC
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #655: test: add linter for manager api
moonming commented on a change in pull request #655:
URL: https://github.com/apache/apisix-dashboard/pull/655#discussion_r515857673
##########
File path: api/conf/conf.go
##########
@@ -36,8 +36,8 @@ const (
EnvDEV = "dev"
EnvLOCAL = "local"
- confPath = "/go/manager-api/conf.json"
- schemaPath = "/go/manager-api/schema.json"
+ confJsonPath = "/go/manager-api/conf.json"
Review comment:
Is this a hard-coded configuration file?
##########
File path: api/conf/conf.go
##########
@@ -36,8 +36,8 @@ const (
EnvDEV = "dev"
EnvLOCAL = "local"
- confPath = "/go/manager-api/conf.json"
- schemaPath = "/go/manager-api/schema.json"
+ confJsonPath = "/go/manager-api/conf.json"
Review comment:
hemm, anyway, we can not hard-coded in code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org