You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "skytin1004 (via GitHub)" <gi...@apache.org> on 2023/06/22 05:58:04 UTC
[GitHub] [iceberg] skytin1004 commented on a diff in pull request #7861: Core: Switch tests to Junit5 in rest, hadoop pakages
skytin1004 commented on code in PR #7861:
URL: https://github.com/apache/iceberg/pull/7861#discussion_r1238029445
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopTables.java:
##########
@@ -55,20 +54,19 @@ public class TestHadoopTables {
required(1, "id", Types.IntegerType.get(), "unique ID"),
required(2, "data", Types.StringType.get()));
- @Rule public TemporaryFolder temp = new TemporaryFolder();
private File tableDir = null;
- @Before
- public void setupTableLocation() throws Exception {
- tableDir = temp.newFolder();
+ @BeforeEach
+ public void setupTableLocation(@TempDir Path temp) throws Exception {
Review Comment:
Thank you for your review. I have now fixed the code based on your review and switched the file to JUnit5. I will review all your reviews and post a commit.
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopTables.java:
##########
@@ -55,20 +54,19 @@ public class TestHadoopTables {
required(1, "id", Types.IntegerType.get(), "unique ID"),
required(2, "data", Types.StringType.get()));
- @Rule public TemporaryFolder temp = new TemporaryFolder();
private File tableDir = null;
- @Before
- public void setupTableLocation() throws Exception {
- tableDir = temp.newFolder();
+ @BeforeEach
+ public void setupTableLocation(@TempDir Path temp) throws Exception {
Review Comment:
Thank you for your review! I have now fixed the code based on your review and switched the file to JUnit5. I will review all your reviews and post a commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org