You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@helix.apache.org by hu...@apache.org on 2019/06/24 18:25:15 UTC
[helix.wiki] branch master updated: Created Pull Request Template
(markdown)
This is an automated email from the ASF dual-hosted git repository.
hulee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/helix.wiki.git
The following commit(s) were added to refs/heads/master by this push:
new b482648 Created Pull Request Template (markdown)
b482648 is described below
commit b482648212bda2081a2a7b61766e28a97a60c172
Author: Hunter Lee <na...@gmail.com>
AuthorDate: Mon Jun 24 11:25:14 2019 -0700
Created Pull Request Template (markdown)
---
Pull-Request-Template.md | 41 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 41 insertions(+)
diff --git a/Pull-Request-Template.md b/Pull-Request-Template.md
new file mode 100644
index 0000000..296e907
--- /dev/null
+++ b/Pull-Request-Template.md
@@ -0,0 +1,41 @@
+### Issues
+
+- [ ] My PR addresses the following Helix issues and references them in the PR title:
+
+(#200 - Link your issue number here)
+
+### Description
+
+- [ ] Here are some details about my PR, including screenshots of any UI changes:
+
+(Write a concise description including what, why, how)
+
+### Tests
+
+- [ ] The following tests are written for this issue:
+
+(List the names of added unit/integration tests)
+
+- [ ] The following is the result of the "mvn test" command on the appropriate module:
+
+(Copy & paste the result of "mvn test")
+
+### Commits
+
+- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
+ 1. Subject is separated from body by a blank line
+ 1. Subject is limited to 50 characters (not including Jira issue reference)
+ 1. Subject does not end with a period
+ 1. Subject uses the imperative mood ("add", not "adding")
+ 1. Body wraps at 72 characters
+ 1. Body explains "what" and "why", not "how"
+
+### Documentation
+
+- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
+
+(Link the GitHub wiki you added)
+
+### Code Quality
+
+- [ ] My diff has been formatted using helix-style.xml
\ No newline at end of file