You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by trixpan <gi...@git.apache.org> on 2017/03/23 01:30:28 UTC
[GitHub] nifi pull request #1614: NIFI-3466 - Addresses ParseCEF Locale related failu...
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1614
NIFI-3466 - Addresses ParseCEF Locale related failures and introduce ability to define Locale of logs
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] ~~~If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?~~~
- [x] ~~~If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?~~~
- [x] ~~~If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?~~~
- [x] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-3466
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1614.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1614
----
commit 4ae2f736f7ddbcf8508acaa27e0cd467eb6d2db7
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Date: 2017-03-22T12:20:18Z
NIFI-3466 - Address non English locales in ParseCEF
commit c0e8391eadc4338d1661bc5ebf5545067997b2f7
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Date: 2017-03-22T22:58:52Z
Update TestParseCEF.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1614: NIFI-3466 - Addresses ParseCEF Locale related failures and...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1614
@pvillard31 @apiri this should hopefully address the Locale related errors affecting ParseCEF.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1614: NIFI-3466 - Addresses ParseCEF Locale related failures and...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1614
also please note there seem to be an unrelated issue affecting another test unit that fails unter pt_BR and fr_FR but passes ja_JP. I suspect it is a comma vs dot number notation issue.
```
-------------------------------------------------------
T E S T S
-------------------------------------------------------
Running org.apache.nifi.schemaregistry.processors.TransformersTest
Tests run: 14, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.518 sec <<< FAILURE! - in org.apache.nifi.schemaregistry.processors.TransformersTest
[5] input_csv/decimal_logicalType.txt,input_avro/decimal_logicalType_valid_scale_with_no_default.txt,expected_ouput_csv/decimal_logicalType.txt (testCSVRoundtrip)(org.apache.nifi.schemaregistry.processors.TransformersTest) Time elapsed: 0.013 sec <<< ERROR!
java.lang.NumberFormatException: null
at java.math.BigDecimal.<init>(BigDecimal.java:494)
at java.math.BigDecimal.<init>(BigDecimal.java:383)
at java.math.BigDecimal.<init>(BigDecimal.java:806)
at org.apache.nifi.schemaregistry.processors.CSVUtils.write(CSVUtils.java:161)
at org.apache.nifi.schemaregistry.processors.TransformersTest.testCSVRoundtrip(TransformersTest.java:149)
[6] input_csv/decimal_logicalType.txt,input_avro/decimal_logicalType_invalid_scale_with_default.txt,expected_ouput_csv/decimal_logicalType_invalid_scale.txt (testCSVRoundtrip)(org.apache.nifi.schemaregistry.processors.TransformersTest) Time elapsed: 0.004 sec <<< ERROR!
java.lang.NumberFormatException: null
at java.math.BigDecimal.<init>(BigDecimal.java:494)
at java.math.BigDecimal.<init>(BigDecimal.java:383)
at java.math.BigDecimal.<init>(BigDecimal.java:806)
at org.apache.nifi.schemaregistry.processors.CSVUtils.write(CSVUtils.java:161)
at org.apache.nifi.schemaregistry.processors.TransformersTest.testCSVRoundtrip(TransformersTest.java:149)
[7] input_csv/decimal_logicalType_missing_value.txt,input_avro/decimal_logicalType_valid_scale_with_default.txt,expected_ouput_csv/decimal_logicalType_valid_scale_with_default.txt (testCSVRoundtrip)(org.apache.nifi.schemaregistry.processors.TransformersTest) Time elapsed: 0.005 sec <<< ERROR!
java.lang.NumberFormatException: null
at java.math.BigDecimal.<init>(BigDecimal.java:494)
at java.math.BigDecimal.<init>(BigDecimal.java:383)
at java.math.BigDecimal.<init>(BigDecimal.java:806)
at org.apache.nifi.schemaregistry.processors.CSVUtils.write(CSVUtils.java:161)
at org.apache.nifi.schemaregistry.processors.TransformersTest.testCSVRoundtrip(TransformersTest.java:149)
Results :
Tests in error:
TransformersTest.testCSVRoundtrip:149 » NumberFormat
TransformersTest.testCSVRoundtrip:149 » NumberFormat
TransformersTest.testCSVRoundtrip:149 » NumberFormat
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1614: NIFI-3466 - Addresses ParseCEF Locale related failu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1614
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1614: NIFI-3466 - Addresses ParseCEF Locale related failures and...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1614
please ignore the last comment regarding the error above, seems to be a rebasing issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1614: NIFI-3466 - Addresses ParseCEF Locale related failures and...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1614
Thanks @trixpan, LGTM, merging to master, thanks for all the efforts you put into locale related build stuff!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1614: NIFI-3466 - Addresses ParseCEF Locale related failu...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1614#discussion_r107602066
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java ---
@@ -146,6 +150,18 @@
.defaultValue(LOCAL_TZ)
.build();
+ public static final PropertyDescriptor DATETIME_REPRESENTATION = new PropertyDescriptor.Builder()
+ .name("DATETIME_REPRESENTATION")
+ .displayName("DateTime Locale")
+ .description("The IETF BCP 47 representation of the Locale to be used when parsing date " +
+ "fields with long or short month names (e.g. may <en-US> vs. mai. <fr-FR>. The default" +
+ "value is generally safe. Only change if having issues parsing CEF messages")
+ .required(true)
+ .addValidator(new ValidateLocale())
+// .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
--- End diff --
to remove?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---