You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/08 03:46:08 UTC
[GitHub] [airflow] potiuk opened a new pull request #12908: Builds prod images on DockerHub from packages
potiuk opened a new pull request #12908:
URL: https://github.com/apache/airflow/pull/12908
This build combines building both CI and PROD image in one
script execution on DockerHub per python version.
First the CI image is build and secondly, the image is used
to build all the packages from sources and then those
packages are used to build the PROD image.
Resulting image will be package image built from latest sources.
Closes: #12261
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12908: Builds prod images on DockerHub from packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12908:
URL: https://github.com/apache/airflow/pull/12908#issuecomment-740564351
Hey @ashb @kaxil -> this one concerns only Dockerhub builds. I tested the builds, but I can always run it manually. I thought it would be get it in before rc1.
I simply applied the 'package-built' image from CI to the DockerHub scripts and I modified the autobuilds in DockerHub.
If all goe well, thanks to that one the prod images will be available automatically 2-3 hours after we push 2.* tag to GitHub (including rc1)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12908: Builds prod images on DockerHub from packages
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12908:
URL: https://github.com/apache/airflow/pull/12908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12908: Builds prod images on DockerHub from packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12908:
URL: https://github.com/apache/airflow/pull/12908#issuecomment-740566236
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #12908: Builds prod images on DockerHub from packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #12908:
URL: https://github.com/apache/airflow/pull/12908#issuecomment-740356308
With this one, DockerHub images will be build automatically after we push 2* tag and they are built using packages (sources -> packages -> installation).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org