You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/26 19:00:27 UTC

[GitHub] [apisix] tashiya-menuri opened a new pull request #2524: bugfux : fixes issue #2505

tashiya-menuri opened a new pull request #2524:
URL: https://github.com/apache/apisix/pull/2524


   ### What this PR does / why we need it:
   Fix for https://github.com/apache/apisix/issues/2505
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tashiya-menuri commented on pull request #2524: CI : yaml style

Posted by GitBox <gi...@apache.org>.
tashiya-menuri commented on pull request #2524:
URL: https://github.com/apache/apisix/pull/2524#issuecomment-718778229


   @membphis @juzhiyuan @spacewander Can you please check now?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] membphis commented on pull request #2524: CI : yaml style

Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2524:
URL: https://github.com/apache/apisix/pull/2524#issuecomment-718754023


   @tashiya-menuri please rebase your branch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] tashiya-menuri commented on a change in pull request #2524: CI : yaml style

Posted by GitBox <gi...@apache.org>.
tashiya-menuri commented on a change in pull request #2524:
URL: https://github.com/apache/apisix/pull/2524#discussion_r514288509



##########
File path: .github/workflows/build.yml
##########
@@ -12,7 +12,12 @@ jobs:
       fail-fast: false
       matrix:
         platform: [ubuntu-18.04]
-        os_name: [linux_openresty, linux_tengine, linux_apisix_master_luarocks, linux_apisix_current_luarocks, linux_openresty_mtls]
+        os_name:

Review comment:
       +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander merged pull request #2524: CI : yaml style

Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #2524:
URL: https://github.com/apache/apisix/pull/2524


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2524: CI : yaml style

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2524:
URL: https://github.com/apache/apisix/pull/2524#discussion_r513843881



##########
File path: .github/workflows/build.yml
##########
@@ -12,7 +12,12 @@ jobs:
       fail-fast: false
       matrix:
         platform: [ubuntu-18.04]
-        os_name: [linux_openresty, linux_tengine, linux_apisix_master_luarocks, linux_apisix_current_luarocks, linux_openresty_mtls]
+        os_name:

Review comment:
       Then we may need to update the platform field, too.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org