[GitHub] [drill] KazydubB commented on a change in pull request #1930: DRILL-7487: Removes the unused OUT_OF_MEMORY iterator status

[GitBox <gi...@apache.org>]

KazydubB commented on a change in pull request #1930: DRILL-7487: Removes the unused OUT_OF_MEMORY iterator status
URL: https://github.com/apache/drill/pull/1930#discussion_r361159985
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatch.java
 ##########
 @@ -194,19 +194,9 @@
      */
     NOT_YET(false),
 
-    /**
-     * Out of memory (not fatal).
-     * <p>
-     *   The call to {@link #next()},
-     *   including upstream operators, was unable to allocate memory
-     *   and did not read any records,
-     *   and the batch will have more results to return (at least completion or
-     *     abnormal termination ({@code NONE} or {@code STOP})).
-     *   The caller should release memory if it can (including by returning
-     *     {@code OUT_OF_MEMORY} to its caller) and call {@code next()} again.
-     * </p>
-     */
-    OUT_OF_MEMORY(true),
+    // Note: the former OUT_OF_MEMORY state was never really used.
 
 Review comment:
   Maybe it is better to move this comment (on this and the following 2 lines) into `enum IterOutcome`'s javadoc?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services