You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/22 08:34:05 UTC
[GitHub] [cordova-docs] sajt opened a new pull request #1079: A little change based on the system.
sajt opened a new pull request #1079:
URL: https://github.com/apache/cordova-docs/pull/1079
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek commented on issue #1079: A little change based on the system.
Posted by GitBox <gi...@apache.org>.
breautek commented on issue #1079:
URL: https://github.com/apache/cordova-docs/pull/1079#issuecomment-617763663
I approve but without the explicit green check because I think only the files inside `/dev/` is suppose to be modified. I'm pretty sure the other versioned files are suppose to be generated by a release script.
Another member will confirm or correct me if I'm wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek commented on pull request #1079: A little change based on the system.
Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1079:
URL: https://github.com/apache/cordova-docs/pull/1079#issuecomment-635036998
Thank you kindly for your contribution :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] erisu edited a comment on issue #1079: A little change based on the system.
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on issue #1079:
URL: https://github.com/apache/cordova-docs/pull/1079#issuecomment-617773612
@breautek There is a script that can be used to update the current latest docs (9.x) from dev, but it will pull all of dev docs into 9.x.
```gulp snapshot```
If 10.x documentation is already pushed into dev, running the `snapshot` command would be a bad idea.
It might be OK to accept the direct change to 9.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek edited a comment on issue #1079: A little change based on the system.
Posted by GitBox <gi...@apache.org>.
breautek edited a comment on issue #1079:
URL: https://github.com/apache/cordova-docs/pull/1079#issuecomment-617763663
I approve but without the explicit green check because I think only the files inside `/dev/` is suppose to be modified. I'm pretty sure the other versioned files are suppose to be generated by a release script.
Also, if you could fill out the PR details, it will help us if we ever need to refer back to this PR in the future, thanks.
Another member will confirm or correct me if I'm wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] erisu commented on issue #1079: A little change based on the system.
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #1079:
URL: https://github.com/apache/cordova-docs/pull/1079#issuecomment-617773612
@breautek There is a script that can be used to update the current latest docs (9.x) from dev, but it will pull all of dev docs into 9.x.
```gulp snapshot```
If 10.x documentation is already pushed into dev, running the `snapshot` command might not be useful.
It might be OK to accept the direct change to 9.x.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-docs] breautek merged pull request #1079: A little change based on the system.
Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1079:
URL: https://github.com/apache/cordova-docs/pull/1079
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org