[GitHub] [nifi] moranr edited a comment on issue #3351: NIFI-2933 Remote input/output ports at any PG

[GitBox <gi...@apache.org>]

moranr edited a comment on issue #3351: NIFI-2933 Remote input/output ports at any PG
URL: https://github.com/apache/nifi/pull/3351#issuecomment-477731103
 
 
   @andrewmlim and I reviewed and would like recommend the following changes.
   
   **For the Process Group canvas component**
   Include a count of remote process groups to the In/Out stat lines. Being able to distinguish local from remote at this level can be useful. It also helps provide a some clarity when trying to connect to a group and seeing the _no local ports_ message. Here is an example showing the additional remote port count:
   ![Screen Shot 2019-03-28 at 1 09 49 PM](https://user-images.githubusercontent.com/14202495/55184253-11e24180-5168-11e9-950d-d6af86ff5105.png)
   
   **For the Add (input) Port dialog**
   ![Screen Shot 2019-03-28 at 1 17 40 PM](https://user-images.githubusercontent.com/14202495/55184403-68e81680-5168-11e9-82f9-52ca7e2b065b.png)
   Change dialog title to:
   > Add Input Port
   
   Change "Receive Data From" label to:
   > Receive From
   
   Change "Receive From" label tooltip to:
   > Specify where FlowFiles are received from
   
   Change "Local connections" menu option tooltip to:
   > Receive FlowFiles from components in parent process groups
   
   Change "Site-to-Site connections" menu option to:
   > Remote connections (site-to-site)
   
   Change "Remote connections (site-to-site)" menu option tooltip to:
   > Receive FlowFiles from remote process group (site-to-site)
   
   **For the Add (output) Port dialog**
   ![Screen Shot 2019-03-28 at 1 27 26 PM](https://user-images.githubusercontent.com/14202495/55184575-e3b13180-5168-11e9-9276-6eb431349c3f.png)
   Change dialog title to:
   > Add Output Port
   
   Change "Transfer Data To" label to:
   > Send To
   
   Change "Send To" label tooltip to:
   > Specify where FlowFiles are sent
   
   Change "Local connections" menu option tooltip to:
   > Send FlowFiles to components in parent process groups
   
   Change "Site-to-Site connections" menu option to:
   > Remote connections (site-to-site)
   
   Change "Remote connections (site-to-site)" menu option tooltip to:
   > Send FlowFiles to remote process group (site-to-site)
   
   **For the no name error dialog**
   ![blank_name](https://user-images.githubusercontent.com/14202495/55184854-8ec1eb00-5169-11e9-99fa-7a1ea60229d3.png)
   
   Change dialog title to:
   > Configuration Error
   
   Change dialog message to:
   > The port name must be specified.
   
   The error dialog should open on top of the Add Port dialog. Clicking OK should take the user back to the Add Port dialog. The current implementation of the Add Remote Process Group dialog work this way (screenshot below).
   ![Screen Shot 2019-03-28 at 1 53 37 PM](https://user-images.githubusercontent.com/14202495/55185071-fb3cea00-5169-11e9-8209-bff93de87a81.png)
   
   **For the duplicate name error dialog**
   ![Screen Shot 2019-03-28 at 2 00 10 PM](https://user-images.githubusercontent.com/14202495/55185289-64bcf880-516a-11e9-8a72-31d8e246706f.png)
   
   Change dialog title to:
   > Configuration Error
   
   Change dialog message to:
   > The port name must be unique throughout the flow.
   
   Dialog behavior should be the same as described in the previous example (no name error dialog).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services