You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/04/11 03:31:29 UTC

[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #2716: [HUDI-1718] when query incr view of mor table which has Multi level partitions, the query failed

xiarixiaoyao commented on a change in pull request #2716:
URL: https://github.com/apache/hudi/pull/2716#discussion_r611124392



##########
File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/hive/HoodieCombineHiveInputFormat.java
##########
@@ -170,7 +170,7 @@ protected HoodieCombineFileInputFormatShim createInputFormatShim() {
         if (job.get(hive_metastoreConstants.META_TABLE_PARTITION_COLUMNS, "").isEmpty()) {
           List<String> partitions = new ArrayList<>(part.getPartSpec().keySet());
           if (!partitions.isEmpty()) {
-            String partitionStr = String.join(",", partitions);

Review comment:
       @garyli1019 , I checked previous versions of Hive, they all use slash for split.  this pr is inspired by HUDI-314, but i think that pr does not consider mor increamtal query.    In fact, this bug only occurs when you use HoodieCombineHiveInputFormat  to query mor table.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org