You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/05/08 06:24:49 UTC

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2085: Fallback to use v3 protocol for some types of requests if they are not implemented in v2

eolivelli commented on a change in pull request #2085: Fallback to use v3 protocol for some types of requests if they are not implemented in v2
URL: https://github.com/apache/bookkeeper/pull/2085#discussion_r281927902
 
 

 ##########
 File path: tests/integration-tests-topologies/src/main/java/org/apache/bookkeeper/tests/containers/BKStandaloneContainer.java
 ##########
 @@ -31,7 +31,7 @@
 @Slf4j
 public class BKStandaloneContainer<SelfT extends BKStandaloneContainer<SelfT>> extends ChaosContainer<SelfT> {
 
-    private static final int ZK_PORT = 2181;
+    public static final int ZK_PORT = 2181;
 
 Review comment:
   Why are you making this variable 'public'?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services