[GitHub] [incubator-nuttx] patacongo commented on pull request #1233: [DRAFT] Add support to CDC-MBIM USB host driver

[GitBox <gi...@apache.org>]

patacongo commented on pull request #1233:
URL: https://github.com/apache/incubator-nuttx/pull/1233#issuecomment-643806641


   > 
   > 
   > Hi Alan, Greg, and team.
   > 
   > I'm okay with the license change.
   > 
   > A few things about this code:
   > 
   >     1. It's old
   > 
   >     2. It's incomplete
   > 
   >     3. It's probably quite buggy
   > 
   >     4. It needs a lot of work
   > 
   > 
   > It does actually work though, so it has that going for it.
   > 
   > The driver itself is mostly useless without a corresponding user app to send the MBIM commands. However writing this type of program is very simple and the MBIM specification is fully open.
   > 
   > I do not have access to any hardware that would allow me to test and/or continue developing this code. I hope that someone somewhere finds it useful.
   
   Thanks for the permission with the naming change.  Perhaps we could mark it experimental.  however, I do think that:
   
   1. The implementation should be complete.  There are a few critical pieces missing, especially those that would permit ifconfig to work.
   2. We need to have a configuration that we can use to at least verify that it still compiles.  Do you have a defconfig that we could use for testing.
   
   This those things address (and the additional items from the comments), I think that we could provisionally merge the code.  I would approve the merge under those conditions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org