[GitHub] hequn8128 commented on a change in pull request #6987: [FLINK-8897] [table] Fix rowtime materialization issues for filters and joins

[GitBox <gi...@apache.org>]

hequn8128 commented on a change in pull request #6987: [FLINK-8897] [table] Fix rowtime materialization issues for filters and joins
URL: https://github.com/apache/flink/pull/6987#discussion_r230626371
 
 

 ##########
 File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/stream/sql/validation/JoinValidationTest.scala
 ##########
 @@ -30,18 +30,6 @@ class JoinValidationTest extends TableTestBase {
   streamUtil.addTable[(Int, String, Long)]("MyTable", 'a, 'b, 'c.rowtime, 'proctime.proctime)
   streamUtil.addTable[(Int, String, Long)]("MyTable2", 'a, 'b, 'c.rowtime, 'proctime.proctime)
 
-  /** There should exist exactly two time conditions **/
 
 Review comment:
   Hi, `DataStreamJoinRule` would match this case after we materialize time indicators in the join condition.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services