Re: svn commit: r902716 [1/2] - in /ofbiz/trunk: framework/images/webapp/images/rate/ specialpurpose/ebay/ specialpurpose/ebay/config/ specialpurpose/ebay/data/ specialpurpose/ebay/data/helpdata/ specialpurpose/ebay/servicedef/ specialpurpose/ebay/src/org/

[Jacques Le Roux <ja...@les7arts.com>]

I can't disagree. It's good to see more things in OFBiz, having them in a better state should certainly be researched. I'm confident 
in Hans to tackle this with time, we have already seen clear progresses.
But please Hans, even if it's the same work for review, break these big patches in smaller pieces. If we need to revert something it 
will be much easier, thanks.

My 2cts

Jacques

From: "Tim Ruppert" <ti...@hotwaxmedia.com>
Not trying to - but sorry for the tone if it came across that way Hans.  I'm simply asking why it gets past the committer's desk as 
"I'm trying to get my people to provide smaller pieces" is an ok way of committing code.  Isn't that the responsibility of the 
committer to tell the person that's providing the code to go back to the drawing board and break it up?  Isn't that our job as 
committers?  And as the rest of the committers, isn't it our job to remind the offending committer to spend more time with the 
person who's providing the code so that we don't have to dig thru this much mess?

It's not always easy for any of us, but I just don't see this from other people, so I wanted to remind Hans.  If all the other 
committers think this is ok (which obviously they didn't since Adam brought it up), then I'll happily back off.  Since that's not 
the case - and this obviously doesn't follow the best practices of the project - please let me know how I should encourage Hans to 
do what is clearly in our best practices.

What should be done is that this mess of a commit should be reverted and put back in in pieces - you have to start somewhere and 
sometimes it's just not good enough when you have an entire community to just say you're trying hard.  My two cents.

Cheers,
Ruppert
--
Tim Ruppert
HotWax Media
http://www.hotwaxmedia.com

o:801.649.6594
f:801.649.6595

On Jan 25, 2010, at 8:47 PM, David E Jones wrote:

>
> This seems to be a little bit condescending. Trying to pick another fight?
>
> I'm just glad to have ring-side seats... ;)
>
> -David
>
>
> On Jan 25, 2010, at 9:39 PM, Tim Ruppert wrote:
>
>> As the committer, you can just not put them into OFBiz until they are of better quality Hans - that is your obligation and 
>> something that the rest of us abide to.  Please do better in the future - we know you're trying - but just because you've 
>> received it doesn't mean you have to commit it - you can just wait until it's in good enough shape to commit it ...
>>
>> Cheers,
>> Ruppert
>> --
>> Tim Ruppert
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> o:801.649.6594
>> f:801.649.6595
>>
>> On Jan 25, 2010, at 4:28 PM, Hans Bakker wrote:
>>
>>> Hi Adam,
>>>
>>> comment accepted, i am trying to get my people to provide stuff in
>>> smaller pieces. Not always easy but we try to do better.
>>>
>>> Regards,
>>> hans
>>>
>>> On Mon, 2010-01-25 at 12:28 -0600, Adam Heath wrote:
>>>> hansbak@apache.org wrote:
>>>>> Author: hansbak
>>>>> Date: Mon Jan 25 06:26:23 2010
>>>>> New Revision: 902716
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=902716&view=rev
>>>>> Log:
>>>>>
>>>>> function leave feedback and screen
>>>>> - function auto relist item and screen
>>>>> - Get  feedback data from ebay site and save into ofbiz.
>>>>> - Add rate pictures into framework/images/webapp/images
>>>>> - screen for show awaiting feedback and recent feedback from buyer
>>>>> - help screens are provided
>>>>
>>>> this was a bad commit, too many things done at once.  Please try to be
>>>> considerate of long-term maintainability, having small commits makes
>>>> it easier to verify and debug.
>>> -- 
>>> Antwebsystems.com: Quality OFBiz services for competitive rates
>>>
>>
>