You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/01/17 09:03:03 UTC

[kudu-CR] [rpc] don't issue authn tokens over non-confidential connections

Hello Dan Burkert, Kudu Jenkins, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/9025

to look at the new patch set (#2).

Change subject: [rpc] don't issue authn tokens over non-confidential connections
......................................................................

[rpc] don't issue authn tokens over non-confidential connections

With this patch, master will not issue authn tokens over a
non-confidential connection.  The 'confidentiality' property is set
based on the negotiated connection and stored into the RpcContext
object, accessible via the RpcContext::is_confidential() method.

WIP: need to clarify why a couple of test scenarios fail.

Change-Id: Ie31aa492bcc460dbd43975bccfe571354f3bf885
---
M src/kudu/integration-tests/security-itest.cc
M src/kudu/master/master_service.cc
M src/kudu/rpc/connection.cc
M src/kudu/rpc/connection.h
M src/kudu/rpc/negotiation.cc
M src/kudu/rpc/rpc_context.cc
M src/kudu/rpc/rpc_context.h
7 files changed, 111 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/9025/2
-- 
To view, visit http://gerrit.cloudera.org:8080/9025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie31aa492bcc460dbd43975bccfe571354f3bf885
Gerrit-Change-Number: 9025
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>