You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/09/18 12:01:06 UTC
[PR] CAMEL-24809: camel-kamelet-main - Artemis, Yasson and univocity-parsers under their current group ids [camel]
davsclaus opened a new pull request, #26595:
URL: https://github.com/apache/camel/pull/26595
Follow-up to #26575. Three third-party libraries publish under a new group id, and the mapping still named the old one:
- Artemis is `org.apache.artemis` since 2.50; the `org.apache.activemq` coordinates are relocation poms.
- Yasson is `org.eclipse.yasson` (relocation from `org.eclipse`).
- The univocity-parsers 2.10.2 that camel-univocity-parsers uses is the `com.sonofab1rd` fork; `com.univocity` stops at 2.9.1.
Maven follows a relocation when it resolves a dependency, so `camel run` was not broken, but the mapping and the jar verification should name the real coordinates. The note in #26575 that these three versions "have no jar on Maven Central" was wrong: they had moved. With this change `-Dcamel.known-dependencies.verify=true` verifies all 146 packages against their jars.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01Bp3538HRBPMQkb5ta9xRaj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24809: camel-kamelet-main - Artemis, Yasson and univocity-parsers under their current group ids [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26595:
URL: https://github.com/apache/camel/pull/26595#issuecomment-5730020454
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-kamelet-main`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 7 tested, 9 compile-only — current: 6 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **16 affected modules** (current approach: 6).
<details><summary>:warning: Modules only in Scalpel (10)</summary>
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `coverage`
</details>
**Skip-tests mode would test 7 modules** (1 direct + 6 downstream), **skip tests for 9** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (7)</summary>
- `camel-jbang-mcp`
- `camel-jbang-plugin-mcp`
- `camel-jbang-plugin-route-parser`
- `camel-jbang-plugin-tui`
- `camel-jbang-plugin-validate`
- `camel-kamelet-main`
- `camel-launcher-container`
</details>
<details><summary>Modules with tests skipped (9)</summary>
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-launcher`
- `coverage`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (16 modules, 3m 36s total)</summary>
**Total reactor time:** 3m 36s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: JBang :: Plugin :: TUI | 54.9s | SUCCESS |
| Camel :: Launcher | 51.6s | SUCCESS |
| Camel :: JBang :: MCP | 40.7s | SUCCESS |
| Camel :: JBang :: Plugin :: Kubernetes | 23.6s | SUCCESS |
| Camel :: Kamelet Main | 12.3s | SUCCESS |
| Camel :: JBang :: Plugin :: Testing | 11.2s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 7.8s | SUCCESS |
| Camel :: Coverage | 4.8s | SUCCESS |
| Camel :: JBang :: Plugin :: Edit | 1.8s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 1.7s | SUCCESS |
| Camel :: JBang :: Plugin :: Generate | 1.5s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 1.0s | SUCCESS |
| Camel :: JBang :: Integration tests | 0.9s | SUCCESS |
| Camel :: JBang :: Main | 0.9s | SUCCESS |
| Camel :: Launcher :: Container | 0.9s | SUCCESS |
| Camel :: JBang :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: JBang :: Plugin :: TUI` (54.9s)
- `Camel :: Launcher` (51.6s)
- `Camel :: JBang :: MCP` (40.7s)
- `Camel :: JBang :: Plugin :: Kubernetes` (23.6s)
- `Camel :: Kamelet Main` (12.3s)
- `Camel :: JBang :: Plugin :: Testing` (11.2s)
- `Camel :: JBang :: Plugin :: Validate` (7.8s)
- `Camel :: Coverage` (4.8s)
- `Camel :: JBang :: Plugin :: Edit` (1.8s)
- `Camel :: JBang :: Plugin :: MCP` (1.7s)
- `Camel :: JBang :: Plugin :: Generate` (1.5s)
- `Camel :: JBang :: Plugin :: Route Parser` (1.0s)
- `Camel :: JBang :: Integration tests` (0.9s)
- `Camel :: JBang :: Main` (0.9s)
- `Camel :: Launcher :: Container` (0.9s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/35342484120)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24809: camel-kamelet-main - Artemis, Yasson and univocity-parsers under their current group ids [camel]
Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.
gnodet-bot commented on code in PR #26595:
URL: https://github.com/apache/camel/pull/26595#discussion_r4046605979
##########
dsl/camel-kamelet-main/src/main/known-third-party-libraries.properties:
##########
@@ -145,10 +146,10 @@ com.fasterxml.jackson.dataformat.yaml = com.fasterxml.jackson.dataformat:jackson
com.fasterxml.jackson.dataformat.csv = com.fasterxml.jackson.dataformat:jackson-dataformat-csv:${jackson2-version}
com.google.gson = com.google.code.gson:gson:${gson-version}
com.alibaba.fastjson = com.alibaba:fastjson:${fastjson-version}
-org.eclipse.yasson = org.eclipse:yasson:${yasson-version}
+org.eclipse.yasson = org.eclipse.yasson:yasson:${yasson-version}
Review Comment:
⚠️ **Wrong group ID for Yasson.** `org.eclipse.yasson:yasson` does **not** exist on Maven Central — `numFound: 0` from the search API. The correct published coordinates are `org.eclipse:yasson` (latest 3.0.4), exactly what was there before.
Confirmed:
- `org.eclipse:yasson:3.0.4` → 200 OK, real JAR on Central
- `org.eclipse.yasson:yasson:3.0.5` → 200 OK, also real JAR — **wait, this one does exist** (it's a new groupId that appeared in 3.0.5). But `org.eclipse:yasson:3.0.5` is a relocation POM with `<packaging>pom</packaging>` pointing to `org.eclipse.yasson:yasson`, meaning the old coord is now pom-only and the real artifact moved.
So the mapping is actually correct for 3.0.5+, **but it breaks for 3.0.4 and earlier** since `org.eclipse.yasson:yasson` didn't exist before 3.0.5. The `${yasson-version}` in camel parent is currently `3.0.5`, so at this exact version it works. However:
1. The comment in the PR body says the old coord was a relocation — that's only true from 3.0.5 onward. For 3.0.4 (and camel-4.x branches still on 3.0.4), this mapping would resolve to a groupId that doesn't exist for that version.
2. No comment in the properties file explains this version-dependency.
Consider adding a comment like:
```suggestion
# org.eclipse.yasson:yasson is the real groupId since 3.0.5; org.eclipse:yasson is a relocation pom from that version on.
org.eclipse.yasson = org.eclipse.yasson:yasson:${yasson-version}
```
##########
dsl/camel-kamelet-main/src/test/java/org/apache/camel/main/download/KnownDependenciesResolverTest.java:
##########
@@ -66,7 +66,7 @@ void theShippedMappingResolvesThirdPartyClassesByPackage() {
assertGav(resolver, "org.postgresql.ds.PGConnectionPoolDataSource", "org.postgresql", "postgresql");
assertGav(resolver, "org.h2.jdbcx.JdbcDataSource", "com.h2database", "h2");
assertGav(resolver, "com.zaxxer.hikari.HikariConfig", "com.zaxxer", "HikariCP");
- assertGav(resolver, "org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory", "org.apache.activemq",
+ assertGav(resolver, "org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory", "org.apache.artemis",
"artemis-jakarta-client-all");
Review Comment:
⚠️ **Missing test assertions for the yasson and univocity groupId changes.** This PR changes two more groupIds in the properties file (`org.eclipse.yasson` and `com.sonofab1rd`) but the test only covers the Artemis change. If those mappings are silently wrong, the test won't catch it.
Add assertions after line 70:
```suggestion
"artemis-jakarta-client-all");
assertGav(resolver, "org.eclipse.yasson.internal.Unmarshaller", "org.eclipse.yasson", "yasson");
assertGav(resolver, "com.univocity.parsers.csv.CsvParser", "com.sonofab1rd", "univocity-parsers");
```
(Use any real class from those JARs — these are illustrative but the class names are plausible. Pick actual class names from the JARs if these don't compile.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24809: camel-kamelet-main - Artemis, Yasson and univocity-parsers under their current group ids [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #26595:
URL: https://github.com/apache/camel/pull/26595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24809: camel-kamelet-main - Artemis, Yasson and univocity-parsers under their current group ids [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26595:
URL: https://github.com/apache/camel/pull/26595#issuecomment-5729689714
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-24809: camel-kamelet-main - Artemis, Yasson and univocity-parsers under their current group ids [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #26595:
URL: https://github.com/apache/camel/pull/26595#discussion_r4046994037
##########
dsl/camel-kamelet-main/src/main/known-third-party-libraries.properties:
##########
@@ -145,10 +146,10 @@ com.fasterxml.jackson.dataformat.yaml = com.fasterxml.jackson.dataformat:jackson
com.fasterxml.jackson.dataformat.csv = com.fasterxml.jackson.dataformat:jackson-dataformat-csv:${jackson2-version}
com.google.gson = com.google.code.gson:gson:${gson-version}
com.alibaba.fastjson = com.alibaba:fastjson:${fastjson-version}
-org.eclipse.yasson = org.eclipse:yasson:${yasson-version}
+org.eclipse.yasson = org.eclipse.yasson:yasson:${yasson-version}
Review Comment:
Applied in fc316ad56e6a as a comment on the line: the org.eclipse.yasson group id exists from 3.0.5 on, and a branch on 3.0.4 or earlier needs org.eclipse:yasson. main is on 3.0.5, so the mapping resolves here; the note is for whoever backports.
##########
dsl/camel-kamelet-main/src/test/java/org/apache/camel/main/download/KnownDependenciesResolverTest.java:
##########
@@ -66,7 +66,7 @@ void theShippedMappingResolvesThirdPartyClassesByPackage() {
assertGav(resolver, "org.postgresql.ds.PGConnectionPoolDataSource", "org.postgresql", "postgresql");
assertGav(resolver, "org.h2.jdbcx.JdbcDataSource", "com.h2database", "h2");
assertGav(resolver, "com.zaxxer.hikari.HikariConfig", "com.zaxxer", "HikariCP");
- assertGav(resolver, "org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory", "org.apache.activemq",
+ assertGav(resolver, "org.apache.activemq.artemis.jms.client.ActiveMQConnectionFactory", "org.apache.artemis",
"artemis-jakarta-client-all");
Review Comment:
Applied in fc316ad56e6a: the test now also pins org.eclipse.yasson.internal.Unmarshaller to org.eclipse.yasson:yasson and com.univocity.parsers.csv.CsvParser to com.sonofab1rd:univocity-parsers (the lookup matches by package, so the assertions hold for any class in those packages).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org