You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/05 15:01:35 UTC

[GitHub] [arrow] lidavidm opened a new pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

lidavidm opened a new pull request #11625:
URL: https://github.com/apache/arrow/pull/11625


   Instead of DCHECK, return a NotImplemented.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586


   Benchmark runs are scheduled for baseline = ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender = 412da89146f2366925abda86d34c49d25a78b294. 412da89146f2366925abda86d34c49d25a78b294 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f5bc0092827c4ea8924036fcdb68efff...5882e233d59a418d87f0ea9460bdac21/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3a5d9c0243c3467fb0ef164191bde713...ab90b9f9f5664abab06797612e19610e/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/35cf5856db3a437d9537bc545c24e835...3f5957846cf84b54a67f684455483030/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586


   Benchmark runs are scheduled for baseline = ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender = 412da89146f2366925abda86d34c49d25a78b294. 412da89146f2366925abda86d34c49d25a78b294 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f5bc0092827c4ea8924036fcdb68efff...5882e233d59a418d87f0ea9460bdac21/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3a5d9c0243c3467fb0ef164191bde713...ab90b9f9f5664abab06797612e19610e/)
   [Finished :arrow_down:0.76% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/35cf5856db3a437d9537bc545c24e835...3f5957846cf84b54a67f684455483030/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm closed pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #11625:
URL: https://github.com/apache/arrow/pull/11625


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586


   Benchmark runs are scheduled for baseline = ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender = 412da89146f2366925abda86d34c49d25a78b294. 412da89146f2366925abda86d34c49d25a78b294 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f5bc0092827c4ea8924036fcdb68efff...5882e233d59a418d87f0ea9460bdac21/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3a5d9c0243c3467fb0ef164191bde713...ab90b9f9f5664abab06797612e19610e/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/35cf5856db3a437d9537bc545c24e835...3f5957846cf84b54a67f684455483030/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-961966594






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-961966594






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-961967175


   CC @michalursa. Note that the KeyColumnMetadata computed here is unused, but computing it here serves as a useful up-front check as otherwise we run into a DCHECK later during plan execution instead, so I opted to keep it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-961966594






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-962174851






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-962454586


   Benchmark runs are scheduled for baseline = ae808e0fabc3698d8a84b3e542c9470c95d1af16 and contender = 412da89146f2366925abda86d34c49d25a78b294. 412da89146f2366925abda86d34c49d25a78b294 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/f5bc0092827c4ea8924036fcdb68efff...5882e233d59a418d87f0ea9460bdac21/)
   [Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/3a5d9c0243c3467fb0ef164191bde713...ab90b9f9f5664abab06797612e19610e/)
   [Finished :arrow_down:0.76% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/35cf5856db3a437d9537bc545c24e835...3f5957846cf84b54a67f684455483030/)
   Supported benchmarks:
   ursa-i9-9960x: langs = Python, R, JavaScript
   ursa-thinkcentre-m75q: langs = C++, Java
   ec2-t3-xlarge-us-east-2: cloud = True
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-961967175


   CC @michalursa. Note that the KeyColumnMetadata computed here is unused, but computing it here serves as a useful up-front check as otherwise we run into a DCHECK later during plan execution instead, so I opted to keep it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm edited a comment on pull request #11625: ARROW-14519: [C++] Properly error if joining on unsupported type

Posted by GitBox <gi...@apache.org>.
lidavidm edited a comment on pull request #11625:
URL: https://github.com/apache/arrow/pull/11625#issuecomment-962175013


   ~Also includes a fix for the build issues at HEAD.~ see #11627


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org