You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Antonio Petrelli (JIRA)" <ji...@apache.org> on 2006/09/13 13:04:31 UTC
[jira] Created: (SB-45) Page composition code should reside outside
JSP tag libraries
Page composition code should reside outside JSP tag libraries
-------------------------------------------------------------
Key: SB-45
URL: http://issues.apache.org/struts/browse/SB-45
Project: Sandbox
Issue Type: Improvement
Components: Tiles
Affects Versions: 2.0
Environment: Any
Reporter: Antonio Petrelli
Currently the code that compose pages in Tiles resides almost completely in tag libraries, especially in InsertTag.
I think that this code should reside outside of JSP tag libraries, so that it could be reused by other view technologies.
Reviewing the code, the dependency to JSP-specific features is not "real", because almost every attribute is stored in request scope and the output is generated using "pageContext.getOut", that could be easily generalized to non-JSP writer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SB-45) Page composition code should reside outside
JSP tag libraries
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-45?page=all ]
Antonio Petrelli updated SB-45:
-------------------------------
Priority: Minor (was: Major)
Wrong priority, sorry :-)
> Page composition code should reside outside JSP tag libraries
> -------------------------------------------------------------
>
> Key: SB-45
> URL: http://issues.apache.org/struts/browse/SB-45
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: Any
> Reporter: Antonio Petrelli
> Priority: Minor
>
> Currently the code that compose pages in Tiles resides almost completely in tag libraries, especially in InsertTag.
> I think that this code should reside outside of JSP tag libraries, so that it could be reused by other view technologies.
> Reviewing the code, the dependency to JSP-specific features is not "real", because almost every attribute is stored in request scope and the output is generated using "pageContext.getOut", that could be easily generalized to non-JSP writer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (SB-45) Page composition code should reside
outside JSP tag libraries
Posted by Antonio Petrelli <ap...@apache.org>.
David H. DeWolf (JIRA) ha scritto:
> [ http://issues.apache.org/struts/browse/SB-45?page=comments#action_38554 ]
>
> David H. DeWolf commented on SB-45:
> -----------------------------------
>
> I think that the container fixed this. Antonio, do you agree?
>
Definitely yes :-)
Ciao
Antonio
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[jira] Commented: (SB-45) Page composition code should reside
outside JSP tag libraries
Posted by "David H. DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-45?page=comments#action_38554 ]
David H. DeWolf commented on SB-45:
-----------------------------------
I think that the container fixed this. Antonio, do you agree?
> Page composition code should reside outside JSP tag libraries
> -------------------------------------------------------------
>
> Key: SB-45
> URL: http://issues.apache.org/struts/browse/SB-45
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: Any
> Reporter: Antonio Petrelli
> Priority: Minor
>
> Currently the code that compose pages in Tiles resides almost completely in tag libraries, especially in InsertTag.
> I think that this code should reside outside of JSP tag libraries, so that it could be reused by other view technologies.
> Reviewing the code, the dependency to JSP-specific features is not "real", because almost every attribute is stored in request scope and the output is generated using "pageContext.getOut", that could be easily generalized to non-JSP writer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (SB-45) Page composition code should reside
outside JSP tag libraries
Posted by "David H. DeWolf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/struts/browse/SB-45?page=all ]
David H. DeWolf resolved SB-45.
-------------------------------
Fix Version/s: 2.0
Resolution: Fixed
If it wasn't done with the first iteration, it is now. The tags are very thin now and all logic resides within the container.
> Page composition code should reside outside JSP tag libraries
> -------------------------------------------------------------
>
> Key: SB-45
> URL: http://issues.apache.org/struts/browse/SB-45
> Project: Sandbox
> Issue Type: Improvement
> Components: Tiles
> Affects Versions: 2.0
> Environment: Any
> Reporter: Antonio Petrelli
> Priority: Minor
> Fix For: 2.0
>
>
> Currently the code that compose pages in Tiles resides almost completely in tag libraries, especially in InsertTag.
> I think that this code should reside outside of JSP tag libraries, so that it could be reused by other view technologies.
> Reviewing the code, the dependency to JSP-specific features is not "real", because almost every attribute is stored in request scope and the output is generated using "pageContext.getOut", that could be easily generalized to non-JSP writer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira