You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/16 21:04:57 UTC
[GitHub] codecov-io commented on issue #5020: Make port number optional in
superset for druid
codecov-io commented on issue #5020: Make port number optional in superset for druid
URL: https://github.com/apache/incubator-superset/pull/5020#issuecomment-389665315
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr&el=h1) Report
> Merging [#5020](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/e72c9cded37f7e1b6eaf3c5192249f5d08ce5ce4?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5020 +/- ##
==========================================
- Coverage 77.34% 77.33% -0.01%
==========================================
Files 44 44
Lines 8664 8667 +3
==========================================
+ Hits 6701 6703 +2
- Misses 1963 1964 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5020/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.44% <75%> (-0.06%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr&el=footer). Last update [e72c9cd...d3f2a12](https://codecov.io/gh/apache/incubator-superset/pull/5020?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org