You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/09/02 21:31:53 UTC
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 7:31 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Sept. 14, 2015, 12:37 a.m., Qian Zhang wrote:
> > src/master/master.cpp, lines 4131-4134
> > <https://reviews.apache.org/r/37175/diff/7/?file=1071163#file1071163line4131>
> >
> > I think we have done this in Master::Http::maintenanceSchedule(), so why we do it again here? Maybe remove the duplicated code from Master::Http::maintenanceSchedule()?
You are right! Thanks for catching this :-)
Fixed in updated review.
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review98790
-----------------------------------------------------------
On Sept. 14, 2015, 12:46 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 12:46 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review98790
-----------------------------------------------------------
src/master/master.cpp (lines 4131 - 4134)
<https://reviews.apache.org/r/37175/#comment155393>
I think we have done this in Master::Http::maintenanceSchedule(), so why we do it again here? Maybe remove the duplicated code from Master::Http::maintenanceSchedule()?
- Qian Zhang
On Sept. 14, 2015, 4:33 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 14, 2015, 4:33 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review98798
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Sept. 14, 2015, 12:46 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/
-----------------------------------------------------------
(Updated Sept. 13, 2015, 8:33 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
Diff: https://reviews.apache.org/r/37175/diff/
Testing
-------
Thanks,
Joris Van Remoortere
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joris Van Remoortere <jo...@gmail.com>.
> On Sept. 2, 2015, 10:04 p.m., Joseph Wu wrote:
> > include/mesos/master/allocator.hpp, lines 138-141
> > <https://reviews.apache.org/r/37175/diff/6/?file=1062494#file1062494line138>
> >
> > Consider Doxygen-ification.
I don't want to start another debate around "mixed vs not mixed doxygen comments"; so we can doxygenify this whole file in a separate review :-)
Thanks for looking out though!
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review97527
-----------------------------------------------------------
On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2015, 8:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3
> src/master/http.cpp 73e8857833603cb0edb77c352f343070ee1b8c80
> src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24
> src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 37175: Maintenance Primitives: Added
updateUnavailability to master.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37175/#review97527
-----------------------------------------------------------
Ship it!
include/mesos/master/allocator.hpp (lines 138 - 141)
<https://reviews.apache.org/r/37175/#comment153481>
Consider Doxygen-ification.
src/master/http.cpp (lines 1448 - 1450)
<https://reviews.apache.org/r/37175/#comment153482>
You'll probably want to delete this line, since `updateUnavailability` does that for us.
src/master/http.cpp (line 1466)
<https://reviews.apache.org/r/37175/#comment153486>
You'll probably want to delete this line, since `updateUnavailability` does that for us.
src/tests/master_maintenance_tests.cpp (lines 360 - 361)
<https://reviews.apache.org/r/37175/#comment153491>
Rebase mistake?
- Joseph Wu
On Sept. 2, 2015, 12:31 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37175/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 12:31 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
>
>
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a
> src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659
> src/master/allocator/mesos/hierarchical.hpp 38f8fd2c84314bb3731684d0e9795cb4f50a227e
> src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
> src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c
> src/tests/mesos.hpp 906948d459b5a88a4ad7952801eb8c540b58c569
>
> Diff: https://reviews.apache.org/r/37175/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Joris Van Remoortere
>
>