You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/08/10 08:50:53 UTC

[GitHub] [shardingsphere] soulasuna opened a new pull request #11743: Refactor shardingsphere-shadow-core first step

soulasuna opened a new pull request #11743:
URL: https://github.com/apache/shardingsphere/pull/11743


   ##  Refactor shardingsphere-shadow-core first step
   
   For #11661
   
   Changes proposed in this pull request:
   -  Add shadow future function interface function.
   -  Add shadow future function basic skeleton classes.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #11743: Refactor shardingsphere-shadow-core first step

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11743:
URL: https://github.com/apache/shardingsphere/pull/11743#issuecomment-895892147


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11743](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (501e254) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6972cf8fb26a9393d7f6a8386fd74e0917cdaeee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6972cf8) will **decrease** coverage by `0.09%`.
   > The diff coverage is `8.51%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11743/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11743      +/-   ##
   ============================================
   - Coverage     63.66%   63.57%   -0.10%     
   - Complexity     1122     1126       +4     
   ============================================
     Files          2269     2293      +24     
     Lines         34632    34778     +146     
     Branches       6029     6048      +19     
   ============================================
   + Hits          22049    22110      +61     
   - Misses        10819    10894      +75     
   - Partials       1764     1774      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...oute/future/build/ShadowDecorateEngineBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2J1aWxkL1NoYWRvd0RlY29yYXRlRW5naW5lQnVpbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ate/impl/ShadowDataSourceRouterDecorateEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9kZWNvcmF0ZS9pbXBsL1NoYWRvd0RhdGFTb3VyY2VSb3V0ZXJEZWNvcmF0ZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../impl/DeleteShadowDataSourceRouterJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL0RlbGV0ZVNoYWRvd0RhdGFTb3VyY2VSb3V0ZXJKdWRnZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../impl/InsertShadowDataSourceRouterJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL0luc2VydFNoYWRvd0RhdGFTb3VyY2VSb3V0ZXJKdWRnZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../impl/NonMDLShadowDataSourceRouterJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL05vbk1ETFNoYWRvd0RhdGFTb3VyY2VSb3V0ZXJKdWRnZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../impl/SelectShadowDataSourceRouterJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL1NlbGVjdFNoYWRvd0RhdGFTb3VyY2VSb3V0ZXJKdWRnZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../impl/UpdateShadowDataSourceRouterJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL1VwZGF0ZVNoYWRvd0RhdGFTb3VyY2VSb3V0ZXJKdWRnZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...mpl/DeleteShadowDataSourceRouterRewriteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9yZXdyaXRlL2ltcGwvRGVsZXRlU2hhZG93RGF0YVNvdXJjZVJvdXRlclJld3JpdGVFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...mpl/InsertShadowDataSourceRouterRewriteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9yZXdyaXRlL2ltcGwvSW5zZXJ0U2hhZG93RGF0YVNvdXJjZVJvdXRlclJld3JpdGVFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...mpl/NonMDLShadowDataSourceRouterRewriteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9yZXdyaXRlL2ltcGwvTm9uTURMU2hhZG93RGF0YVNvdXJjZVJvdXRlclJld3JpdGVFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [64 more](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6972cf8...501e254](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #11743: Refactor shardingsphere-shadow-core first step

Posted by GitBox <gi...@apache.org>.
tristaZero commented on a change in pull request #11743:
URL: https://github.com/apache/shardingsphere/pull/11743#discussion_r685975945



##########
File path: shardingsphere-features/shardingsphere-shadow/shardingsphere-shadow-core/src/main/java/org/apache/shardingsphere/shadow/route/future/util/ShadowFunctionUtil.java
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.shadow.route.future.util;
+
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+
+import java.util.Objects;
+
+/**
+ * Shadow function util.
+ */
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public final class ShadowFunctionUtil {
+    
+    /**
+     * Compare value.
+     *
+     * @param actualValue actual value
+     * @param expectedValue expected value
+     * @return is same value or not
+     */
+    public static boolean compareValue(final Object actualValue, final String expectedValue) {
+        return !Objects.isNull(actualValue) && expectedValue.equals(String.valueOf(actualValue));

Review comment:
       Is it a temporary class?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] soulasuna commented on pull request #11743: Refactor shardingsphere-shadow-core first step

Posted by GitBox <gi...@apache.org>.
soulasuna commented on pull request #11743:
URL: https://github.com/apache/shardingsphere/pull/11743#issuecomment-895944327


   > please do not use a verb as the very beginning of your class name.
   > for example, `DeleteShadowDataSourceRouterJudgeEngine`, you could chang to `ShadowDataSourceRouterDeletionJudgeEngine`
   
   Thank you for your suggestion, I will fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero merged pull request #11743: Refactor shardingsphere-shadow-core first step

Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11743:
URL: https://github.com/apache/shardingsphere/pull/11743


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11743: Refactor shardingsphere-shadow-core first step

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11743:
URL: https://github.com/apache/shardingsphere/pull/11743#issuecomment-895892147


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11743](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6697a4) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6972cf8fb26a9393d7f6a8386fd74e0917cdaeee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6972cf8) will **decrease** coverage by `0.09%`.
   > The diff coverage is `8.51%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11743/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11743      +/-   ##
   ============================================
   - Coverage     63.66%   63.57%   -0.10%     
   - Complexity     1122     1126       +4     
   ============================================
     Files          2269     2293      +24     
     Lines         34632    34778     +146     
     Branches       6029     6048      +19     
   ============================================
   + Hits          22049    22110      +61     
   - Misses        10819    10894      +75     
   - Partials       1764     1774      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...oute/future/build/ShadowDecorateEngineBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2J1aWxkL1NoYWRvd0RlY29yYXRlRW5naW5lQnVpbGRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ate/impl/ShadowDataSourceRouterDecorateEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9kZWNvcmF0ZS9pbXBsL1NoYWRvd0RhdGFTb3VyY2VSb3V0ZXJEZWNvcmF0ZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...mpl/ShadowDataSourceRouterDeletionJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL1NoYWRvd0RhdGFTb3VyY2VSb3V0ZXJEZWxldGlvbkp1ZGdlRW5naW5lLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [.../impl/ShadowDataSourceRouterInsertJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL1NoYWRvd0RhdGFTb3VyY2VSb3V0ZXJJbnNlcnRKdWRnZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../impl/ShadowDataSourceRouterNonMDLJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL1NoYWRvd0RhdGFTb3VyY2VSb3V0ZXJOb25NRExKdWRnZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...pl/ShadowDataSourceRouterSelectionJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL1NoYWRvd0RhdGFTb3VyY2VSb3V0ZXJTZWxlY3Rpb25KdWRnZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../impl/ShadowDataSourceRouterUpdateJudgeEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9qdWRnZS9pbXBsL1NoYWRvd0RhdGFTb3VyY2VSb3V0ZXJVcGRhdGVKdWRnZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...l/ShadowDataSourceRouterDeletionRewriteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9yZXdyaXRlL2ltcGwvU2hhZG93RGF0YVNvdXJjZVJvdXRlckRlbGV0aW9uUmV3cml0ZUVuZ2luZS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...mpl/ShadowDataSourceRouterInsertRewriteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9yZXdyaXRlL2ltcGwvU2hhZG93RGF0YVNvdXJjZVJvdXRlckluc2VydFJld3JpdGVFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...mpl/ShadowDataSourceRouterNonMDLRewriteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9yZXdyaXRlL2ltcGwvU2hhZG93RGF0YVNvdXJjZVJvdXRlck5vbk1ETFJld3JpdGVFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | ... and [64 more](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6972cf8...f6697a4](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #11743: Refactor shardingsphere-shadow-core first step

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11743:
URL: https://github.com/apache/shardingsphere/pull/11743#issuecomment-895892147


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#11743](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f9bd342) into [master](https://codecov.io/gh/apache/shardingsphere/commit/6972cf8fb26a9393d7f6a8386fd74e0917cdaeee?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6972cf8) will **decrease** coverage by `0.08%`.
   > The diff coverage is `11.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/11743/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #11743      +/-   ##
   ============================================
   - Coverage     63.66%   63.58%   -0.09%     
   - Complexity     1122     1127       +5     
   ============================================
     Files          2269     2290      +21     
     Lines         34632    34802     +170     
     Branches       6029     6051      +22     
   ============================================
   + Hits          22049    22129      +80     
   - Misses        10819    10899      +80     
   - Partials       1764     1774      +10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../route/future/engine/ShadowRouteEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9TaGFkb3dSb3V0ZUVuZ2luZUZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ngine/impl/ShadowDeleteStatementRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9pbXBsL1NoYWRvd0RlbGV0ZVN0YXRlbWVudFJvdXRpbmdFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ngine/impl/ShadowInsertStatementRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9pbXBsL1NoYWRvd0luc2VydFN0YXRlbWVudFJvdXRpbmdFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ngine/impl/ShadowNonMDLStatementRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9pbXBsL1NoYWRvd05vbk1ETFN0YXRlbWVudFJvdXRpbmdFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ngine/impl/ShadowSelectStatementRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9pbXBsL1NoYWRvd1NlbGVjdFN0YXRlbWVudFJvdXRpbmdFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ngine/impl/ShadowUpdateStatementRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL2VuZ2luZS9pbXBsL1NoYWRvd1VwZGF0ZVN0YXRlbWVudFJvdXRpbmdFbmdpbmUuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ngsphere/shadow/route/future/util/CompareUtil.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvZnV0dXJlL3V0aWwvQ29tcGFyZVV0aWwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/shardingsphere/shadow/route/ShadowSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvU2hhZG93U1FMUm91dGVyLmphdmE=) | `89.13% <50.00%> (-8.37%)` | :arrow_down: |
   | [...ig/swapper/YamlDataSourceConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL1lhbWxEYXRhU291cmNlQ29uZmlndXJhdGlvblN3YXBwZXIuamF2YQ==) | `68.75% <0.00%> (-31.25%)` | :arrow_down: |
   | [.../driver/jdbc/adapter/AbstractStatementAdapter.java](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2FkYXB0ZXIvQWJzdHJhY3RTdGF0ZW1lbnRBZGFwdGVyLmphdmE=) | `79.68% <0.00%> (-15.63%)` | :arrow_down: |
   | ... and [68 more](https://codecov.io/gh/apache/shardingsphere/pull/11743/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6972cf8...f9bd342](https://codecov.io/gh/apache/shardingsphere/pull/11743?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org