You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/02 02:32:36 UTC

[GitHub] [shardingsphere] Zhoutzzz commented on a diff in pull request #18097: fix when table alias case different throw NullPointException

Zhoutzzz commented on code in PR #18097:
URL: https://github.com/apache/shardingsphere/pull/18097#discussion_r887446259


##########
shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/extractor/TableExtractor.java:
##########
@@ -260,7 +260,7 @@ public void extractTablesFromUpdate(final UpdateStatement updateStatement) {
      */
     public boolean needRewrite(final OwnerSegment owner) {
         for (TableSegment each : tableContext) {
-            if (owner.getIdentifier().getValue().equals(each.getAlias().orElse(null))) {
+            if (owner.getIdentifier().getValue().equalsIgnoreCase(each.getAlias().orElse(null))) {

Review Comment:
   this sql follow sql92 protocol



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org