[jira] [Updated] (HBASE-14249) shaded jar modules create spurious source and test jars with incorrect LICENSE/NOTICE info

["Sean Busbey (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Busbey updated HBASE-14249:
--------------------------------
    Assignee: Andrew Purtell  (was: Sean Busbey)

This one should be relatively easy to fix. we just need to say to skip the source-jar plugin and the jar execution for building the test-jar.

those both get set up in the root pom, and I think we can configure skipping both in the parent-of-shaded-jars pom.

my big concern is that we should be skipping the test-jar already (from hbase-shaded/pom.xml):

{code}
    <properties>
      <!-- Don't make a test-jar -->
      <maven.test.skip>true</maven.test.skip>
{code}

> shaded jar modules create spurious source and test jars with incorrect LICENSE/NOTICE info
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14249
>                 URL: https://issues.apache.org/jira/browse/HBASE-14249
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.0, 1.2.0, 1.1.2
>            Reporter: Sean Busbey
>            Assignee: Andrew Purtell
>            Priority: Blocker
>
> the shaded jar modules don't need to create a source or test jar (because the jars contain nothing other than META-INF)
> currently we create 
>  * the test jars are missing LICENSE
>  * source jars have LICENSE/NOTICE files that claim all the bundled works in the normal jar.
> {code}
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar//META-INF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-server-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar//META-INF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-client-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar//META-INF
> hbase-shaded-client-1.1.2-tests.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar//META-INF
> hbase-shaded-server-1.1.2-tests.jar//META-INF/NOTICE
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)