You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Digy (JIRA)" <ji...@apache.org> on 2009/05/19 21:14:45 UTC
[jira] Created: (LUCENENET-182) Public fields of StringIndex class
should have C# like names
Public fields of StringIndex class should have C# like names
------------------------------------------------------------
Key: LUCENENET-182
URL: https://issues.apache.org/jira/browse/LUCENENET-182
Project: Lucene.Net
Issue Type: Improvement
Environment: Lucene.Net 2.3.2
Reporter: Digy
Priority: Trivial
Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (LUCENENET-182) Public fields of StringIndex class
should have C# like names
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy closed LUCENENET-182.
--------------------------
Resolution: Fixed
> Public fields of StringIndex class should have C# like names
> ------------------------------------------------------------
>
> Key: LUCENENET-182
> URL: https://issues.apache.org/jira/browse/LUCENENET-182
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Lucene.Net 2.3.2
> Reporter: Digy
> Priority: Trivial
> Attachments: LUCENENET-182.patch, LUCENENET-182.patch
>
>
> Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-182) Public fields of StringIndex
class should have C# like names
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711208#action_12711208 ]
Digy commented on LUCENENET-182:
--------------------------------
Hi Neal,
IndexSearcher#getIndexReader --> IndexSearcher#GetIndexReader
IndexSearcher#close --> IndexSearcher#Close
QueryParser#parse --> QueryParser#Parse
etc.
these kind of changes are already made throughout the Lucene.Net.
So, I can't see any reason why we shouldn't change
StringIndex#loopup to StringIndex#Loopup
and
StringIndex#order to StringIndex#Order
{color:red}
*http://incubator.apache.org/lucene.net/*
Lucene.Net sticks to the APIs and classes used in the original Java implementation of Lucene. The API names as well as class names are preserved with the intention of giving Lucene.Net the look and feel of the C# language and the .NET Framework. For example, the method Hits.length() in the Java implementation now reads Hits.Length() in the C# port.
{color}
DIGY
> Public fields of StringIndex class should have C# like names
> ------------------------------------------------------------
>
> Key: LUCENENET-182
> URL: https://issues.apache.org/jira/browse/LUCENENET-182
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Lucene.Net 2.3.2
> Reporter: Digy
> Priority: Trivial
> Attachments: LUCENENET-182.patch, LUCENENET-182.patch
>
>
> Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-182) Public fields of StringIndex
class should have C# like names
Posted by "Robert Jordan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710889#action_12710889 ]
Robert Jordan commented on LUCENENET-182:
-----------------------------------------
Parameters were always part of the API in MS.NET. I was not well communicated until now, but it will start to be an issue with the coming C# 4.0 that will support named parameters.
> Public fields of StringIndex class should have C# like names
> ------------------------------------------------------------
>
> Key: LUCENENET-182
> URL: https://issues.apache.org/jira/browse/LUCENENET-182
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Lucene.Net 2.3.2
> Reporter: Digy
> Priority: Trivial
> Attachments: LUCENENET-182.patch, LUCENENET-182.patch
>
>
> Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-182) Public fields of StringIndex class
should have C# like names
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-182:
---------------------------
Attachment: LUCENENET-182.patch
> Public fields of StringIndex class should have C# like names
> ------------------------------------------------------------
>
> Key: LUCENENET-182
> URL: https://issues.apache.org/jira/browse/LUCENENET-182
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Lucene.Net 2.3.2
> Reporter: Digy
> Priority: Trivial
> Attachments: LUCENENET-182.patch
>
>
> Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-182) Public fields of StringIndex
class should have C# like names
Posted by "Neal Granroth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711694#action_12711694 ]
Neal Granroth commented on LUCENENET-182:
-----------------------------------------
Hi Digy,
Thanks for the clarification.
I was trying to champion flexibility and avoid the project being tied to tightly to specific coding styles or features like the old-style "named parameters" that is being brought back as something "new" for C# 4.0.
-- Neal
> Public fields of StringIndex class should have C# like names
> ------------------------------------------------------------
>
> Key: LUCENENET-182
> URL: https://issues.apache.org/jira/browse/LUCENENET-182
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Lucene.Net 2.3.2
> Reporter: Digy
> Priority: Trivial
> Attachments: LUCENENET-182.patch, LUCENENET-182.patch
>
>
> Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-182) Public fields of StringIndex
class should have C# like names
Posted by "Robert Jordan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710849#action_12710849 ]
Robert Jordan commented on LUCENENET-182:
-----------------------------------------
- public StringIndex(int[] values, System.String[] lookup)
+ public StringIndex(int[] Values, System.String[] Lookup)
This not a valid C# style. Parameters must not start with an uppercased letter.
> Public fields of StringIndex class should have C# like names
> ------------------------------------------------------------
>
> Key: LUCENENET-182
> URL: https://issues.apache.org/jira/browse/LUCENENET-182
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Lucene.Net 2.3.2
> Reporter: Digy
> Priority: Trivial
> Attachments: LUCENENET-182.patch
>
>
> Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-182) Public fields of StringIndex class
should have C# like names
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-182:
---------------------------
Attachment: LUCENENET-182.patch
> Public fields of StringIndex class should have C# like names
> ------------------------------------------------------------
>
> Key: LUCENENET-182
> URL: https://issues.apache.org/jira/browse/LUCENENET-182
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Lucene.Net 2.3.2
> Reporter: Digy
> Priority: Trivial
> Attachments: LUCENENET-182.patch, LUCENENET-182.patch
>
>
> Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-182) Public fields of StringIndex
class should have C# like names
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710884#action_12710884 ]
Digy commented on LUCENENET-182:
--------------------------------
Main point here is the casing of public fields not parameters. OK. parameter can be left as they are.
DIGY
> Public fields of StringIndex class should have C# like names
> ------------------------------------------------------------
>
> Key: LUCENENET-182
> URL: https://issues.apache.org/jira/browse/LUCENENET-182
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Lucene.Net 2.3.2
> Reporter: Digy
> Priority: Trivial
> Attachments: LUCENENET-182.patch
>
>
> Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-182) Public fields of StringIndex
class should have C# like names
Posted by "Neal Granroth (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711141#action_12711141 ]
Neal Granroth commented on LUCENENET-182:
-----------------------------------------
Adherence to one particular set of coding style guidelines used by just one group of developers is not particularly helpful.
Consistency with the naming conventions used by the mainline Java Lucene project is of far greater importance.
I would recommend no change unless the current names used conflict with mainline Java Lucene.
> Public fields of StringIndex class should have C# like names
> ------------------------------------------------------------
>
> Key: LUCENENET-182
> URL: https://issues.apache.org/jira/browse/LUCENENET-182
> Project: Lucene.Net
> Issue Type: Improvement
> Environment: Lucene.Net 2.3.2
> Reporter: Digy
> Priority: Trivial
> Attachments: LUCENENET-182.patch, LUCENENET-182.patch
>
>
> Public fields (lookup, order) of Lucene.Net.Search.StringIndex can be/are used outside of Lucene.Net and their names should be compatible with C#.
> DIGY
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.