You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/10 02:02:32 UTC
[GitHub] [skywalking-satellite] gxthrj opened a new pull request #36: feat: proemtheus fetcher draft
gxthrj opened a new pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on a change in pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#discussion_r599170571
##########
File path: plugins/fetcher/prometheus/metrics_adjuster.go
##########
@@ -0,0 +1,376 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+// Refers to https://github.com/open-telemetry/opentelemetry-collector [Apache-2.0 License]
Review comment:
Will rm the code about. OC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-796756369
Thanks for reminding, I am designing this configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] moonming commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-802465511
@gxthrj any response?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#discussion_r595293697
##########
File path: plugins/fetcher/prometheus/metrics_adjuster.go
##########
@@ -0,0 +1,376 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+// Refers to https://github.com/open-telemetry/opentelemetry-collector [Apache-2.0 License]
Review comment:
Could you confirm what do you mean by `refer`? It is copy or change part of them?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-848397298
close this pr, will re-create a pr later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on a change in pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
gxthrj commented on a change in pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#discussion_r599170541
##########
File path: plugins/fetcher/prometheus/metric_family.go
##########
@@ -244,11 +248,10 @@ func getBoundary(metricType metricspb.MetricDescriptor_Type, labels labels.Label
func (mf *metricFamily) ToMetric() (*metricspb.Metric, int, int) {
timeseries := make([]*metricspb.TimeSeries, 0, len(mf.groups))
switch mf.mtype {
- // not supported currently
- // case metricspb.MetricDescriptor_GAUGE_DISTRIBUTION:
- // return nil
+ // only cumulative metrics will be processed here
Review comment:
Will rm the code about. OC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#discussion_r595292937
##########
File path: plugins/fetcher/prometheus/metric_family.go
##########
@@ -244,11 +248,10 @@ func getBoundary(metricType metricspb.MetricDescriptor_Type, labels labels.Label
func (mf *metricFamily) ToMetric() (*metricspb.Metric, int, int) {
timeseries := make([]*metricspb.TimeSeries, 0, len(mf.groups))
switch mf.mtype {
- // not supported currently
- // case metricspb.MetricDescriptor_GAUGE_DISTRIBUTION:
- // return nil
+ // only cumulative metrics will be processed here
Review comment:
I am not sure about this comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj closed pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
gxthrj closed pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-835133457
> @gxthrj This is no progress in 2 months, what is going on here?
Will restart this next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-804599503
> I will rm OC logic, just use skywalking meter metrics structs.
cc @EvanLjp @hanahmily @wankai123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] gxthrj commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
gxthrj commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-804502489
I will rm OC logic, just use skywalking meter metrics structs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-796499656
Please make sure this configuration could be mostly as same as Prometheus native config, like OpenTelemetry supposed to do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-834222494
@gxthrj This is no progress in 2 months, what is going on here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] EvanLjp commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
EvanLjp commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-809107559
@gxthrj Ci failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #36: feat: proemtheus fetcher draft
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #36:
URL: https://github.com/apache/skywalking-satellite/pull/36#issuecomment-796874127
> Thanks for reminding, I am designing this configuration.
Thanks. The best case is we could copy all settings of the origin in the Prometheus, because they have wide adoption, and we are more focusing on further analysis, rather than scratching itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org