You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by j....@gmail.com on 2017/05/26 21:28:34 UTC

Re: Review Request 57893: HIVE-16285: Servlet for dynamically configuring log levels

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57893/
-----------------------------------------------------------

(Updated May 26, 2017, 9:28 p.m.)


Review request for hive, Gopal V and Siddharth Seth.


Changes
-------

Rebased patch.


Bugs: HIVE-16285
    https://issues.apache.org/jira/browse/HIVE-16285


Repository: hive-git


Description
-------

Many long running services like HS2, LLAP etc. will benefit from having an endpoint to dynamically change log levels for various loggers. This will help greatly with debuggability without requiring a restart of the service.


Diffs (updated)
-----

  common/src/java/org/apache/hive/http/HttpServer.java 0bc0032 
  common/src/java/org/apache/hive/http/Log4j2ConfiguratorServlet.java PRE-CREATION 
  llap-server/src/java/org/apache/hadoop/hive/llap/daemon/impl/TaskExecutorService.java 7f8c947 
  llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java 18ce03c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/AppMasterEventOperator.java bf30ef1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java df1898e 
  ql/src/java/org/apache/hadoop/hive/ql/exec/DemuxOperator.java c184742 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java f3c571a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java af5e90f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/HashTableSinkOperator.java 3a366f6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 0282763 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapJoinOperator.java 4971707 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapOperator.java 2a46b30 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MuxOperator.java 9849243 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 8b04cd4 
  ql/src/java/org/apache/hadoop/hive/ql/exec/OrcFileMergeOperator.java e3cb765 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java e03f4b7 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 7c1e344 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ScriptOperator.java 4767af1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 94af097 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java 68477ca 
  ql/src/java/org/apache/hadoop/hive/ql/exec/UnionOperator.java 3df5533 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecReducer.java 1dffff2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ObjectCache.java cfe1750 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkMapRecordHandler.java 48dfedc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkReduceRecordHandler.java 7eaad18 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ColumnarSplitSizeEstimator.java ecd4ddc 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HostAffinitySplitLocationProvider.java dcb985f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/LlapObjectCache.java 1ce8ee9 
  ql/src/java/org/apache/hadoop/hive/ql/exec/tez/RecordProcessor.java 106a534 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinCommonOperator.java f854132 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinGenerateResultOperator.java c4d5113 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyLongOperator.java 43f3951 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyMultiKeyOperator.java 95fb0c2 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerBigOnlyStringOperator.java 044e3e6 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerLongOperator.java c85e1d8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerMultiKeyOperator.java a108cd0 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinInnerStringOperator.java 3211d7d 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiLongOperator.java b02e6fd 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiMultiKeyOperator.java 36b8f3f 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinLeftSemiStringOperator.java 0b3de0a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterGenerateResultOperator.java 0e2d65a 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterLongOperator.java 72309e8 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterMultiKeyOperator.java a4fc7d3 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/VectorMapJoinOuterStringOperator.java 6e7e5cb 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java 10bc902 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java 54e667c 
  ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java 99819cf 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/ExternalCache.java 9299306 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 8fb7211 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 6844713 
  serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyBinary.java aa19d09 


Diff: https://reviews.apache.org/r/57893/diff/6/

Changes: https://reviews.apache.org/r/57893/diff/5-6/


Testing
-------


Thanks,

Prasanth_J