[GitHub] [airflow] XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method

[GitBox <gi...@apache.org>]

XD-DENG commented on a change in pull request #5317: [AIRFLOW-4562 ] Fix missing try_number parameter in TaskInstance.log_filepath method
URL: https://github.com/apache/airflow/pull/5317#discussion_r286827908
 
 

 ##########
 File path: airflow/models/taskinstance.py
 ##########
 @@ -376,7 +379,8 @@ def log_url(self):
             "execution_date={iso}"
             "&task_id={task_id}"
             "&dag_id={dag_id}"
-        ).format(iso=iso, task_id=self.task_id, dag_id=self.dag_id)
+            "&try_number={try_number}"
 
 Review comment:
   This actually will not work. `try_number` is not accepted by `/log` endpoint as an argument. 
   Please refer to https://github.com/apache/airflow/blob/master/airflow/www/views.py#L581.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services